[PATCH] gnu: valgrind/interactive: Update to 3.19.0.

OpenSubmitted by Greg Hogan.
Details
2 participants
  • Greg Hogan
  • Tobias Geerinckx-Rice
Owner
unassigned
Severity
normal
G
G
Greg Hogan wrote on 14 Jun 17:38 +0200
(address . guix-patches@gnu.org)(name . Greg Hogan)(address . code@greghogan.com)
59a90121e4006f727752b7fee50ec9365be47134.1655220225.git.code@greghogan.com
* gnu/packages/valgrind.scm (valgrind/interactive): Update to 3.19.0.
[home-page]: Update permanent redirect.
* gnu/packages/valgrind.scm (valgrind-3.18): Delete.
---
This patch bumps the version of the non-hidden valgrind while removing
the pinned-version package. Looking through the commit history, I do see
a reason for having both a valgrind/interactive and valgrind-3.18.

$ ./pre-inst-env guix refresh -l valgrind
No dependents other than itself: valgrind@3.19.0

gnu/packages/valgrind.scm | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)

Toggle diff (51 lines)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 63524d59e9..8e9a4c39f4 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -79,7 +79,7 @@ (define-public valgrind
                #t))))))
     (native-inputs
      (list perl))
-    (home-page "https://www.valgrind.org/")
+    (home-page "https://valgrind.org/")
     (synopsis "Debugging and profiling tool suite")
     (description
      "Valgrind is an instrumentation framework for building dynamic analysis
@@ -96,7 +96,7 @@ (define-public valgrind
 (define-public valgrind/interactive
   (package/inherit
    valgrind
-   (version "3.17.0")
+   (version "3.19.0")
    (source (origin
              (method url-fetch)
              (uri (list (string-append "https://sourceware.org/pub/valgrind"
@@ -105,7 +105,7 @@ (define-public valgrind/interactive
                                        "/valgrind-" version ".tar.bz2")))
              (sha256
               (base32
-               "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
+               "00lgfgb38xbrilkw6xvqk284dcnnnhbcq03kpvvkyj0sdx438pnx"))
              (patches (search-patches
                        "valgrind-enable-arm.patch"
                        "valgrind-fix-default-debuginfo-path.patch"))))
@@ -148,17 +148,3 @@ (define-public valgrind/interactive
                       (string-length "/usr/lib/debug")
                       1))))))))))
    (properties '())))
-
-(define-public valgrind-3.18
-  (package
-    (inherit valgrind/interactive)
-    (version "3.18.1")
-    (source (origin
-              (inherit (package-source valgrind/interactive))
-              (uri (list (string-append "https://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")
-                         (string-append "ftp://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")))
-              (sha256
-               (base32
-                "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))))))
-- 
2.36.1
T
T
Tobias Geerinckx-Rice wrote on 14 Jun 23:19 +0200
87v8t3vsra@nckx
Hi Greg,

Greg Hogan 写道:
Toggle quote (9 lines)
> * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> 3.19.0.
> [home-page]: Update permanent redirect.
> * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> ---
> This patch bumps the version of the non-hidden valgrind while
> removing
> the pinned-version package.

Unless I'm mistaken these 2 tasks are independent, and should
hence be split across 2 patches.

Toggle quote (5 lines)
> Looking through the commit history,
> I do see
> a reason for having both a valgrind/interactive and
> valgrind-3.18.

I thought this was a typo for ‘don't’ at first, but I really can't
tell.

I don't see a reason to keep both now, but then I don't see one
when 50f7402c was committed either. Do you remember, Ludo'?

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYqj9qQ0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15VAAA/0IPK5E2Ij2GIiUqoTGQaN1TA5fGtBnzNxjma6V+
mmjiAQDYGtEGNAwiz+esA4imn1ZNQBordd0YzQRtusURFfDKBw==
=wfGp
-----END PGP SIGNATURE-----

G
G
Greg Hogan wrote on 15 Jun 15:55 +0200
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
CA+3U0ZnDLEiXBT+6c06KEcENcXU5s5WVLgmDpv5ftzZnu0Ztug@mail.gmail.com
On Tue, Jun 14, 2022 at 5:29 PM Tobias Geerinckx-Rice <me@tobias.gr> wrote:
Toggle quote (16 lines)
>
> Hi Greg,
>
> Greg Hogan 写道:
> > * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> > 3.19.0.
> > [home-page]: Update permanent redirect.
> > * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> > ---
> > This patch bumps the version of the non-hidden valgrind while
> > removing
> > the pinned-version package.
>
> Unless I'm mistaken these 2 tasks are independent, and should
> hence be split across 2 patches.

I will split the commit and send a v2 patchset upon confirmation of
the valgrind-3.18 removal..

Toggle quote (8 lines)
> > Looking through the commit history,
> > I do see
> > a reason for having both a valgrind/interactive and
> > valgrind-3.18.
>
> I thought this was a typo for ‘don't’ at first, but I really can't
> tell.

You are correct, this should have said "don't see a reason".

Toggle quote (7 lines)
> I don't see a reason to keep both now, but then I don't see one
> when 50f7402c was committed either. Do you remember, Ludo'?
>
> Kind regards,
>
> T G-R

Thanks for the review!

Greg
G
G
Greg Hogan wrote on 7 Jul 16:24 +0200
[PATCH v2 1/2] gnu: valgrind/interactive: Update to 3.19.0.
(address . 55976@debbugs.gnu.org)(name . Greg Hogan)(address . code@greghogan.com)
b2c992e06ed2f0b835cacc624b797dd4915e8e68.1657203550.git.code@greghogan.com
* gnu/packages/valgrind.scm (valgrind/interactive): Update to 3.19.0.
[home-page]: Update permanent redirect.
---
gnu/packages/valgrind.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 63524d59e9..1356fd57de 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -79,7 +79,7 @@ (define-public valgrind
                #t))))))
     (native-inputs
      (list perl))
-    (home-page "https://www.valgrind.org/")
+    (home-page "https://valgrind.org/")
     (synopsis "Debugging and profiling tool suite")
     (description
      "Valgrind is an instrumentation framework for building dynamic analysis
@@ -96,7 +96,7 @@ (define-public valgrind
 (define-public valgrind/interactive
   (package/inherit
    valgrind
-   (version "3.17.0")
+   (version "3.19.0")
    (source (origin
              (method url-fetch)
              (uri (list (string-append "https://sourceware.org/pub/valgrind"
@@ -105,7 +105,7 @@ (define-public valgrind/interactive
                                        "/valgrind-" version ".tar.bz2")))
              (sha256
               (base32
-               "18l5jbk301j3462gipqn9bkfx44mdmwn0pwr73r40gl1irkfqfmd"))
+               "00lgfgb38xbrilkw6xvqk284dcnnnhbcq03kpvvkyj0sdx438pnx"))
              (patches (search-patches
                        "valgrind-enable-arm.patch"
                        "valgrind-fix-default-debuginfo-path.patch"))))
-- 
2.36.1
G
G
Greg Hogan wrote on 7 Jul 16:24 +0200
[PATCH v2 2/2] gnu: valgrind-3.18: Delete.
(address . 55976@debbugs.gnu.org)(name . Greg Hogan)(address . code@greghogan.com)
e81f2cb37efd02ab0e872b2d52560323e428c185.1657203550.git.code@greghogan.com
* gnu/packages/valgrind.scm (valgrind-3.18): Delete.
---
gnu/packages/valgrind.scm | 14 --------------
1 file changed, 14 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/valgrind.scm b/gnu/packages/valgrind.scm
index 1356fd57de..8e9a4c39f4 100644
--- a/gnu/packages/valgrind.scm
+++ b/gnu/packages/valgrind.scm
@@ -148,17 +148,3 @@ (define-public valgrind/interactive
                       (string-length "/usr/lib/debug")
                       1))))))))))
    (properties '())))
-
-(define-public valgrind-3.18
-  (package
-    (inherit valgrind/interactive)
-    (version "3.18.1")
-    (source (origin
-              (inherit (package-source valgrind/interactive))
-              (uri (list (string-append "https://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")
-                         (string-append "ftp://sourceware.org/pub/valgrind"
-                                        "/valgrind-" version ".tar.bz2")))
-              (sha256
-               (base32
-                "1xgph509i6adv9w2glviw3xrmlz0dssg8992hbvxsbkp7ahrm180"))))))
-- 
2.36.1
G
G
Greg Hogan wrote on 7 Jul 16:24 +0200
[PATCH v2 0/2] Update valgrind
(address . 55976@debbugs.gnu.org)(name . Greg Hogan)(address . code@greghogan.com)
cover.1657203550.git.code@greghogan.com
This patchset divides the original patch into separate patches for
updation and deletion.

Greg Hogan (2):
gnu: valgrind/interactive: Update to 3.19.0.
gnu: valgrind-3.18: Delete.

gnu/packages/valgrind.scm | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)

--
2.36.1
?