[PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768.

DoneSubmitted by Erik Šabič.
Details
3 participants
  • Erik Šabič
  • Ludovic Courtès
  • Maxime Devos
Owner
unassigned
Severity
normal
E
E
Erik Šabič wrote on 27 May 14:52 +0200
(address . guix-patches@gnu.org)
20220527125242.27817-1-erik.sab@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-elm-mode): Update to 0.21.0-1.1e27768.
---
gnu/packages/emacs-xyz.scm | 43 +++++++++++++++++++-------------------
1 file changed, 22 insertions(+), 21 deletions(-)

Toggle diff (65 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f7fb6aac35..f62c733fb5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19692,26 +19692,27 @@ (define-public emacs-ibuffer-vc
     (license license:gpl3+)))
 
 (define-public emacs-elm-mode
-  (package
-    (name "emacs-elm-mode")
-    (version "0.21.0")
-    (source
-     (origin
-       (method git-fetch)
-       (uri
-        (git-reference
-         (url "https://github.com/jcollard/elm-mode")
-         (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0iwk4fmw8hq3ry4ky1zc7lgl4cpbnrjyk74c2xzddfspi3ks41fd"))))
-    (propagated-inputs
-     (list emacs-dash emacs-f emacs-reformatter emacs-s))
-    (build-system emacs-build-system)
-    (home-page "https://github.com/jcollard/elm-mode")
-    (synopsis "Emacs major mode for editing Elm source code")
-    (description
-     "This package provides a major mode for editing Elm source code, and
+  ;; Version tag 0.21.0 was made Jan 14 2020. It doesn't work with Emacs 28
+  ;; due to missing, now-mandatory "when" arg for obsolete function alias.
+  (let ((commit "1e277684d8a6681a2410cce2dd589ee30a998369"))
+    (package
+      (name "emacs-elm-mode")
+      (version (git-version "0.21.0" "1" commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jcollard/elm-mode")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1gnr61ibzcznfqy5f8capmbz75rcfikwy106rjdmp45qz2jwp4di"))))
+      (propagated-inputs (list emacs-f emacs-reformatter emacs-s))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/jcollard/elm-mode")
+      (synopsis "Emacs major mode for editing Elm source code")
+      (description
+       "This package provides a major mode for editing Elm source code, and
 working with common core and third-party Elm tools.  Its features are:
 
 @itemize
@@ -19725,7 +19726,7 @@ (define-public emacs-elm-mode
 @item Integration with elm-format
 @item Integration with elm-test
 @end itemize")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-helm-mode-manager
   (package

base-commit: d37c7f7ad4134cc15d1558eb6c0bc4c59a0db1af
-- 
2.36.1
E
E
Erik Šabič wrote on 27 May 15:21 +0200
Question
(address . 55675@debbugs.gnu.org)
CABeAMA=SOXj929swZbP17rthNfjcKxTimJPvr1EeHKOQcRxb4w@mail.gmail.com
I forgot to mention the removal of emacs-dash from propagated-inputs.

These are two unrelated updates in a patchset. I didn't know git send-email
would do this automatically. Is this okay? Or should I have submitted them
separately?

Thank you!
Attachment: file
M
M
Maxime Devos wrote on 27 May 15:48 +0200
Re: [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19.
(name . Erik Šabič)(address . erik.sab@gmail.com)(address . 55675@debbugs.gnu.org)
56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be
[Please keep 55675@debbugs.gnu.org in CC]

Erik Šabič schreef op vr 27-05-2022 om 15:32 [+0200]:
Toggle quote (30 lines)
> Well it fails on a test defined like this:
> (ert-deftest helpful--docstring ()
>   "Basic docstring fetching."
>   (should
>    (equal
>     (helpful--docstring #'test-foo t)
>     "Docstring here.")))
>
> And fails like so:
> ...............s...s..Test helpful--docstring-advice backtrace:


>
> Test helpful--docstring-advice condition:
>
>     (ert-test-failed
>      ((should
>        (equal
>         (helpful--docstring ... t)
>         "Docstring here too."))
>       :form
>       (equal "Docstring here too.\n\nThis function has :around
> advice: `ad-Advice-test-foo-advised'." "Docstring here too.")
>       :value nil :explanation
>       (arrays-of-different-length 84 19 "Docstring here too.\n\nThis
> function has :around advice: `ad-Advice-test-foo-advised'."
> "Docstring here too." first-mismatch-at 19)))
>
> F............................................................s......

Looks like a bug.

Toggle quote (5 lines)
> I don't know anything about emacs-ert. And I wasn't able to
> figure out if it works for the upstream author.
>
> WDYT?

I don't know if it fails for the upstream author, but I don't think
that's relevant to Guix. More relevant I think, is that this bug
appears in Guix, so it can cause problems for Guix users, so some
fixing might be necessary.

I don't know much about Emacs though, so you might need to contact
upstream about the bug.

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpDWoBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tmQAQC6TxIzZgVuyW09/i/Wr4nX0g/7
vpF3Bnc4fMYCm5qcQAD/aASdGvjDVYqqffOcbtHGCWVCRHNmEjJHIp5KqPIHPA8=
=6U1S
-----END PGP SIGNATURE-----


M
M
Maxime Devos wrote on 27 May 15:49 +0200
Re: [bug#55675] Question
668b2033748779f35a9e9d0add626d3751a83634.camel@telenet.be
Erik Šabič schreef op vr 27-05-2022 om 15:21 [+0200]:
Toggle quote (3 lines)
> These are two unrelated updates in a patchset. I didn't know git
> send-email would do this automatically.

"git send-email" just sends the commits you made, it is up to the user
to split the commits appropriately, it doesn't do any cleanups.

Toggle quote (2 lines)
> Is this okay? Or should I have submitted them

Depends, is it actually an unrelated change? Why is emacs-dash
removed?

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpDW+hccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7v4OAP9ejBEN1kwo5OdayGCZRGgFAUdW
q9GZqz3SOEucyM8v8wEAyLvuF9gBBkJPb8aqMWwB+ycle1Hd09fmLPszH0wqPgU=
=1WCv
-----END PGP SIGNATURE-----


E
E
Erik Šabič wrote on 27 May 16:27 +0200
emacs-dash
(address . 55675@debbugs.gnu.org)
CABeAMAmwbOxfW+R2x_Ak63OYGuj8YRh+-bierSnXGGU7RUGCkg@mail.gmail.com
Elm-mode dropped the usage of dash.el in favor of seq.el

Merged upstream with commit:
70734a1eed6f008135c197e115ca5f197e47ee0b

Author: Steve Purcell <steve@sanityinc.com>
AuthorDate: Mon Feb 21 05:57:33 2022 +1300
Attachment: file
L
L
Ludovic Courtès wrote on 5 Jun 23:34 +0200
Re: bug#55675: [PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768.
(name . Erik Šabič)(address . erik.sab@gmail.com)(address . 55675-done@debbugs.gnu.org)
87y1yadcb6.fsf@gnu.org
Hi Erik,

Erik Šabič <erik.sab@gmail.com> skribis:

Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-elm-mode): Update to 0.21.0-1.1e27768.

It has been updated to 0.22 in the meantime.

Thank you,
Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 55675@debbugs.gnu.org