[PATCH 0/2] gnu: rsync: Update to 3.2.4.

  • Done
  • quality assurance status badge
Details
3 participants
  • Greg Hogan
  • Ludovic Courtès
  • Maxime Devos
Owner
unassigned
Submitted by
Greg Hogan
Severity
normal
G
G
Greg Hogan wrote on 24 May 2022 21:52
(address . guix-patches@gnu.org)
CA+3U0Z=EbfdttBZN_TjNt4k1xiXJfqXmjN8tZdq+zycCqHdwqA@mail.gmail.com
$ ./pre-inst-env guix refresh -l rsync
Building the following 39 packages would ensure 124 dependent packages
are rebuilt ...

This patchset also fixes the casync build.

The only dependency failing to build is ocaml-craml, for which the
only release was in 2018 and has had no commits since other than the
addition of a deprecation notice with a given alternative of mdx,
which is available in guix as ocaml-mdx. No other packages depend on
ocaml-craml. Should this package be removed?

Greg
Attachment: 0002-gnu-casync-Update-to-99559cd1.patch
From 4daa4ae67a885c9e05f91a53c8efc03c1fe04bcf Mon Sep 17 00:00:00 2001
From: Greg Hogan <code@greghogan.com>
Date: Tue, 3 May 2022 17:55:02 +0000
Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.

* gnu/packages/rsync.scm (rsync): Update to 3.2.4.
---
gnu/packages/rsync.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/rsync.scm b/gnu/packages/rsync.scm
index 13717f0249..2b3673c90c 100644
--- a/gnu/packages/rsync.scm
+++ b/gnu/packages/rsync.scm
@@ -39,14 +39,14 @@ (define-module (gnu packages rsync)
(define-public rsync
(package
(name "rsync")
- (version "3.2.3")
+ (version "3.2.4")
(source (origin
(method url-fetch)
(uri (string-append "https://rsync.samba.org/ftp/rsync/src/rsync-"
version ".tar.gz"))
(sha256
(base32
- "03p5dha9g9krq61mdbcrjkpz5nglri0009ks2vs9k97f9i83rk5y"))))
+ "1lgslprbfirl9p9ca16syh0pzr4kgmrzdxwwayvb0ll0s0w1hxkg"))))
(build-system gnu-build-system)
(arguments
`(#:configure-flags
--
2.36.1
M
M
Maxime Devos wrote on 25 May 2022 16:42
4f89b4161779047128bd6298b4e1a01aec565b4e.camel@telenet.be
Greg Hogan schreef op di 24-05-2022 om 15:52 [-0400]:
Toggle quote (9 lines)
> +         (modify-phases %standard-phases
> +           (add-before 'configure 'patch-build-flags
> +             ;; Fix for change to warnings in GCC 10+ causing
> +             ;; "error: argument 1 null where non-null expected [-
> Werror=nonnull]"
> +             (lambda _
> +               (substitute* "meson.build" (("-Werror=format=2")
> "")))))))

This warning can easily indicate a real bug, has it been reported
upstream?

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYo5AORccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rCMAP9zvZ/e74Gs42wbaHmtYbJjXGpL
vOlKhJn0jX+gRMdx5QD9FcnEO1JwcWz8TCZzdcAX2pvRkAYTrVC0SetDzK9wKgk=
=d0LX
-----END PGP SIGNATURE-----


G
G
Greg Hogan wrote on 25 May 2022 20:30
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 55617@debbugs.gnu.org)
CA+3U0Z=YSBJ2sDOBTdaRN9OkTYCSME=L4DFcEGpuULk0D4a6qg@mail.gmail.com
On Wed, May 25, 2022 at 10:42 AM Maxime Devos <maximedevos@telenet.be> wrote:
Toggle quote (14 lines)
>
> Greg Hogan schreef op di 24-05-2022 om 15:52 [-0400]:
> > + (modify-phases %standard-phases
> > + (add-before 'configure 'patch-build-flags
> > + ;; Fix for change to warnings in GCC 10+ causing
> > + ;; "error: argument 1 null where non-null expected [-
> > Werror=nonnull]"
> > + (lambda _
> > + (substitute* "meson.build" (("-Werror=format=2")
> > "")))))))
>
> This warning can easily indicate a real bug, has it been reported
> upstream?

It was reported upstream in 2017 but after the latest release. I have
removed that substitute from the attached, updated patchset since I
had overlooked that this change is not needed when building against
the latest commit.

Toggle quote (2 lines)
> Greetings,
> Maxime.
From ecaee327cfb0edcb663bb00d32a04a0da2d78ceb Mon Sep 17 00:00:00 2001
From: Greg Hogan <code@greghogan.com>
Date: Tue, 3 May 2022 17:55:02 +0000
Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.

* gnu/packages/rsync.scm (rsync): Update to 3.2.4.
---
gnu/packages/rsync.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/rsync.scm b/gnu/packages/rsync.scm
index 13717f0249..2b3673c90c 100644
--- a/gnu/packages/rsync.scm
+++ b/gnu/packages/rsync.scm
@@ -39,14 +39,14 @@ (define-module (gnu packages rsync)
(define-public rsync
(package
(name "rsync")
- (version "3.2.3")
+ (version "3.2.4")
(source (origin
(method url-fetch)
(uri (string-append "https://rsync.samba.org/ftp/rsync/src/rsync-"
version ".tar.gz"))
(sha256
(base32
- "03p5dha9g9krq61mdbcrjkpz5nglri0009ks2vs9k97f9i83rk5y"))))
+ "1lgslprbfirl9p9ca16syh0pzr4kgmrzdxwwayvb0ll0s0w1hxkg"))))
(build-system gnu-build-system)
(arguments
`(#:configure-flags
--
2.36.1
Attachment: 0002-gnu-casync-Update-to-99559cd1.patch
L
L
Ludovic Courtès wrote on 30 May 2022 16:15
Re: bug#55617: [PATCH 0/2] gnu: rsync: Update to 3.2.4.
(name . Greg Hogan)(address . code@greghogan.com)
8735gr5cpk.fsf_-_@gnu.org
Hi,

Greg Hogan <code@greghogan.com> skribis:

Toggle quote (7 lines)
> From ecaee327cfb0edcb663bb00d32a04a0da2d78ceb Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 3 May 2022 17:55:02 +0000
> Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.
>
> * gnu/packages/rsync.scm (rsync): Update to 3.2.4.

[...]

Toggle quote (13 lines)
> From 208b49b03614d6412447e01b06ca8026de6dd668 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 3 May 2022 17:54:16 +0000
> Subject: [PATCH 2/2] gnu: casync: Update to 99559cd1.
>
> * gnu/packages/sync.scm (casync): Update to 99559cd1.
> [source]: Remove patch.
> [arguments]: Fix installation.
> [native-inputs]: Add python.
> [inputs]: Add eudev.
> * gnu/packages/patches/casync-renameat2-declaration.patch: Delete file.
> * gnu/local.mk: Remove it.

Applied, thanks!

Ludo’.
L
L
Ludovic Courtès wrote on 30 May 2022 16:15
(name . Greg Hogan)(address . code@greghogan.com)
871qwb5cot.fsf_-_@gnu.org
Hi,

Greg Hogan <code@greghogan.com> skribis:

Toggle quote (7 lines)
> From ecaee327cfb0edcb663bb00d32a04a0da2d78ceb Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 3 May 2022 17:55:02 +0000
> Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.
>
> * gnu/packages/rsync.scm (rsync): Update to 3.2.4.

[...]

Toggle quote (13 lines)
> From 208b49b03614d6412447e01b06ca8026de6dd668 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 3 May 2022 17:54:16 +0000
> Subject: [PATCH 2/2] gnu: casync: Update to 99559cd1.
>
> * gnu/packages/sync.scm (casync): Update to 99559cd1.
> [source]: Remove patch.
> [arguments]: Fix installation.
> [native-inputs]: Add python.
> [inputs]: Add eudev.
> * gnu/packages/patches/casync-renameat2-declaration.patch: Delete file.
> * gnu/local.mk: Remove it.

Applied, thanks!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 55617@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 55617
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch