Ludovic Courtès <ludo@gnu.org> skribis:
commit 0b9fbbb4dd24f227c9a708561ba291f6169ad2e6
Date: Sat Jan 15 14:50:00 2022 +0100
installer: Capture external commands output.
* gnu/installer/utils.scm (run-external-command-with-handler,
run-external-command-with-line-hooks): New variables.
(run-command): Use run-external-command-with-line-hooks.
(unsurprisingly) to log standard output of commands.
I’m not sure it’s a good idea for ‘guix system init’: we’d be logging
mostly progress bars, package names, and the likes to syslog—not super
useful. So I’d suggest not capturing stdout of ‘guix system init’.
However, I wouldn’t mind factorizing the syslog facilities from
2cf65e1d543407bc7db43e7c7d39a215907efebc into, say, (guix syslog), and
have (guix scripts system) use it to log important events.
What about using ‘run-external-command-with-line-hooks’ for other
commands though? IIUC, the primary use case is file system tools.
My gut feeling is that the cost/benefit ratio isn’t worth it (the cost
here is complexity and maintenance burden of
‘run-external-command-with-handler’ & co.; the benefit is improved
I can hopefully dedicate a bit of time to this, but I need your