libgit2 1.3.0 includes a time-dependent test

  • Done
  • quality assurance status badge
Details
3 participants
  • Carl Dong
  • Ludovic Courtès
  • Maxime Devos
Owner
unassigned
Submitted by
Ludovic Courtès
Severity
important
L
L
Ludovic Courtès wrote on 8 May 2022 23:06
(address . bug-guix@gnu.org)
87zgjrwx7z.fsf@inria.fr
libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
“HEAD@{10 years ago}” doesn't match anything in the sample repositories,
which is no longer true:

Toggle snippet (21 lines)
$ date
Sun May 8 11:04:31 PM CEST 2022
$ ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')

refs::revparseF

1) Failure:
refs::revparse::date [/tmp/guix-build-libgit2-1.3.0.drv-0/source/tests/refs/revparse.c:31]
Function call succeeded: error
no error, expected non-zero return

$ /gnu/store/wy3ww7znqhlg84vg6cmw1m12z1drxwh1-libfaketime-0.9.9/bin/faketime 2021-12-12 ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites:
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')

refs::revparse.


Thus, as of 6b588da368c77cde82ea2f22ca315116228777ad, libgit2 now fails
to build; a few months ago, it would build fine.

Ludo’.
L
L
Ludovic Courtès wrote on 8 May 2022 23:13
control message for bug #55326
(address . control@debbugs.gnu.org)
87y1zbwwvm.fsf@gnu.org
severity 55326 important
quit
L
L
Ludovic Courtès wrote on 9 May 2022 00:11
Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
(address . 55326-done@debbugs.gnu.org)
8735hjvfnb.fsf@gnu.org
Ludovic Courtès <ludo@gnu.org> skribis:

Toggle quote (5 lines)
> libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
> ‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
> “HEAD@{10 years ago}” doesn't match anything in the sample repositories,
> which is no longer true:

Fixed:

e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)

Ludo’.
Closed
M
M
Maxime Devos wrote on 9 May 2022 09:25
b7088e36f25e87e9d9430c661fcb71c957e26bcf.camel@telenet.be
Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
Toggle quote (5 lines)
> Fixed:
>
>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)

It's still time-dependent though:

Toggle quote (4 lines)
> + (substitute* "tests/refs/revparse.c"
> + (("10 years ago")
> + "100 years ago"))))))

wouldn't it now fail after ~100 or ~1000 years?
Though maybe by that time, we have complete time namespaces ...

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnjCBxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nTeAP9fIr0YkKBVOnBkCu91U1lrrtPy
AcM5SSnEYOUjmnCkJAEAiof9paj1vs10c4XZZ+QCi8Z1eqKCM1sMDZHSowvqRw0=
=GoDX
-----END PGP SIGNATURE-----


Closed
L
L
Ludovic Courtès wrote on 9 May 2022 10:49
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 55326-done@debbugs.gnu.org)
87h75zrsz5.fsf@gnu.org
Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (15 lines)
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>>
>>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
>
> It's still time-dependent though:
>
>> + (substitute* "tests/refs/revparse.c"
>> + (("10 years ago")
>> + "100 years ago"))))))
>
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...

Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.

Ludo’.
Closed
M
M
Maxime Devos wrote on 9 May 2022 12:10
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 55326-done@debbugs.gnu.org)
9473c3931828eba0dc9401d2e9d31baaf6ae7b88.camel@telenet.be
Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
Toggle quote (2 lines)
> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.

I assume you meant 100GHz here instead? Or very fast software that
doesn't need fast CPUs ...
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnjoehccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uBaAP9MUL6Su+IWSxqJ2qP2KBegzjPH
Wef0dBLDO8HQX/ZNWQEAvDCcDTIzSLNNDtQSE/f4kUpP8tRo04RpExAzQ3jxRww=
=W+1u
-----END PGP SIGNATURE-----


Closed
C
C
Carl Dong wrote on 9 May 2022 21:33
(name . Maxime Devos)(address . maximedevos@telenet.be)
43A362D3-1DDE-405C-B852-E506B7A0233A@carldong.me
I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.

See here for the PR: https://github.com/libgit2/libgit2/pull/6299 https://github.com/libgit2/libgit2/pull/6299

Toggle quote (1 lines)
> Though maybe by that time, we have complete time namespaces …
One would hope!

Cheers,
Carl Dong

Toggle quote (19 lines)
> On May 9, 2022, at 3:25 AM, Maxime Devos <maximedevos@telenet.be> wrote:
>
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>>
>> e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>> f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
>
> It's still time-dependent though:
>
>> + (substitute* "tests/refs/revparse.c"
>> + (("10 years ago")
>> + "100 years ago"))))))
>
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
>
> Greetings,
> Maxime.
Attachment: file
Attachment: signature.asc
Closed
L
L
Ludovic Courtès wrote on 10 May 2022 17:48
(name . Carl Dong)(address . contact@carldong.me)
87mtfppevv.fsf@gnu.org
Heya,

Carl Dong <contact@carldong.me> skribis:

Toggle quote (4 lines)
> I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.
>
> See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>

Well done, thanks!

Ludo’.
Closed
L
L
Ludovic Courtès wrote on 10 May 2022 17:50
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 55326-done@debbugs.gnu.org)
87ilqdpesq.fsf@gnu.org
Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (6 lines)
> Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
>> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.
>
> I assume you meant 100GHz here instead? Or very fast software that
> doesn't need fast CPUs ...

I did mean MHz but I don’t want to spoil more hopeful visions. :-)

Ludo’.
Closed
M
M
Maxime Devos wrote on 3 Jun 2022 19:58
2f49dabd61e0f1a6cadb3bebc96823cea03cd074.camel@telenet.be
I noticed that the latest core-updates evaluations fail because of the
test failure in libgit2@1.3.0:


so I recommend merging 'master' into 'core-updates'.

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYppLthccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sqzAQCFnmMjn/3/uM7zm9sYDA0OEjfY
OBjrcQZaPAKiavRqUwD9F6FJDjUjFRa7ladJFoLGu7yMco0jBKFS8t/kNMnomA8=
=TRk/
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 8 Jun 2022 18:16
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 55326@debbugs.gnu.org)
87ilpb6shd.fsf@gnu.org
Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (7 lines)
> I noticed that the latest core-updates evaluations fail because of the
> test failure in libgit2@1.3.0:
>
> https://ci.guix.gnu.org/jobset/core-updates
>
> so I recommend merging 'master' into 'core-updates'.

Done in 8c3e9da13a3c92a7db308db8c0d81cb474ad7799 (and I hope I didn’t
mess up while resolving conflicts!)

Ludo’.
?
Your comment

This issue is archived.

To comment on this conversation send an email to 55326@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 55326
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch