(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
1159731646908990@mail.yandex.ru
[PATCH] Add emacs-org-remark-1.0.3
- Open
Details
- 2 participants
- ??????? ???????
- Nicolas Goaziou
- Owner
- unassigned
- Submitted by
- ??????? ???????
- Severity
- normal
?
N
(name . ??????? ???????)(address . drozdov@portalenergy.tech)(address . 54328@debbugs.gnu.org)
87tuc567jl.fsf@nicolasgoaziou.fr
Hello,
??????? ??????? <drozdov@portalenergy.tech> writes:
Toggle quote (2 lines)
> Subject: [PATCH] Add emacs-org-remark-1.0.3
Thanks. Some comments follow.
First, our commit messages are somewhat normalized, so this should be:
gnu: Add emacs-org-remark.
* gnu/packages/emacs-xyz.scm (emacs-org-remark): New variable.
Note the message doesn't contain the version, but specify the exact name
of the variable being added.
Toggle quote (4 lines)
> +(define-public emacs-org-remark
> + (let ((commit "b2e632cf66c748951910bc493915759ee8a9c22c")
> + (revision "0"))
You don't need to specify a revision since this pair matches an
un-tagged version bump.
Toggle quote (4 lines)
> + (package
> + (name "emacs-org-remark")
> + (version (git-version "1.0.3" revision commit))
Per above, this should be plain "1.0.3".
Toggle quote (2 lines)
> + (description "@code{emacs-org-remark} lets you highlight and annotate any text file with using Org mode.")
I think the name is Org-remark, not emacs-org-remark, which is the name
of the Guix variable.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
?