[PATCH] (guix-data-service) Add nl_NL.UTF-8 locale

  • Open
  • quality assurance status badge
Details
2 participants
  • Christopher Baines
  • Maxime Devos
Owner
unassigned
Submitted by
Maxime Devos
Severity
normal

Debbugs page

Maxime Devos wrote 3 years ago
(address . guix-patches@gnu.org)(address . mail@cbaines.net)
16306441681c2104f06fb924beddbd5f34fcb136.camel@telenet.be
Hi guix(-data-service),

The nl_NL.UTF-8 translation (*) are currently almost 100%.
How about adding the nl_NL.UTF-8 locale? I sent a patch
doing this to guix-devel as suggested in the README, but
it seems to have been lost (see

(*) at least for the "guix" domain, the packages aren't translated much
yet.

Perhaps the locale list needs to be modified in other
places as well (maybe


Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYh/JjhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rJiAP4lmgJkp8PzdiovI04ONR47Qrlh
JLnQWvM9MSd2kIOWYQD/ZXyjYlbL7VvBZUFYmuleyY1VKb0BfFcpR9Irk0l+XQw=
=+sjW
-----END PGP SIGNATURE-----


Christopher Baines wrote 3 years ago
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 54223@debbugs.gnu.org)
87ee3kaw40.fsf@cbaines.net
Maxime Devos <maximedevos@telenet.be> writes:

Toggle quote (13 lines)
> The nl_NL.UTF-8 translation (*) are currently almost 100%.
> How about adding the nl_NL.UTF-8 locale? I sent a patch
> doing this to guix-devel as suggested in the README, but
> it seems to have been lost (see
> https://lists.gnu.org/r/guix-devel/2021-08/msg00132.html).
>
> (*) at least for the "guix" domain, the packages aren't translated much
> yet.
>
> Perhaps the locale list needs to be modified in other
> places as well (maybe
> <https://git.savannah.gnu.org/cgit/guix/data-service.git/tree/guix-data-service/jobs/load-new-guix-revision.scm?id=3a9079856742b4d97bc434837323ff02eb9d32c3#n422>?).

Hey Maxime,

Your email last year did reach me, but obviously I overlooked it.

I've gone ahead and pushed your patch as
8ab72e633ae700fe58bb3bf72aa155d62c2bc22e, I'll deploy it to
data.guix.gnu.org within the next few days.

Note that the Guix Data Service only stores translated strings for lint
warnings, and package synopsis+descriptions, and that the storage
happens when a revision is processed, so this change will only have an
effect for revisions processed after it's made.

I tweaked the commit message slightly, and I also added nl_NL to the
second list of locales you spotted.

Ideally, the data service would get the list of locales from Guix
somehow, I'm not sure if that information is available, or quite how to
make it available, but these hardcoded locale lists are a bit of a hack.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmIf3+9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcLMA//eEn4S9nAXWoEu0PW4D2Qj1RBXCtGfAtg
LqBcupQ8jlPkG1p+HkM7qocZkciFneDsff3XcC+qO5WHiR9iaeAF175f8WuXFp5/
lIbt7o5EsicZKeOImARcdbuP6OUJrzopwKgQTjKfmIoerMtnKmcu9xHLaEHUcBQX
xMkrsa4rKBkjLvOrGv9c41g7k8QLKiljOs2B99vfxc941Ol1986m5ZM/fvUtdtb4
zAVwkWlORfFjoPvwo/AeZufG0YPL8cZdcn3494yaGkIt6jVjHghy/zmOCzrfNaSo
wNCkKhBAOqFSRuNK8lOOI56QdKCxd0o/gPsNx2aEzH/DyQsKlmDyTp4A1ci2l0jW
r5R1tuhXz8bHMxhDfQjzNntA19EyhfIuxDNXIWYah9f9LRodcITVoIc7Q375zbJA
DJMJLbQ1986LHa04Nipu5mZrfBFLUy7qaifU22fyo3GdMDe1EfVyrFLkMQ+h5RKW
OKU3YayOryty1OoIjCUrH7GXsDk5U3ws3JQ4OIOpAcqDTNo69P+iWkPbbn7b8dKB
zbQq0O425snRM7rrylbd1Owsvtnu7tIm6OizGZNtnFPoKwF9MKMMmHSHHGy1XaNB
MC4ggsNUezkQQqIa7/Vp59QOMTv575TYDSIvt6IgYPqIDtema9FyNCP9gsDL3sVj
icVRWCjsZOA=
=YkGS
-----END PGP SIGNATURE-----

Maxime Devos wrote 3 years ago
(name . Christopher Baines)(address . mail@cbaines.net)(address . 54223@debbugs.gnu.org)
778aa057b765f1e8aa1b23887e57f6c520f8c886.camel@telenet.be
Christopher Baines schreef op wo 02-03-2022 om 21:19 [+0000]:
Toggle quote (8 lines)
> Hey Maxime,
>
> Your email last year did reach me, but obviously I overlooked it.
>
> I've gone ahead and pushed your patch as
> 8ab72e633ae700fe58bb3bf72aa155d62c2bc22e, I'll deploy it to
> data.guix.gnu.org within the next few days. [...]

Thanks!

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYh/i0BccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jwaAP4w1m+JK6Edtr2Vu6GnhMDTvlzS
1Pk+dZxPmXRHFYMIyQEApl2o7xBoJmC05in+VguUij1okX0MaBJooQok/lwoKgg=
=ymFF
-----END PGP SIGNATURE-----


Maxime Devos wrote 3 years ago
(name . Christopher Baines)(address . mail@cbaines.net)(address . 54223@debbugs.gnu.org)
582a3d8b2e0679f9ba63155c77ffed48377a5048.camel@telenet.be
Christopher Baines schreef op wo 02-03-2022 om 21:19 [+0000]:
Toggle quote (5 lines)
> Ideally, the data service would get the list of locales from Guix
> somehow, I'm not sure if that information is available, or quite how
> to make it available, but these hardcoded locale lists are a bit of a
> hack.

Suggestion:

scheme@(guix-user)> (bindtextdomain "guix")
$1 = "/gnu/store/2bbmkgk8x4zqr4gjvb92zgji5d7m70gx-guix-1.3.0-23.a27e47f"

user@host:~$ ls /gnu/store/mp8yfgzxs3ww5kj8rpnkn133pmm16jd6-guix-locale-guix
Toggle quote (2 lines)
> cs da de eo es fa fi fr hu it ko nl oc pl pt_BR ru si sk sr sv ta uk vi zh_CN

scheme@(guix-user)> (bindtextdomain "guix-packages")
$2 = "/gnu/store/wbljwj8yfpxqgxs79vhxb41s5ypj96xd-guix-locale-guix-packages"
[...]

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYlH0mxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7neJAP0elkRBd3V24t6tkEPv0pfeFnBI
ARRUdsFFKv7OWHfv7gEAt28TX8bW14JvcPwE3zNwChr/qHaUPTv+1eg+qJd3hgA=
=aJaf
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 54223@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 54223
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help