[PATCH] build-system/go: Use different default go on powerpc-linux.

  • Open
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Efraim Flashner
Severity
normal
E
E
Efraim Flashner wrote on 22 Feb 2022 12:08
(address . guix-patches@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
f61be8e525617e20e7bacf1f5f415ba8a4fd487d.1645528089.git.efraim@flashner.co.il
* guix/build-system/go.scm (default-go): Return a different package
based on the target architecture.
---
guix/build-system/go.scm | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Toggle diff (33 lines)
diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm
index 5e0e5bbad3..8330d3aa8e 100644
--- a/guix/build-system/go.scm
+++ b/guix/build-system/go.scm
@@ -3,7 +3,7 @@
;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
;;; Copyright © 2020 Jakub K?dzio?ka <kuba@kadziolka.net>
;;; Copyright © 2021-2022 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2021, 2022 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev>
;;;
;;; This file is part of GNU Guix.
@@ -110,8 +110,11 @@ (define %go-build-system-modules
(define (default-go)
;; Lazily resolve the binding to avoid a circular dependency.
- (let ((go (resolve-interface '(gnu packages golang))))
- (module-ref go 'go)))
+ (let ((gcc (resolve-interface '(gnu packages gcc)))
+ (golang (resolve-interface '(gnu packages golang))))
+ (if (target-ppc32?)
+ (module-ref gcc 'gccgo-11)
+ (module-ref golang 'go))))
(define (make-go-std)
(module-ref (resolve-interface '(gnu packages golang)) 'make-go-std))

base-commit: 7d72da6b07e99854751187d2694b067733fedda5
prerequisite-patch-id: 861786541b1231efceea28ba4d80d00c000a1b5e
prerequisite-patch-id: 7926cb990933a395cef6672939d171f8cd384170
--
2.34.0
S
S
Sharlatan Hellseher wrote on 12 Sep 16:43 +0200
(address . 54105@debbugs.gnu.org)(name . Flashner)(address . efraim@flashner.co.il)
8734m5lypi.fsf@gmail.com
Hi Efraim,

Is this patch still actually to be applied?

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmbi/gkACgkQdtcnv/Ys
0rVUPQ//W4n+gyKZZtwI6K/LoxAnVMW8mYJYzKWRPnd4851wl7tmFS5T1AuAXZY5
+/dva6RWgrozSxWEEbcfVMK2Hup8T1NQqyQGOspsui7gB0J4MTWqFsbGlcshfqqi
JOmyp90CCZvsjdG3B37RGWB1ggRGl2opoFXkWIWt1lA3gNLfrFBDoH9MgLUn3BIX
qCEk+q+gDKAUnmPQY3OBHab3dF6lhfNnhVWSgBu+XhQzkx3hNLXyIObVy+yASXsd
6SrVCJ3ORA0kFdmwNdmV++4w7uxwILeCQIBTAUGTuZUJ50VXDIU51SBjkZ9/2qKf
sYHJfoRZJMT29qa6jWD41WYYn+TM0Ne3pPfP3a5oY4nJzqWWGlMTZcrhlF+57jVy
qVpSb4LpPDEyuX8sVsquDUMgr354Q7kjqlBAr3c5UFJMJY741yJVmfUIr/Yddmuv
3/8I+p7A3lpevCrDxHSzmo27DCXr643loRcAyPw1cFGAd+9zFCtSJxF+V+kpZqRb
Nzcbdx8mE4mpLFOyzPKXCOFbk/9apu+lP/9Um6tUXuRsCNJVPs2PSEOigIxhNHfK
WT6Cd1rce/HzQaHBi2Isi7rOcwo2DBNedc2veXiGrWbLVqVo6lkNhWHlz0nOMV8z
Cqz1HtIiZfyZCUyXdCyfon5y8B7vtA7/jRCCelc4vMKWP6pBZ5k=
=b1rf
-----END PGP SIGNATURE-----

E
E
Efraim Flashner wrote on 12 Sep 17:36 +0200
(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)(address . 54105@debbugs.gnu.org)
ZuMKeojaKiTvbRgr@3900XT
On Thu, Sep 12, 2024 at 03:43:21PM +0100, Sharlatan Hellseher wrote:
Toggle quote (5 lines)
>
> Hi Efraim,
>
> Is this patch still actually to be applied?

Let me get back to you about that. I thought I had a newer version of
that patch somewhere. I'll have to double-check that x86_64 -> ppc32
and ppc32->x86_64 both use gccgo. I think I had to do something also
with go-std also, which isn't needed with gccgo.

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmbjCnoACgkQQarn3Mo9
g1E0Ww//XnXJI0KUolDD2NWB2lWpCvXDDQKenmL9lHVUTLKA+mOwGWLEdb67fg4f
rbmeDBi2Itj7TpX4ZjGINfOcOkR8/hvgYmuCaRvr3pVBJkHuY8krW5nbeMwpbK+H
Iv3KXdKj5d1gZ/mynevUe+/4rz0pFA/HEGPnCSFaC+iT86dMMmqz68aiDza5JJiz
SdzoqlQb3cYkCvHYRXoVGLs17gYfBAUNoex8/squ8hnpuDY+in4jgLu/uLRKZXpf
T1bC3QeUj3x0fpT6KFnuwdmV+c6afhTgQE23uvEk4EvUdoEo9kQTWnT+RxOtllNn
Jhu1wDz0C7D/OR3ySM6SLEUss6gb9LwpLkHfUosM1Kd2BjY2rF+jpI9PsUlB/gui
TgC+zUwNuNI5V05eXWT5ppUXoR1CYZ7OwOUmkCyUwHz7Qg2a1UF8UgzqFo7EP7E1
wbGVBpW2liL4r9tURExWfoya4HvzfHnrMWXezaIbPFM+kbNxgyM9uC3F8DMhIsVr
dpICfN0G6llTA+sER1QmQzzAo5yukRBo/vrGqOM1iYMu6I5jb9civQBAdOtG2Ftf
D/lVaVHG+jy2B/k+UDsKYihfoFK213y0iNOtbHlbdkZiNSo9egvwpHBRTWPPg3Sd
WTTzLtoLpHerIw7sEDa1Ut27Oy+QiP+lfjQU9o8PMNiWgftyCzs=
=bybf
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 54105@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 54105
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch