Tanguy Le Carrour <tanguy@bioneland.org> writes:
Could you update this changelog, please? :-). E.g., mention whether the
removed substitutions are reinstating tests or simply no longer exist.
Toggle quote (114 lines)
> gnu/packages/gnunet.scm | 75 +++++++++++++++--------------------------
> 1 file changed, 27 insertions(+), 48 deletions(-)
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 1c09c9047b..2fd3301897 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -254,7 +254,7 @@ (define-public gnurl
> @@ -262,30 +262,30 @@ (define-public gnunet
> - "15jnca5zxng7r6m3qzq9lr73xxq0v6mvcp0lny3zrlkz5s2nmmq3"))))
> + "0s006sdcczx7w1h9h1pnwwnnvxz9g47yl6apa9q8dkgi7zqscbfk"))))
> (build-system gnu-build-system)
> - ("gnutls" ,gnutls/dane)
> - ("gstreamer" ,gstreamer)
> - ("libextractor" ,libextractor)
> - ("libgcrypt" ,libgcrypt)
> - ("libjpeg" ,libjpeg-turbo)
> - ("libmicrohttpd" ,libmicrohttpd)
> - ("libsodium" ,libsodium)
> - ("libunistring" ,libunistring)
> - ("miniupnpc" ,miniupnpc)
> - ("pulseaudio" ,pulseaudio)
> (list curl pkg-config python xxd
> (@ (gnu packages base) which)))
> @@ -297,30 +297,9 @@ (define-public gnunet
> ;; These tests fail in Guix's building environment.
> (substitute* "src/transport/Makefile"
> - (("\\$\\(am__EXEEXT_15\\)") "") ; test_transport_api_https
> - (("test_transport_api_manipulation_cfg\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_transport_api_udp_nat\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_transport_blacklisting_multiple_plugins\\$\\(EXEEXT\\) \\\\\n") ""))
> - (substitute* "src/testbed/Makefile"
> - (("test_testbed_api_2peers_1controller\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_testbed_api_statistics\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_testbed_api_test\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_testbed_api_test_timeout\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_testbed_api_topology\\$\\(EXEEXT\\) \\\\\n") "")
> - (("test_testbed_api_topology_clique\\$\\(EXEEXT\\) \\\\\n") ""))
> - (substitute* "src/topology/Makefile"
> - (("^check_PROGRAMS.*") "\n")
> - (("test_gnunet_daemon_topology\\$\\(EXEEXT\\)\n") ""))
> - (substitute* "src/namestore/Makefile"
> - (("\\$\\(am__append_2\\)") ""))
> - (substitute* "src/gns/Makefile"
> - (("\\$\\(am__append_4\\)") ""))
> - (substitute* "contrib/Makefile"
> - (("^check_PROGRAMS.*") "\n"))
> - ;; 'test' from coreutils doesn't behave as the test expects.
> - (substitute* '("src/gns/gnunet-gns-proxy-setup-ca.in"
> - "src/transport/gnunet-transport-certificate-creation.in")
> - (("gnutls-certtool") "certtool"))
> + (("\\$\\(am__EXEEXT_15\\)") "")) ; test_transport_api_https
> + (substitute* "src/dht/test_dht_tools.py"
> + (("/usr/bin/python") (which "python3")))
> (add-before 'check 'set-env-var-for-tests
> @@ -344,7 +323,7 @@ (define-public gnunet
> an application for secure publication of files, it has grown to include all
> kinds of basic applications for the foundation of a GNU internet.")
> (license license:agpl3+)
> - (home-page "https://gnunet.org/")))
> + (home-page "https://gnunet.org/en/")))
> (define-public guile-gnunet ;GSoC 2015!
> (let ((commit "d12167ab3c8d7d6caffd9c606e389ef043760602")
That's a very welcome cleanup of the disabled tests! Thank you!
With the updated changelog, it'll be good to push.