[PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.

  • Done
  • quality assurance status badge
Details
2 participants
  • Guillaume Le Vaillant
  • Leo Famulari
Owner
unassigned
Submitted by
Leo Famulari
Severity
normal
L
L
Leo Famulari wrote on 24 Jan 2022 09:06
(address . guix-patches@gnu.org)
992f75d634f695896c1a0695fe53a902cb2a2e2f.1643011560.git.leo@famulari.name
See https://issues.guix.gnu.org/53289 for more information about this change.

* gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
---
gnu/packages/engineering.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f4c5d73e00..23133a50eb 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2483,8 +2483,10 @@ (define-public freecad
python-shiboken-2
python-wrapper
qtbase-5
+ qtdeclarative
qtsvg
- qtwebkit
+ qtwebchannel
+ qtwebengine
qtx11extras
qtxmlpatterns
sqlite
--
2.34.0
L
L
Leo Famulari wrote on 24 Jan 2022 09:13
(no subject)
(address . control@debbugs.gnu.org)
Ye5fvjDgMgCqYWc2@jasmine.lan
block 53289 with 53495
G
G
Guillaume Le Vaillant wrote on 25 Jan 2022 11:40
Re: [bug#53495] [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.
(name . Leo Famulari)(address . leo@famulari.name)(address . 53495@debbugs.gnu.org)
87lez4drmu.fsf@kitej
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (25 lines)
> See https://issues.guix.gnu.org/53289 for more information about this change.
>
> * gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
> QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
> ---
> gnu/packages/engineering.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index f4c5d73e00..23133a50eb 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2483,8 +2483,10 @@ (define-public freecad
> python-shiboken-2
> python-wrapper
> qtbase-5
> + qtdeclarative
> qtsvg
> - qtwebkit
> + qtwebchannel
> + qtwebengine
> qtx11extras
> qtxmlpatterns
> sqlite

LGTM
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYe/T2Q8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/XCQD9HZA+vD+B+O1j7zZzzzLQRD9QVfNfmWE0+XDS
0PNEnj8A/0y9W4YKV+6jGsr2YA5CFgP1czpIGqcXbcZ61ItWF72m
=zxCF
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 25 Jan 2022 19:39
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 53495-done@debbugs.gnu.org)
YfBD0IU+VXpvdzhg@jasmine.lan
On Tue, Jan 25, 2022 at 10:40:34AM +0000, Guillaume Le Vaillant wrote:
Toggle quote (2 lines)
> LGTM

Thanks for the review! Pushed as
676de0a34c7fab3c12e36e0d8349db6ee8da65da
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmHwQ88ACgkQJkb6MLrK
fwhDpw/+JMUjiijE9i55QdhT8H7QIum/ABIAn9ndFfD0gEw97SfNIYBVhSvMWsCC
R+qUTPTKiw+iuEKc5HNCy2WSxjcxLbGn4dWfV8r/Q4c5aGkDihLETZRK3zfz35YW
NSrtQk7DGrguFslSXxE0uSd4+ltuBH91b5qqKec4sLAju+ydlQGvaVxMB5SeJ80A
19+RELIUhfSaZDUQjFA+zLfPhUou6z4+N5QILrhCXmAOnr6AmswJqnJGFztoz1NI
gQhTR/5VjxcRByxvzoXOIwQnEW0QNNAXPrzr614o/XETNUNVmlJ2zaqm4nofF5s9
khjXlxxt6f3XSP3XhyYG9MXEd2Xn0/J5KWDVlMF5UZnS1mLgsZ2Bd65lBotUUTcs
VX00p+GxflPhXfKVMOY34vKy6yE1nQsUNAwvTvxpJfXVEA3A/jX2lSB6/o98ojHV
sJoM4XZOdG6fX6n/Wxmj5RJgRxLIbSoSAbUMU89JQ3bidC/BK+WiwxVeM6D4qHmN
Fd0Vyh4Ydp9c+T0I0iPlPrIMieJUsTJc60dMIsXNGfr0cU3apdZ8+yRO8xkhDEPp
+88sgWElyhxy8hJT8I/eo8RF7bS0IrbcE7YX0AI1NGi+CXTE+9PHZmKgtk0Iowgp
gc9bbMg1MP5uUWymA8iNP+ZRJqLhNG+y5G8/bXkHMip01XqmvWY=
=TwYQ
-----END PGP SIGNATURE-----


Closed
?