[PATCH] doc: Add a rule of thumb to guide enabling new committers.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Maxim Cournoyer
Severity
normal
M
M
Maxim Cournoyer wrote on 23 Jan 2022 04:25
(address . guix-patches@gnu.org)(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
20220123032547.9635-1-maxim.cournoyer@gmail.com
* doc/contributing.texi (Commit Access): Introduce a new rule of thumb to
determine if a contributor should be considered to become a committer.
---
doc/contributing.texi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

Toggle diff (24 lines)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 9f97788c0b..321d496739 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1386,9 +1386,14 @@ what your usertag means.
@cindex commit access, for developers
Everyone can contribute to Guix without having commit access
(@pxref{Submitting Patches}). However, for frequent contributors,
-having write access to the repository can be convenient. Commit access
-should not be thought of as a ``badge of honor'' but rather as a
-responsibility a contributor is willing to take to help the project.
+having write access to the repository can be convenient. As a rule of
+thumb, a contributor should have accumulated fifty (50) reviewed commits
+to be considered as a committer and have sustained their activity in the
+project for at least 6 months. This ensures enough interactions with
+the contributor, which is essential for mentoring and assessing whether
+they are ready to become a committer. Commit access should not be
+thought of as a ``badge of honor'' but rather as a responsibility a
+contributor is willing to take to help the project.
The following sections explain how to get commit access, how to be ready
to push commits, and the policies and community expectations for commits
--
2.34.0
L
L
Ludovic Courtès wrote on 31 Jan 2022 23:46
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 53464@debbugs.gnu.org)
87zgnb8qwy.fsf@gnu.org
Hello!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

Toggle quote (22 lines)
> * doc/contributing.texi (Commit Access): Introduce a new rule of thumb to
> determine if a contributor should be considered to become a committer.
> ---
> doc/contributing.texi | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index 9f97788c0b..321d496739 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -1386,9 +1386,14 @@ what your usertag means.
> @cindex commit access, for developers
> Everyone can contribute to Guix without having commit access
> (@pxref{Submitting Patches}). However, for frequent contributors,
> -having write access to the repository can be convenient. Commit access
> -should not be thought of as a ``badge of honor'' but rather as a
> -responsibility a contributor is willing to take to help the project.
> +having write access to the repository can be convenient. As a rule of
> +thumb, a contributor should have accumulated fifty (50) reviewed commits
> +to be considered as a committer and have sustained their activity in the
> +project for at least 6 months. This ensures enough interactions with

That sounds reasonable to me.

Thanks!

Ludo’.
M
M
Maxim Cournoyer wrote on 1 Feb 2022 05:44
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 53464-done@debbugs.gnu.org)
878ruvfb6g.fsf@gmail.com
Hi!

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (28 lines)
> Hello!
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> * doc/contributing.texi (Commit Access): Introduce a new rule of thumb to
>> determine if a contributor should be considered to become a committer.
>> ---
>> doc/contributing.texi | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/contributing.texi b/doc/contributing.texi
>> index 9f97788c0b..321d496739 100644
>> --- a/doc/contributing.texi
>> +++ b/doc/contributing.texi
>> @@ -1386,9 +1386,14 @@ what your usertag means.
>> @cindex commit access, for developers
>> Everyone can contribute to Guix without having commit access
>> (@pxref{Submitting Patches}). However, for frequent contributors,
>> -having write access to the repository can be convenient. Commit access
>> -should not be thought of as a ``badge of honor'' but rather as a
>> -responsibility a contributor is willing to take to help the project.
>> +having write access to the repository can be convenient. As a rule of
>> +thumb, a contributor should have accumulated fifty (50) reviewed commits
>> +to be considered as a committer and have sustained their activity in the
>> +project for at least 6 months. This ensures enough interactions with
>
> That sounds reasonable to me.

Pushed as c1043fd60d273c61c80ecfd31fa3a4ea1b24639a.

Thank you for having a look!

Maxim
Closed
?