transfig: Fails to build (issues with libdeps)

Hi! When trying to upgrade package `transfig 3.2.5e` from Guix commit

`404f6953` to that of commit `4a943cfd`, the build fails showing many

instances of warnings like the ones below, and finally the error at the

bottom:

```

starting phase `configure'

[…]

makedepend: warning: genbox.c (reading ../fig2dev.h, line 18): cannot find include file "stdlib.h"

not in ../stdlib.h

not in ../../stdlib.h

not in /gnu/store/kz32lsiszh43yi3qxwzzsi434r72i1nk-imake-1.0.8/include/stdlib.h

not in /usr/include/stdlib.h

[…]

phase `configure' succeeded after 0.6 seconds

starting phase `patch-generated-file-shebangs'

patch-shebang: ./doc/MAKEPS: warning: no binary for interpreter `csh' found in $PATH

patch-shebang: ./fig2dev/fig2ps2tex.script: warning: no binary for interpreter `csh' found in $PATH

phase `patch-generated-file-shebangs' succeeded after 0.0 seconds

starting phase `build'

[…]

gcc -O2 -I.. -I../.. -I/gnu/store/kz32lsiszh43yi3qxwzzsi434r72i1nk-imake-1.0.8/include -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -DUSE_PNG -DUSE_XPM -I/usr/include/X11 -I/gnu/store/368cv23ggbgl91bw90hyhkqx5dzq0988-libxpm-3.5.13/include/X11 -DNFSS -DLATEX2E_GRAPHICS -DDVIPS -DI18N -DFIG2DEV_LIBDIR=/gnu/store/vxgbyg2kigli0lw59cfb7r64xyf101rq-transfig-3.2.5e/lib -DFIG2DEV_LIBDIR_STR=\"/gnu/store/vxgbyg2kigli0lw59cfb7r64xyf101rq-transfig-3.2.5e/lib\" -DBITMAPDIR=\"/gnu/store/vxgbyg2kigli0lw59cfb7r64xyf101rq-transfig-3.2.5e/lib/bitmaps\" -c -o genbox.o genbox.c

latex_line.c:176:1: warning: return type defaults to ‘int’ [-Wimplicit-int]

176 | latex_endpoint(x1, y1, x2, y2, xout, yout, arrow, magnet)

| ^~~~~~~~~~~~~~

In file included from /gnu/store/2fk1gz2s7ppdicynscra9b19byrrr866-glibc-2.33/include/bits/libc-header-start.h:33,

from /gnu/store/2fk1gz2s7ppdicynscra9b19byrrr866-glibc-2.33/include/stdlib.h:25,

from ../fig2dev.h:18,

from genbox.c:22:

/gnu/store/2fk1gz2s7ppdicynscra9b19byrrr866-glibc-2.33/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]

187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"

| ^~~~~~~

[…]

rm -f libtransfig.a

ar clq libtransfig.a genbox.o gencgm.o gendxf.o genepic.o gengbx.o genibmgl.o genlatex.o genmap.o genmf.o genpic.o genpictex.o genps.o genpdf.o genpstex.o genpstricks.o gentextyl.o gentk.o genptk.o gentpic.o genbitmaps.o genge.o genmp.o genemf.o gensvg.o genshape.o setfigfont.o psencode.o readpics.o readeps.o readgif.o readpcx.o readppm.o readpng.o readxpm.o readxbm.o readtif.o readjpg.o asc85ec.o readpng.o readxpm.o

ar: libdeps specified more than once

make[2]: *** [Makefile:1053: libtransfig.a] Error 1

make[2]: Leaving directory '/tmp/guix-build-transfig-3.2.5e.drv-0/transfig.3.2.5e/fig2dev/dev'

make[1]: *** [Makefile:1192: dev/libtransfig.a] Error 2

make[1]: Leaving directory '/tmp/guix-build-transfig-3.2.5e.drv-0/transfig.3.2.5e/fig2dev'

make: *** [Makefile:1030: all] Error 2

error: in phase 'build': uncaught exception:

%exception #<&invoke-error program: "make" arguments: ("-j" "4") exit-status: 2 term-signal: #f stop-signal: #f>

phase `build' failed after 4.6 seconds

command "make" "-j" "4" failed with status 2

```

Maybe some new version of the compiler got more picky with some deprecations?

I'm attaching the whole

`/var/log/guix/drvs/2x/m0s1604xx2wfzj8swza7jm6s94nz1l-transfig-3.2.5e.drv.bz2`.

Thanks a lot!

--

Ivan Vilata i Balaguer -- https://elvil.net/

Bona nit!

Ivan Vilata i Balaguer <ivan@selidor.net> skribis:

I added the patch to ‘gnu/local.mk’ and applied both patches.

Thanks!

Ludo’.