[PATCH] gnu: openocd: Fix udev rules.

  • Done
  • quality assurance status badge
Details
2 participants
  • Jorge Acereda
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Jorge Acereda
Severity
normal

Debbugs page

Jorge Acereda wrote 3 years ago
(address . guix-patches@gnu.org)(name . Jorge Acereda)(address . jacereda@gmail.com)
e20eb74025ab7b8cfa19c186b07eba1d619600f0.1642107106.git.jacereda@gmail.com
* gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
Fix plugdev->dialout group replacement.
---
gnu/packages/embedded.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (14 lines)
diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
index ea1a585f0f..b33a23e9cb 100644
--- a/gnu/packages/embedded.scm
+++ b/gnu/packages/embedded.scm
@@ -618,7 +618,7 @@ (define-public openocd
(("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
(patch-shebang "bootstrap")
(invoke "./bootstrap" "nosubmodule")))
- (add-after 'autoreconf 'change-udev-group
+ (add-after 'unpack 'change-udev-group
(lambda _
(substitute* "contrib/60-openocd.rules"
(("plugdev") "dialout"))
2.34.0
Maxim Cournoyer wrote 3 years ago
(name . Jorge Acereda)(address . jacereda@gmail.com)(address . 53239-done@debbugs.gnu.org)
87a6fzxao3.fsf@gmail.com
Hi Jorge!

Jorge Acereda <jacereda@gmail.com> writes:

Toggle quote (21 lines)
> * gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
> Fix plugdev->dialout group replacement.
> ---
> gnu/packages/embedded.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index ea1a585f0f..b33a23e9cb 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -618,7 +618,7 @@ (define-public openocd
> (("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
> (patch-shebang "bootstrap")
> (invoke "./bootstrap" "nosubmodule")))
> - (add-after 'autoreconf 'change-udev-group
> + (add-after 'unpack 'change-udev-group
> (lambda _
> (substitute* "contrib/60-openocd.rules"
> (("plugdev") "dialout"))
> 2.34.0

Good catch! I've deleted the phases trailing #t, normalized the commit
message a bit, and pushed as 1e8b999717.

Thank you!

Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 53239@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 53239
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help