[PATCHES] Add aerich

> +     (list git

> +             ;; FIXME: These tests fail with

> +             ;; obscure error messages.

> +             (for-each

> +              (lambda (test-file)

> +                (delete-file test-file))

> +              '("tests/test_reporter.py"

> +                "tests/test_runner.py")))))))

> +             (("codecov>=2\\.1\\.8") "codecov")

> +             (("pytest-cov>=2\\.10\\.0") "pytest-cov"))

> +             (("codecov>=2\\.1\\.8") "codecov")

> +             (("pytest-cov>=2\\.10\\.0") "pytest-cov"))

> +    (arguments

> +     ;; Tests are not packaged in the Pypi tarball and

> +     ;; require a poetry environment to be run from source.

> +     `(#:tests? #f))

> +  #:use-module (gnu packages version-control)

> +    (synopsis "Database migrations tool for Tortoise ORM")

> +    (description

> +      "This package provides @code{aerich} a Python database migrations tool for

> +Tortoise ORM.")

> +    (description

> +      "This package provides @code{aerich} a Python database migrations tool for

> +Tortoise ORM.")

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +     (list git

> It's only for tests, so WDYT of 'git-minimal', or even

> 'git-minimal/fixed'?

> Greetings,

> Maxime

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +             ;; FIXME: These tests fail with

>> +             ;; obscure error messages.

>> +             (for-each

>> +              (lambda (test-file)

>> +                (delete-file test-file))

>> +              '("tests/test_reporter.py"

>> +                "tests/test_runner.py")))))))

> If these tests fail, there's a problem somewhere in need of a fix.

> What are the error messages, and have they been reported upstream?

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +  #:use-module (gnu packages version-control)

> This creates a cycle between (gnu packages version-control) and

> (gnu packages python-check). To avoid cycles, could

>

> (a) python-codeclimate-test-reported be moved into a new module

>

> or

>

> (b) the importing be delayed with (module-ref ...), like in

> (guix build-system gnu)?

>

> By reducing cycles, "guix COMMAND some-package" needs to load less

> modules and hence less memory. There are also some other potential

> benefits, e.g. see ‘Faster "guix pull" by incremental compilation and

> non-circular modules?’ on guix-devel.

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +             (("codecov>=2\\.1\\.8") "codecov")

>> +             (("pytest-cov>=2\\.10\\.0") "pytest-cov"))

> Instead of ignoring upstream's lower bound on the versions,

> how about updating the dependencies in Guix?

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +    (arguments

>> +     ;; Tests are not packaged in the Pypi tarball and

>> +     ;; require a poetry environment to be run from source.

>> +     `(#:tests? #f))

> If they are not packaged in the pypi tarball, then it can

> be built from git instead. I also don't see how it required poetry.

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +    (synopsis "Database migrations tool for Tortoise ORM")

>> +    (description

>> +      "This package provides @code{aerich} a Python database migrations tool for

>> +Tortoise ORM.")

> (comma missing before 'a')

>

> This description is a bit short and it does not introduce the acronym

> ORM, see (guix)Synopsis and Descriptions:

>

> Descriptions should take between five and ten lines. Use full

> sentences, and avoid using acronyms without first introducing them.

> [...]

> Giacomo Leidi via Guix-patches via schreef op zo 06-03-2022 om 00:14

> [+0100]:

>> +    (description

>> +      "This package provides @code{aerich} a Python database migrations tool for

>> +Tortoise ORM.")

> Is it a tool, or a library? If it's a tool, the 'python-' prefix can

> be dropped and the inputs depropagated.

> + (arguments

> + (list

> + ;; 3 failed, 47 passed, 21 skipped, 1 warning

> + #:tests? #f))

> * gnu/packages/check.scm (python-coverage-5.5): New variable.

> ---

> gnu/packages/check.scm | 13 +++++++++++++

> 1 file changed, 13 insertions(+)

>

> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm

> index 6ad2b1acd8..f2871690a5 100644

> --- a/gnu/packages/check.scm

> +++ b/gnu/packages/check.scm

> @@ -38,6 +38,7 @@

> ;;; Copyright © 2020, 2021, 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>

> ;;; Copyright © 2021 Hugo Lecomte <hugo.lecomte@inria.fr>

> ;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be>

> +;;; Copyright © 2022 Giacomo Leidi <goodoldpaul@autistici.org>

> ;;;

> ;;; This file is part of GNU Guix.

> ;;;

> @@ -1745,6 +1746,18 @@ (define-public python-coverage

> executed.")

> (license license:bsd-3)))

>

> +(define-public python-coverage-5.5

> + (package

> + (inherit python-coverage)

> + (version "5.5")

> + (source

> + (origin

> + (method url-fetch)

> + (uri (pypi-uri "coverage" version))

> + (sha256

> + (base32

> + "0b112ly7vvplvm9l411aqknxhr7fzfyp28xhflhkcx78l3lqzrzb"))))))

> +

> * gnu/packages/python-xyz.scm (python-codeclimate-test-reporter): New variable.

> ---

> gnu/packages/python-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++-

> 1 file changed, 38 insertions(+), 1 deletion(-)

>

> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm

> index 1d43049776..23195bf86b 100644

> --- a/gnu/packages/python-xyz.scm

> +++ b/gnu/packages/python-xyz.scm

> @@ -63,7 +63,7 @@

> ;;; Copyright © 2019, 2020 Alex Griffin <a@ajgrf.com>

> ;;; Copyright © 2019, 2020, 2021, 2022 Pierre Langlois <pierre.langlois@gmx.com>

> ;;; Copyright © 2019 Jacob MacDonald <jaccarmac@gmail.com>

> -;;; Copyright © 2019, 2020, 2021 Giacomo Leidi <goodoldpaul@autistici.org>

> +;;; Copyright © 2019-2022 Giacomo Leidi <goodoldpaul@autistici.org>

> ;;; Copyright © 2019 Wiktor ?elazny <wzelazny@vurv.cz>

> ;;; Copyright © 2019, 2020, 2021, 2022 Tanguy Le Carrour <tanguy@bioneland.org>

> ;;; Copyright © 2019, 2021 M?d?lin Ionel Patra?cu <madalinionel.patrascu@mdc-berlin.de>

> @@ -26275,6 +26275,43 @@ (define-public python-flufl-lock

> (license (list license:asl2.0

> license:lgpl3)))) ; only for setup_helpers.py

>

> +(define-public python-codeclimate-test-reporter

> + (package

> + (name "python-codeclimate-test-reporter")

> + (version "0.2.3")

> + (source

> + (origin

> + (method git-fetch) ;no tests in pypi archive

> + (uri (git-reference

> + (url "https://github.com/codeclimate/python-test-reporter")

> + (commit (string-append "v" version))))

> + (file-name (git-file-name name version))

> + (sha256

> + (base32

> + "0mxph5l3k9ch4hs9l76k4wnmzhd94bylg92lvm2priyn24gkn9a1"))))

> + (build-system python-build-system)

> + (native-inputs

> + (list git-minimal/fixed

> + python-httpretty

> + python-pytest))

> + (propagated-inputs

> + (list (package

> + (inherit python-coverage)

> + (version "4.3.4")

> + (source

> + (origin

> + (method url-fetch)

> + (uri (pypi-uri "coverage" version))

> + (sha256

> + (base32

> + "1prkwz1hkcbx19nsadbcmk4wl27ysx001pa8bykfagd3d87zxbpa")))))

> + python-requests))

> + (home-page "https://github.com/codeclimate/python-test-reporter")

> + (synopsis "Reports test coverage to Code Climate")

> + (description "This package provides @{codclimate-test-reporter}, a Python

> +library teport test coverage to Code Climate.")

> + (license license:expat)))

> +(define-public python-pytest-cov-3.0

> + (package

> + (inherit python-pytest-cov)

> Likewise as for python-coverage-5.5, why the separate package?

> Dear Maxime,

>> Likewise as for python-coverage-5.5, why the separate package?

> Both python-pytest-cov and python-coverage have a lot of dependents,

> they must be updated on staging...

>

> $ guix refresh --list-dependent python-pytest-cov

> Building the following 521 packages would ensure 1172 dependent

> packages are rebuilt: python-pysox [...]

>

> $ guix refresh --list-dependent python-coverage

> Building the following 627 packages would ensure 1408 dependent

> packages are rebuilt: u-boot-puma-rk3399 [...]\

>

> I sent a patch for python-pytest-cov back in march,

> (https://git.savannah.gnu.org/cgit/guix.git/commit/?h=staging&id=12c9da35389dfba86ae0d863132a6b2c4374205a)

> On 01-07-2022 23:32, Giacomo Leidi via Guix-patches via wrote:

>> + (arguments

>> + (list

>> + ;; 3 failed, 47 passed, 21 skipped, 1 warning

>> + #:tests? #f))

>

> By disabling tests when they detect problems, we defeat the point of

> having tests. A 'failing' test is a good test, as it detected a

> problem (hopefully not a false positive ...) before the buggy result

> is actually used for real.

>

> It's like, say, firing a building inspector because they noticed that

> the building would fall over in case of some wind from an

> unanticipated direction, instead of making the building more sturdy,

> changing the building plan or not proceeding with actually building

> the building.

>

> What problems did the tests detect?

>

> Typo: teport -> report, would also be nice to state more explicitly it

> uploads information to some website.

>

> The service it communicates to (Code Climate) also doesn't appear to

> be free software, this isn't an automatic rejection (see, e.g.,

> Facebook-related packages) but it's still rather "eergh, do we really

> have to?".

> ... mentioning this in the commit message would avoid having the

> reviewer doing some pointless checking whether the new version doesn't

> contain malware, whether it builds reproducibly, etc, as it was

> presumably already done for the staging patch.

> * gnu/packages/databases.scm (aerich): New variable.

>

> Change-Id: I322d619dc80c943d50e28a96ba74d276784ab8da

> ---

> gnu/packages/databases.scm | 44 ++++++++++++++++++++++++++++++++++++++

> 1 file changed, 44 insertions(+)