Failed to compile rav1e which is dependence for tons of packages

> Hi there,

>

> rav1e failed to compile with error:

> Hi there,

>

> rav1e failed to compile with error:

> The issue caused by commit ad1e8a0906c. Possible fix:

>

> diff --git a/gnu/packages/crates-graphics.scm b/gnu/packages/crates-graphics.scm

> index e4cd01fadf..269bd991ab 100644

> --- a/gnu/packages/crates-graphics.scm

> +++ b/gnu/packages/crates-graphics.scm

> @@ -208,7 +208,7 @@ (define-public rust-aom-sys-0.2

> (build-system cargo-build-system)

> (arguments

> `(#:cargo-inputs

> - (("rust-bindgen" ,rust-bindgen-0.54)

> + (("rust-bindgen" ,rust-bindgen-0.58)

> ("rust-metadeps" ,rust-metadeps-1))))

> (native-inputs

> (list pkg-config))

>

>

> --

> starting phase `build'

> Error: CliError { error: Some(failed to select a version for `clang-sys`.

> ... required by package `bindgen v0.58.1`

> ... which is depended on by `dav1d-sys v0.3.4`

> ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`

> versions that meet the requirements `^1` are: 1.0.0

>

> the package `clang-sys` links to the native library `clang`, but it conflicts with a previous package which links to `clang` as well:

> package `clang-sys v0.29.3`

> ... which is depended on by `bindgen v0.54.1`

> ... which is depended on by `aom-sys v0.2.1`

> ... which is depended on by `rav1e v0.4.1 (/tmp/guix-build-rav1e-0.4.1.drv-0/rav1e-0.4.1)`

>

> failed to select a version for `clang-sys` which could resolve this conflict), exit_code: 101 }

> error: in phase 'build': uncaught exception:

> %exception #<&invoke-error program: "cargo" arguments: ("cinstall" "--release" "--prefix=/gnu/store/83mfvccy0szp2v9v2qk8xf5wz867ndnx-rav1e-0.4.1") exit-status: 1 term-signal: #f stop-signal: #f>

> phase `build' failed after 0.7 seconds

> command "cargo" "cinstall" "--release" "--prefix=/gnu/store/83mfvccy0szp2v9v2qk8xf5wz867ndnx-rav1e-0.4.1" failed with status 1

> On Tue, Dec 28, 2021 at 02:09:42AM +0300, Evgenii Lepikhin via Bug reports for GNU Guix wrote:

>> Hi there,

>>

>> rav1e failed to compile with error:

>

> Alright, for now I've reverted the commits that caused the problem.

>

> Specifically, I reverted this range of commits:

> 5b1ec376239602725171d4523406801b684ee195^..13d3120095e4baa03594d095b0afe9febbb7cee0

> IIUC, these were pushed together.

>

> Nicolas, can you take a look at the suggested fix shown below?

> You reverted 100+ commits but only one of them is problematic. Could you

> unrevert them barring ad1e8a0906cca4f5c2fd18534a935a375161e608?

> IIUC, a safe solution would be to exceptionally provide both

> rust-dav1d-sys 0.3.2 (for rav1e) and 0.3.4 (for nushell), the latter

> being called rust-dav1d-sys-0.3.

>

> With this we do not have to bother updating rav1e yet.

>

> WDYT?

> Hi,

>

> Suggested fix is insufficient because dependency on version is hard coded in the crate: https://github.com/rust-av/aom-rs/blob/ea9a45d6ec7bfd2cd0d6f9f43268d9e379bba168/aom-sys/Cargo.toml#L18

>

> We need to update both rust-aom-sys to == 0.3.0 and rav1e to >= 0.5.0.

> So, I pushed as 9309b488ca4ceef4fcc9283546e3b05c57b16ca8.

>

>> IIUC, a safe solution would be to exceptionally provide both

>> rust-dav1d-sys 0.3.2 (for rav1e) and 0.3.4 (for nushell), the latter

>> being called rust-dav1d-sys-0.3.

>>

>> With this we do not have to bother updating rav1e yet.

>>

>> WDYT?

>

> Sounds like a plan. Are you able to do it?

> This is now done on master. AFAICT both nushell and rav1e build. I'll

> let the OP confirm the issue is fixed and close the bug report.

>> We need to update both rust-aom-sys to == 0.3.0 and rav1e to >= 0.5.0.

>

> Okay, that's good to know. I hope that somebody will try it and report

> back.

> Now it is fixed.