[PATCH] gnu: Add xinitrc-xsession.

DoneSubmitted by John Kehayias.
Details
3 participants
  • John Kehayias
  • Liliana Marie Prikler
  • Maxime Devos
Owner
unassigned
Severity
normal
J
J
John Kehayias wrote on 26 Dec 2021 17:46
(name . Guix-patches)(address . guix-patches@gnu.org)
claE4XCyuPHhA3GP0NvOpH66ehTK0hBg7mPj5E1wjXcCNAFSlmvDyGhADWTyrhUzIdULcY-zYGKbAUuSobDviAPcP0VEVfUq-vsmpRCnoZs=@protonmail.com
Hi Guix,

This is a simple package from Arch's AUR that provides an xsession for using a user's ~/.xinitrc. I've been using this for a while to launch a bare WM (XMonad recently, but others in the past) from GDM and SDDM. There's no formal homepage and the git url will show as 404 in guix lint (I think because there is only git access). I added a description as well.

Thanks!

John
From de0672c0376d7e47165c1f1d62aa4413b33717fa Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

Toggle diff (66 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..a79a4c7fce 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,43 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Allows @code{~/.xinitrc} to be run as a session from your display manager.
+Use this package in your system configuration to make this xsession
+available.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1
J
J
John Kehayias wrote on 27 Dec 2021 06:13
[PATCH v2] gnu: Add xinitrc-xsession.
(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
qGil2Ls86qYCNWL13_HzvPqNbUne0ppvw_7aynliJaUgbTHJ3YhuJ3UEnKwa9rKLXjMAE__dDSAJwRW_b6SsBkYyKbA66vMWeERq8L9dMmE=@protonmail.com
I forgot to note in the description that ~/.xinitrc needs to be executable for this xsession to run. Attached is the revised patch.

Thanks!
John
From 5a974cce288973199d891223b3d9b84b2c683bb0 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

Toggle diff (66 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..39c447c07d 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,43 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Allows @code{~/.xinitrc} to be run as a session from your display manager.
+Make @code{~/.xinitrc} executable and use this package in your system
+configuration to use this xsession.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1
J
J
John Kehayias wrote on 27 Dec 2021 16:19
[PATCH v3] gnu: Add xinitrc-xsession.
(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
vbaftcGIfBnyyOSRbQTDMjEMDx3_WxDtMBS__QPqCZ4C2xRy14YJFl_2nuVgb71appobaVEI3xBbQERkun177X9MP5nMmLSlWPoqzE9tNnM=@protonmail.com
Adjusted indentation and description per suggestions on another package (#52803). Did not see guix lint pick up that the description did not start with the package name, will have to investigate.

Thanks!
John
From 45d2c27781bc2165b07147df1266a717f6143306 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
gnu/packages/wm.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)

Toggle diff (65 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..820b4bc6a5 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,42 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration to use this xsession.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1
J
J
John Kehayias wrote on 11 Jan 22:29 +0100
[PATCH v4] gnu: Add xinitrc-xsession.
(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
Tca_dw8KFQqPly2ZsyvwXwJwc7jXy0WHVlxf8V3BZSVoTh3sL3Jw3HLlu4e47rLSUAenurW-o4YPuT9IQEDoEzcZAlweUOGyxYYrR2WmIGw=@protonmail.com
Updated this package after feedback via IRC, updated to use git-version and gexp.
From 99cddf5130f9b5c95f268f09bce8b50e7951a7c3 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
gnu/packages/wm.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

Toggle diff (74 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index bf24dfa0d9..297244abcf 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,9 +69,11 @@ (define-module (gnu packages wm)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2320,47 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374")
+        (revision "0"))
+    (package
+      (name "xinitrc-xsession")
+      (version (git-version "1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'install 'patch-xsession-file
+              (lambda* (#:key outputs #:allow-other-keys)
+                (let* ((xinitrc-desktop
+                        (string-append #$output "/share/xsessions/xinitrc.desktop"))
+                       (xinitrc-helper
+                        (string-append #$output "/bin/xinitrcsession-helper")))
+                  (substitute* xinitrc-desktop
+                    (("Exec=xinitrcsession-helper")
+                     (string-append "Exec=" xinitrc-helper)))))))
+        #:install-plan
+        #~(list '("xinitrcsession-helper" "bin/")
+                '("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration have this xsession available to your display
+manager.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.0
M
M
Maxime Devos wrote on 11 Jan 23:24 +0100
71035272c469269e65a7a4048b72a65da19a9bb2.camel@telenet.be
John Kehayias via Guix-patches via schreef op di 11-01-2022 om 21:29 [+0000]:
Toggle quote (3 lines)
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let* ((xinitrc-desktop
> +                        (string-append #$output
"/share/xsessions/xinitrc.desktop"))
Toggle quote (2 lines)
> +                       (xinitrc-helper
> +                        (string-append #$output
"/bin/xinitrcsession-helper")))
Toggle quote (4 lines)
> +                  (substitute* xinitrc-desktop
> +                    (("Exec=xinitrcsession-helper")
> +                     (string-append "Exec=" xinitrc-helper)))))))

'outputs' is unused here, so you can simplify the lambda from
(lambda * (#:key outputs #:allow-other-keys) ...)
to
(lambda _ ...).

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYd4DmhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uVfAP0X/JGBUimsNKwckQKAUynx/2PR
E2iJ1rC/FePr6F6SZAEAnLfSTsrPIIXiwUodROvHHc+rX2AuNkcsx3aQNkOg3A4=
=d6C1
-----END PGP SIGNATURE-----


J
J
John Kehayias wrote on 11 Jan 23:34 +0100
Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
(name . Maxime Devos)(address . maximedevos@telenet.be)(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
8jp1iB7YrQ26RetEUuJm06jn0q0xsMCcEiRhKdaD-1X5Febwpb5VDSQHx1OUQ2t0G2s-qBB4QJcNh4YW3ocSlcUEGunRZoX6W0n3YqfGi2o=@protonmail.com
Hi Maxime,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:

Toggle quote (6 lines)
> 'outputs' is unused here, so you can simplify the lambda from
> (lambda * (#:key outputs #:allow-other-keys) ...)
> to
> (lambda _ ...).
>

Right, another thing that can be removed here with the gexp. Thanks!

John
From b8344d2876e978d80bf56ba65993c4cf66246dad Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
gnu/packages/wm.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

Toggle diff (74 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index bf24dfa0d9..72e2e37313 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,9 +69,11 @@ (define-module (gnu packages wm)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2320,47 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374")
+        (revision "0"))
+    (package
+      (name "xinitrc-xsession")
+      (version (git-version "1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'install 'patch-xsession-file
+              (lambda _
+                (let* ((xinitrc-desktop
+                        (string-append #$output "/share/xsessions/xinitrc.desktop"))
+                       (xinitrc-helper
+                        (string-append #$output "/bin/xinitrcsession-helper")))
+                  (substitute* xinitrc-desktop
+                    (("Exec=xinitrcsession-helper")
+                     (string-append "Exec=" xinitrc-helper)))))))
+        #:install-plan
+        #~(list '("xinitrcsession-helper" "bin/")
+                '("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration have this xsession available to your display
+manager.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.0
J
J
John Kehayias wrote on 27 Jan 04:33 +0100
(name . Maxime Devos)(address . maximedevos@telenet.be)(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
xpvAbzMFF_MnhvXw-U3K3gI7z-Q-mDmrMOQ17BoXF40nu0W02OSEelEwwYpXRoRe_lUfZCtTlcgFFk_6GHE2SU8fZZsP5euBGhCLoj6S9ls=@protonmail.com
Hi Maxime,

Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:

Toggle quote (10 lines)
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
>
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
>

Was there anything else I should take care of?

Thanks again for the suggestion!

John
M
M
Maxime Devos wrote on 27 Jan 16:56 +0100
(name . John Kehayias)(address . john.kehayias@protonmail.com)
be7bd63268336dee56286669ce6330e5b3405149.camel@telenet.be
user guix
usertag 52806 + reviewed-looks-good
thanks

John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
Toggle quote (16 lines)
> Hi Maxime,
>
> Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:
>
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> >
> > > 'outputs' is unused here, so you can simplify the lambda from
> > > (lambda * (#:key outputs #:allow-other-keys) ...)
> > > to
> > > (lambda _ ...).
> >
>
> Was there anything else I should take care of?

IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
the source code of xinitrc-xsession.

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYfLAkhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pUSAP4hwQSgNKmqhRr4x/cnnGObiWbx
dRiSgFY88FFuPlFNYAEAtKeYv7bmHYiXrXN0H2lx6dR6CzpJh97gtQNMtx2MtQ8=
=9Bkf
-----END PGP SIGNATURE-----


J
J
John Kehayias wrote on 28 Jan 21:47 +0100
(name . Maxime Devos)(address . maximedevos@telenet.be)
-NI4npdOkU76MKEpUxs7M7DeRlrMwfjLWUwnBt7_6PY-YJXa7JkXHgzfNWUJoTj7HItnIOvseqj4N4_joUI3jl-r49oO3JWC68ph-CFsm5Y=@protonmail.com
Thanks Maxime!

------- Original Message -------

On Thursday, January 27th, 2022 at 10:56 AM, Maxime Devos wrote:

Toggle quote (12 lines)
> user guix
> usertag 52806 + reviewed-looks-good
> thanks
>
> John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
>
> > Was there anything else I should take care of?
>
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
>

There is not much to the source, mostly it is an easy way to provide an xsession for your xinitrc. So the source is just a desktop file and helper script to execute a user's xinitrc. Basically making it convenient, through having this in your system configuration, to login through a display manager but with the more barebones (or controllable) xinit style. For example, I use this to set up my bare WM (xmonad) the same as I do when I don't run a display manager.

John
M
M
Maxime Devos wrote on 28 Jan 22:34 +0100
(name . John Kehayias)(address . john.kehayias@protonmail.com)(name . 52806@debbugs.gnu.org)(address . 52806@debbugs.gnu.org)
b3422b3686dc6a895a642302a41ebda753321682.camel@telenet.be
Maxime Devos schreef op do 27-01-2022 om 16:56 [+0100]:
Toggle quote (9 lines)
> > [...]
> > Was there anything else I should take care of?
>
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
>
> Greetings,
> Maxime.

Also, to be clear, I'm not a committer.

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYfRhdhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ppfAP0ddVTYS5WJ7G/qKG1eBeWTO8ci
d/3tOEoraqbGAtT4vAD/doo1ebYbGwsy4dObrmNJx1lEYH4KqkTZ51XoFOJxvgQ=
=LbNP
-----END PGP SIGNATURE-----


L
L
Liliana Marie Prikler wrote on 4 Feb 20:52 +0100
(address . 52806-done@debbugs.gnu.org)
368b2bbb7c7f3832f431be5ac81637818e16f2c5.camel@gmail.com
Am Dienstag, dem 11.01.2022 um 22:34 +0000 schrieb John Kehayias:
Toggle quote (15 lines)
> Hi Maxime,
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
>
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
> >
>
> Right, another thing that can be removed here with the gexp. Thanks!
>
> John
Hi, I was told Maxime already reviewed this, so I pushed it. Cheers!
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 52806@debbugs.gnu.org