[PATCH] gnu: syncthing-gtk: Remove librsvg input

  • Done
  • quality assurance status badge
Details
2 participants
  • John Kehayias
  • Leo Famulari
Owner
unassigned
Submitted by
John Kehayias
Severity
normal

Debbugs page

John Kehayias wrote 3 years ago
(name . Guix-patches)(address . guix-patches@gnu.org)
lT0G87o1OLdp5GmLjxq9chtfsd8WFd-O-StRv2VuItp5Zg6c3MCUSXfDLNNEsMFak-Di7gmywZI-61PqVPBrEcfv1hsQCvngcuRiOwjO_fM=@protonmail.com
This is a patch to fix https://issues.guix.gnu.org/52651

syncthing-gtk fails to start due to multiple librsvg in the GI_TYPELIB_PATH. The package includes gtk+ as an input, which propagates librsvg-bootstrap, as well as an explicit librsvg input. This patch removes the librsvg input resolving the issue.

I've tested the package builds and runs successfully.

Thanks!
From e6d51b3d5a5523ce43f79f5d8f881e685bda74b6 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 19 Dec 2021 17:39:22 -0500
Subject: [PATCH] gnu: syncthing-gtk: Remove librsvg input

* gnu/packages/syncthing.scm (syncthing-gtk)[inputs]: Remove LIBRSVG as GTK+
propagates LIBRSVG-BOOTSTRAP. This fixes a startup error due to two LIBRSVG
being in GI_TYPELIB_PATH.
---
gnu/packages/syncthing.scm | 1 -
1 file changed, 1 deletion(-)

Toggle diff (14 lines)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index a957d7738b..112a437875 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -187,7 +187,6 @@ (define-public syncthing-gtk
(list gtk+
libappindicator
libnotify
- librsvg
python-bcrypt
python-dateutil
python-pycairo
--
2.34.0
Leo Famulari wrote 3 years ago
(name . John Kehayias via Guix-patches via)(address . guix-patches@gnu.org)(address . 52673@debbugs.gnu.org)
Yb/XsWz9Yt7UNHEs@jasmine.lan
On Sun, Dec 19, 2021 at 10:49:42PM +0000, John Kehayias via Guix-patches via wrote:
Toggle quote (2 lines)
> I've tested the package builds and runs successfully.

Perfect!

Toggle quote (9 lines)
> From e6d51b3d5a5523ce43f79f5d8f881e685bda74b6 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias@protonmail.com>
> Date: Sun, 19 Dec 2021 17:39:22 -0500
> Subject: [PATCH] gnu: syncthing-gtk: Remove librsvg input
>
> * gnu/packages/syncthing.scm (syncthing-gtk)[inputs]: Remove LIBRSVG as GTK+
> propagates LIBRSVG-BOOTSTRAP. This fixes a startup error due to two LIBRSVG
> being in GI_TYPELIB_PATH.

Pushed as 99f290bf5ba59e3218b95d7505ac27f989250aad
Leo Famulari wrote 3 years ago
(no subject)
(address . control@debbugs.gnu.org)
Yb/X0zmnUFNAEy1L@jasmine.lan
close 52673
?
Your comment

This issue is archived.

To comment on this conversation send an email to 52673@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 52673
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help