[PATCH] gnu: boost-signals2: Update hash

  • Done
  • quality assurance status badge
Details
2 participants
  • Aleksandr Vityazev
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Aleksandr Vityazev
Severity
normal

Debbugs page

Aleksandr Vityazev wrote 3 years ago
(address . guix-patches@gnu.org)
502a90e38bb6f5832fb4230c09e8c9d3343be868.1639528799.git.avityazev@posteo.org
* gnu/packages/boost (boost-signals2): [source]: Update hash.
---
gnu/packages/boost.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 53815c0268..dab3abffab 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -18,6 +18,7 @@
;;; Copyright © 2021 Greg Hogan <code@greghogan.com>
;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
;;; Copyright © 2021 Greg Hogan <code@greghogan.com>
+;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -406,7 +407,7 @@ (define-public boost-signals2
(file-name (git-file-name name version))
(sha256
(base32
- "13i5j43nggb46i6qpaf7gk53i7zp7pimphl7sydyfqz2m9yx5cdy"))))
+ "1prhj98jgvkj2m3ia5lcgxnl1a4h13cyzqd55skjn983rivi6090"))))
(build-system trivial-build-system)
(arguments
`(#:modules ((guix build utils))
--
2.34.0



--

Aleksandr Vityazev
Tobias Geerinckx-Rice wrote 3 years ago
(name . Aleksandr Vityazev)(address . avityazev@posteo.org)
871r2evcs2.fsf@nckx
Aleksandr,

Aleksandr Vityazev 写道：
Toggle quote (2 lines)
> * gnu/packages/boost (boost-signals2): [source]: Update hash.

Thanks!

Hash changes happen… ‘but they shouldn't’. Commit messages should
not imply that they're routine.

The diff is quite significant:

$ git diff 10b030be782b979509cee15e0f0afde59d2f9581..\
4a51d6e47230123d413cbecb19eb94f195301b8e | wc -l
1829

We should record the two commits in the change log.

10b030b is from October 2019. Boost 1.77.0 wasn't released until
August 2021[0].

The boost-1.77.0 tag hasn't been moved from 4a51d6e since June
2021. It seems likely that upstream creates boost-X.Y.Z tags
targetting unreleased future Boost versions, moves them freely,
but stops once that Boost version is released.

That's something we could document in a comment, at least.

I'll ask for confirmation on their bug tracker.

Only two formatting nitpicks:

Toggle quote (2 lines)
> gnu: boost-signals2: Update hash

Missing ‘.’.

Toggle quote (2 lines)
> * gnu/packages/boost (boost-signals2): [source]: Update hash.

Drop the first ‘: ’.

Pushed as 04b6e1ed265e64a004c7ea93018179785b979f31 with those
changes.

Kind regards,

T G-R

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYblOjQ0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15ZcwBAMrVqlEVZGV72JkryO8OpVVgjkTQ5dBnyVILzMv8
wPNJAP9XBWbWvXsdzua7OSpoiXKjxJFCdWbSzEcrbsEjy/ViCA==
=+rsD
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send an email to 52497@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 52497
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help