[PATCH] gnu: subversion: Add --enable-plaintext-password-storage flag

  • Open
  • quality assurance status badge
3 participants
  • Leo Famulari
  • Philip Kaludercic
  • Ricardo Wurmus
Submitted by
Philip Kaludercic
Philip Kaludercic wrote on 28 Nov 2021 16:41
(address . guix-patches@gnu.org)(name . Philip Kaludercic)(address . philipk@posteo.net)
* version-control.scm (subversion): Enable plain text passwords while
compiling SVN, undoing the controversial move to disable them by the
maintainers. See also
gnu/packages/version-control.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 10487c6939..ff3dc61456 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1969,7 +1969,8 @@ (define-public subversion
'(#:parallel-tests? #f ; TODO Seems to cause test failures on
; i686-linux
- #:configure-flags '("--enable-static=no")
+ #:configure-flags '("--enable-static=no"
+ "--enable-plaintext-password-storage")
(modify-phases %standard-phases
(add-after 'configure 'patch-libtool-wrapper-ls
Leo Famulari wrote on 28 Nov 2021 23:08
(name . Philip Kaludercic)(address . philipk@posteo.net)(address . 52162@debbugs.gnu.org)
On Sun, Nov 28, 2021 at 03:41:10PM +0000, Philip Kaludercic wrote:
Toggle quote (5 lines)
> * version-control.scm (subversion): Enable plain text passwords while
> compiling SVN, undoing the controversial move to disable them by the
> maintainers. See also
> https://lists.apache.org/thread/b6g2hx2m3s117wcmno08opl874ons3q8.

Thanks for the patch!

Toggle quote (4 lines)
> - #:configure-flags '("--enable-static=no")
> + #:configure-flags '("--enable-static=no"
> + "--enable-plaintext-password-storage")

In general, in Guix, we aim to distribute software as it was released by
upstream. We do make changes to fix bugs, but it's outside our normal
activity for us to change defaults from upstream.

This is partly a pragmatic choice (less work to maintain) and partly a
way in which we choose to be "good citizens" with respect to our role as
distributors. But also, because Guix makes it easier for users to
customize their packages compared to other systems like APT and RPM.

I would like to hear other peoples' opinions before we decide about this
Ricardo Wurmus wrote on 29 Nov 2021 09:15
[PATCH] gnu: subversion: Add --enable-plaintext-password-storage flag
(address . 52162@debbugs.gnu.org)
I’ve read the discussion that ends with an email[1] by Nathan
Hartman expressing support for enabling the feature but disabling
it by default in configuration. Hence I think it would be
reasonable to wait for a new release addressing it. In the
meantime users can define their own package variant with this
configure flag added.

It doesn’t need to be changed in Guix itself, because this only
affects users of the package, not other packages that have
subversion as an input. So it’s enough to add a new leaf package.
As a compromise I think it would be acceptable to add a separate
subversion-plaintext (or whatever) package variant, which will be
superseded by the official subversion package as soon as a new
release is made.


Philip Kaludercic wrote on 23 Sep 2021 14:08
Re: bug#50297: 28.0.50; Aggregate project functions for project.el
(name . Dmitry Gutov)(address . dgutov@yandex.ru)(address . 50297-done@debbugs.gnu.org)
Dmitry Gutov <dgutov@yandex.ru> writes:

Toggle quote (8 lines)
> On 23.09.2021 13:46, Philip Kaludercic wrote:
>> Sorry about that, forgot to byte-compile before preparing the
>> patch. This should fix the issues:
> Thanks. You can go ahead and install.
> Just add NEWS entries for the commands.

Done and pushed.

Philip Kaludercic