home-bash-service-type adds the defaults and aliases to the end of the file

DoneSubmitted by Andrew Tropin.
Details
2 participants
  • Andrew Tropin
  • Xinglu Chen
Owner
unassigned
Severity
normal
A
A
Andrew Tropin wrote on 17 Nov 2021 10:30
(address . bug-guix@gnu.org)
8735nvp1sj.fsf@trop.in
Test in guix-home.sh looks correct, but it fails:

Seems something changed in home-bash-service-type, for some reason it
adds the serialized content of aliases field and guix-bashrc variable
after the content of bashrc field.

Original implementation works as expected and adds the content of bashrc
to the end of ~/.bashrc.

Toggle snippet (13 lines)
(list
((@ (gnu services) service)
(@ (gnu home-services shells) home-bash-service-type)
((@ (gnu home-services shells) home-bash-configuration)
(guix-defaults? #t)
(bashrc (list "echo hi"))))
((@ (gnu services) simple-service)
'test-bash
(@ (gnu home-services shells) home-bash-service-type)
((@ (gnu home-services shells) home-bash-extension)
(bashrc (list "echo very hi")))))

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmGUy6wPHGFuZHJld0B0
cm9wLmluAAoJECII0glYwd6wJaAP/A/GodMDtKyjw1KMXPlPM7dmXaJf4a1BiY7t
yYOp2GTmSyitcHmqn2/x+f5TsaEFiEcxbwEcZVe884QoRqhHv8JBL8zxwOk1EDyI
hMW8Il/AScXWpxOeoeTgJLGMeTqz8mJZBpn/M9zD6bJyQULRQHZpbaIjXvxQ/96F
VTzpmc0uKsjDUgMnNFzKLgq7eeojPqs8SWWW42q2+x6zIwTGxjAXG5on8g0kex2T
27qwdO2kARILRQ/mkd2YXlTo+YvrJosHto3jiLuYFLg9uyZ1xW8QpmPK3Ae8tSjj
1MidxHryz9myW+nN5KOaOSDIX9sTRp8D8YS9qefTPYMf30vqlQickGjOOdCog9rw
ZCBv5oB9K5GVDImM+ZSho0XyHRZuku8TAyYD4cDGKH7RLo+Kkp3bD08CrgYP3SvY
4dqAVVh102230tzsxCs5skfLm/PRxYVKoj6Pobpb/4vtzSOl3GTaFyQ7sSazGsiY
4QWA7f+PIUSFCSNwxM4Npwk9xBPrPm8gC/OziRfdIszAWUVu35aCEir5lEj+EmTn
fNDTfm58v3r4W9SZOdRaFfddrC01JSDYJuaYXrS98ileCLRCuRvQJMCYEi/tjtpv
og/hk7HCZMmYwqBiXbOrFBtj+2NYfJYprWOFbmX4VvcaobIPnvM7zrv13OmbsHoK
DM/KX7Ko
=Zaak
-----END PGP SIGNATURE-----

X
X
Xinglu Chen wrote on 19 Dec 2021 09:45
87a6gxoudm.fsf@disroot.org
Hi,

On Wed, Nov 17 2021, Andrew Tropin wrote:

Toggle quote (7 lines)
> Test in guix-home.sh looks correct, but it fails:
> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>
> Seems something changed in home-bash-service-type, for some reason it
> adds the serialized content of aliases field and guix-bashrc variable
> after the content of bashrc field.

This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
after discussing it with Liliana[1]. I didn’t really have a strong
opinion on the order of the things; do you think that it should be changed?

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmG+8TUVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5IM8P/1fjB3R2xijQDBWC6IOCewO5jmaV
RvOH998vu4LPfMr7PATfMzjtNJPaBIZUELegPchSR6kKilhXDizjqo0BXRogxLzK
9gfmLPYQwnWbudSQGbVX07r9lsOCxCxSVvQGD2fybiJrGZ/CCRCOCJfLkNce1Eay
TreC5AFaMOcTrSyCHby8HboA+QcWUMxt0zynKWY+y87GYeWFyhJRidm97W/yNB0W
6qbmfM0rMtlCA8eymaykj1+Y/EcmqM1jvQ6wP3MQeHxk6dJa1yOBiyq4E32LIU/S
zlnBg7vXtdanhMrWyKcgpBJp1Jg966E8LOQVxyQc+u7t6prIGNmYxdzB6/NEGaWA
H1Hh6Z+G5yIx8+FAocQW0NncpSF8LSNPf67BJTAkZ2rvo8LAVpUUWdeC7e3Q7U+x
U6bipCkaS9nWlmGVCXKPrkzWF5Hw6k5p1D1pqId1lHY4AucGj7EkqBD9kpUkSEaU
FnNFSeSkLx4Ov8xS5yygT8AP1OyH+/FbGGx4Ke5/OnnZ/Ao2vENBy8neL4A8WFm8
lkheR0ybHGlBBp6dEbH7P4M43Q/Fr+tZP/tvp/TzcTmv5ZwyQuN1JiXoimcsxsEf
gTV3K2Ut9MCzTnbScpkDzpRmr6+G1Rbv6hLZ5thO5/LqJecbRufnbHNG6nkFAVk6
MfQcWTAGgASwB8a0
=gMAp
-----END PGP SIGNATURE-----

A
A
Andrew Tropin wrote on 30 Dec 2021 09:26
87zgoilcr0.fsf@trop.in
On 2021-12-19 09:45, Xinglu Chen wrote:

Toggle quote (17 lines)
> Hi,
>
> On Wed, Nov 17 2021, Andrew Tropin wrote:
>
>> Test in guix-home.sh looks correct, but it fails:
>> https://git.savannah.gnu.org/cgit/guix.git/tree/tests/guix-home.sh?h=5eb5c0789f34e87ee417a53ddfcfa3b6521bb337#n98
>>
>> Seems something changed in home-bash-service-type, for some reason it
>> adds the serialized content of aliases field and guix-bashrc variable
>> after the content of bashrc field.
>
> This was changed in commit 2f665d4309053d5a9fe25bc93ee78d55dbc30cb7
> after discussing it with Liliana[1]. I didn’t really have a strong
> opinion on the order of the things; do you think that it should be changed?
>
> [1]: <https://yhetil.org/guix/87k0hs57uu.fsf@disroot.org/>

Seems Ludovic fixed it in c322d97832081e6e1913c6311616030d1fad4ee2, I
just had a slightly outdated local repository, when I was reporting this
bug, everything is ok now)

--
Best regards,
Andrew Tropin
-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHNbTMPHGFuZHJld0B0
cm9wLmluAAoJECII0glYwd6wqzAP/RdKl3N2+rdhFczMOBNV5RfAsnnm4SRkj5Nh
huM5C2tLfr0f6orCJ99K+EfK5uuXy6PzJSE9m9ApDD7gDvP+Mr+ZufN2MHH9ZnfF
QoWJKTfBpgEOytL7Kg+to1uzi33T3XdPXE8ua0gXDF4UXz9vApyhE752T9D+3/8y
EmW2xrzaeuF1QcEN+FcsrxxjJnGivvQobJ/Axiy5EmTUsZUJcP4QcWVSiCfGyaMw
TYDIzXZLOK4tAKsChEPqR6tYvrRGW+cSuY10oUYTbYMUUogg1jejg6o1uegTLfqR
M6GBJA1lhXAtq1yR9d4Az6n0yfsbDSnfqlgHBkPg0UQmmPvvXxW8pFPowvUTle01
a5ay9BxTZcRXAAL5T4AAKhGMLMNDmIF+P51t+PpAR4QELKpTBYAwuA9Iue7gkgpw
zCDwW/6mDG0D5rzjxnsDJEBLBMOvBWxofbxYxZ8Vt189K2iROe1t9vWbBePDMgLn
HVBwdVLXCm/6AKv22L0smaVQUgJRHtqZOGIZMgLFs4rChroKn86UOfbPDBXudw/A
mt2oqG1embKQc0Blgt4fjn0GKboEDnZEL19u55C7ulQI+IWqczdY+79GDz3SRRli
jprstb2d/2f7EhYMQiEIm35gFXcZONkWztTjNvQ8x9SOUYhUpKJsOlXZsJIOPud+
odrGJJki
=/KE7
-----END PGP SIGNATURE-----

A
A
Andrew Tropin wrote on 30 Dec 2021 09:28
(address . control@debbugs.gnu.org)
87wnjmlco5.fsf@trop.in
close 51918
-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHNbZoPHGFuZHJld0B0
cm9wLmluAAoJECII0glYwd6wfoEP/18jtUSPWimL6ZMIrsEcUBzm9Bl/DX53I+jU
gRjMXy1BNsRQ3DI5WEinPiZPlUjyw+iTh090tsOrU/vxFZwP5vy3pWAWe/dS3ti/
6pd6gZYqofuB7f2N3RL36owwvTFrO64M3Y9BQWDShrblS4340PYhDoejdsM+S8jO
dDeXD0BxEIuX0FODlLAIVuUpEUuYTdjEEXekE+LqQKtF27rBjZ701Qicoaqpx/vB
ixL6e76355oVhMRC5eTnj8ZzpRxgfRJcoiUpCN1DXdS89rglnLnqPadL3OC+KTDJ
syTo1+L4ia7VoZlVKt6d1yDw6JTodgQt8uu3Ym2h3OF80KJ+8hxGJgiGA6so3B0p
56M2MPCzF+NaqzG6JlE0EOmaPsJDD8AyVbVDPX32Th9DQch+BVT6SbY7zCFsenS2
MCRd3SnwbVshJNmfSjRZ8K9CJCU2UIb1a0FFK1JWJ27sqi5z4j1E14rhfpITfvV+
aiQ7kUkIpQIWSAXCrdzPpdAt7O+Dkkf4x5qVp2bWO12tEQlE6VSAv697cTsTeEbU
rtmSzCeIdOXu6ETwyOYuQVKyw+Yl4fhC7dD9OrOiwpAXNLTIHpYbF2gu4O3Ud7lM
VNYWxo7PJbGTE2BATruagW9sxC6bh7EhbJUzlxZf948YFUXlyg8AJka3dqmPBOi8
Ro6iJ+/H
=cnWp
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send email to 51918@debbugs.gnu.org