Vigra: disable more failing tests on core-updates-frozen

  • Done
  • quality assurance status badge
Details
4 participants
  • Efraim Flashner
  • Ludovic Courtès
  • Maxim Cournoyer
  • Vivien Kraus
Owner
unassigned
Submitted by
Vivien Kraus
Severity
normal
V
V
Vivien Kraus wrote on 16 Nov 2021 12:12
(address . guix-patches@gnu.org)
878rxotkvc.fsf@planete-kraus.eu
Dear guix,

vigra fails to pass a few more tests on core-updates-frozen. I propose
that we discard them. What do you think?

Best regards,

Vivien
From 9c376135ea264418cdc9eaa339274f244ba2e729 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 16 Nov 2021 08:18:42 +0000
Subject: [PATCH] gnu: vigra: Disable more failing tests.

* gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
test2.
---
gnu/packages/image.scm | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (19 lines)
diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index ed846d7141..6d5408864e 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1230,6 +1230,12 @@ (define-public vigra
;; <https://github.com/ukoethe/vigra/issues/436>.
(substitute* "vigranumpy/test/CMakeLists.txt"
(("test1\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test[23]\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test_arraytypes\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test_multidef\\.py") ""))
#t)))
#:configure-flags
(list "-Wno-dev" ; suppress developer mode with lots of warnings
--
2.33.1
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEq4yIHjMvkliPpwQnO7C8EjLYuCwFAmGTkhcACgkQO7C8EjLY
uCwO8gv/bDoS8kEyweBKaeSaA6IGc2BKDWQlQ+TlpH59Q9iYcsooCoDIH34z6jXO
EFLnG+o3whLI3sVfvwQzCTnZlz3i6Q+9HdsWD7TJJYI+ihYf/KSZWq9IOhvlAo5Q
cDSuKqHEOp/7T7Us6GDbmQrY/lmk/yB7SCnxgOvCVBWMR0fwFqG9OX/xIY014+1c
MyR5kpRAsQEiUgPFiHczL4rS4CW2YKYkJ/6OX3IUqp7a06Mnv1rRM9QzulP6GH6H
D/EgA87Vd/yVthggsSw5QjP2esoqQFTvyZUbNr1i4ALO9T5shxSYxB1ZUfXZ6ZqP
CuEwD3ubXyRglTwj6OWOxcJvnkSMolMER4IBmWMcnmFkRiBO+SyL4x5Bq5E36FFB
C7u5r+YMLIavsko2vYb7qtbqIusrkNjVRdI+0yrrSY5jWoGhYi5wckNQ3GiaUvRs
hO/ZqNFxf+KQ4NMwfi/61x5XYk6C+xpmM+8XuFN8qxvNPM7NhltK8wBCLGcFb/78
AT0QOSWG
=ZVxx
-----END PGP SIGNATURE-----

V
V
Vivien Kraus wrote on 17 Nov 2021 09:54
(address . 51890@debbugs.gnu.org)
87tugbrwiv.fsf@planete-kraus.eu
Sorry, I forgot some disabled tests in the changelog message.

Vivien
From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 16 Nov 2021 08:18:42 +0000
Subject: [PATCH] gnu: vigra: Disable more failing tests.

* gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
test2, test3, test_arraytypes and test_multidef.
---
gnu/packages/image.scm | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (19 lines)
diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index ed846d7141..6d5408864e 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1230,6 +1230,12 @@ (define-public vigra
;; <https://github.com/ukoethe/vigra/issues/436>.
(substitute* "vigranumpy/test/CMakeLists.txt"
(("test1\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test[23]\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test_arraytypes\\.py") ""))
+ (substitute* "vigranumpy/test/CMakeLists.txt"
+ (("test_multidef\\.py") ""))
#t)))
#:configure-flags
(list "-Wno-dev" ; suppress developer mode with lots of warnings
--
2.33.1
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEq4yIHjMvkliPpwQnO7C8EjLYuCwFAmGUw5gACgkQO7C8EjLY
uCxFrAv/SxXtCClP+85OSZTDy7+yMWMHGon9aV/bAPwfJ/BDR+YC4JFIECyHwUIG
4iKZDp4pwK0Zg8036DmLWnbBk6vPz76fyuNWm16Z4C9DG0k2VUL2E0SOAJbqIOUp
kW5L1Fht2y9F3F8Kxxq0Z2N/It2eDJZUGJcj34GXyZJXTZMvYME1uSEinc6TFrD5
LeWIXkipl+Y5tTNsBtRIG6PfdHXtdvqbmFP5Yhoh2/Brc2WaaQWioARDnPAz/p3E
juRlDAeYyJaPdrHRFQazvgoRmnLVDZ+/mnRfMNmcMZHmm8IcZ9pf64J9c8EUJpNt
DjPUvzO4DZIljn0INlPova88OcZTb8EK/aI5q7I74f6wxRuDly9HO+/9FNkJBR75
vrESQbMf5gIjeO1X0esBh1a5W4hC9mRaY867FFshZcufbpOKFmfwV4bM6N990nrU
S9e4dafyh/d+aYaX+LlnAKAtcMIhWaIYY/FLwf3gw/WKTN8TjiEjXZekqhgJa6hS
S+nlb/1u
=A7+X
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 18 Nov 2021 10:09
Re: bug#51890: Vigra: disable more failing tests on core-updates-frozen
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87a6i1rfs1.fsf_-_@gnu.org
Hi,

Vivien Kraus <vivien@planete-kraus.eu> skribis:

Toggle quote (8 lines)
> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien@planete-kraus.eu>
> Date: Tue, 16 Nov 2021 08:18:42 +0000
> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>
> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
> test2, test3, test_arraytypes and test_multidef.

Looks like it was worked around by disabling NumPy support in Vigra, in
commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.

I’m not sure how NumPy is used; is there a preference between these two
options (disabling flaky tests and removing the dependency on NumPy)?

Thanks,
Ludo’.
E
E
Efraim Flashner wrote on 18 Nov 2021 10:17
Re: bug#51890: Vigra: disable more failing tests on core-updates-frozen
(address . 51890@debbugs.gnu.org)
BF396FC9-4391-4001-AFD1-937A5EBCB2C8@flashner.co.il
On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
Toggle quote (21 lines)
>Hi,
>
>Vivien Kraus <vivien@planete-kraus.eu> skribis:
>
>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>> From: Vivien Kraus <vivien@planete-kraus.eu>
>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>
>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>> test2, test3, test_arraytypes and test_multidef.
>
>Looks like it was worked around by disabling NumPy support in Vigra, in
>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>
>I’m not sure how NumPy is used; is there a preference between these two
>options (disabling flaky tests and removing the dependency on NumPy)?
>
>Thanks,
>Ludo’.

It looked to me like vigra was limping along and numpy compatibility was being dragged along by patches here and there. When I built the dependencies of vigra nothing failed to build. I'm definitely not against reinstating support for numpy but I'm not sure just disabling the tests is the right way.

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
M
M
Maxim Cournoyer wrote on 18 Nov 2021 14:18
Re: bug#51890: Vigra: disable more failing tests on core-updates-frozen
(name . Efraim Flashner)(address . efraim@flashner.co.il)
87czmxhaa9.fsf_-_@gmail.com
Hello,

Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (28 lines)
> On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>>Hi,
>>
>>Vivien Kraus <vivien@planete-kraus.eu> skribis:
>>
>>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>>> From: Vivien Kraus <vivien@planete-kraus.eu>
>>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>>
>>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>>> test2, test3, test_arraytypes and test_multidef.
>>
>>Looks like it was worked around by disabling NumPy support in Vigra, in
>>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>>
>>I’m not sure how NumPy is used; is there a preference between these two
>>options (disabling flaky tests and removing the dependency on NumPy)?
>>
>>Thanks,
>>Ludo’.
>
> It looked to me like vigra was limping along and numpy compatibility
> was being dragged along by patches here and there. When I built the
> dependencies of vigra nothing failed to build. I'm definitely not
> against reinstating support for numpy but I'm not sure just disabling
> the tests is the right way.

I know nothing about vigra, but judging from its description "[...] It
is an image processing and analysis library that puts its main emphasis
on customizable algorithms and data structures. [...]" it seems it'd
probably make good use of Numpy? Not sure what are the consequences of
doing without; perhaps efficiency.

Thanks,

Maxim
L
L
Ludovic Courtès wrote on 9 Dec 2021 16:37
control message for bug #51890
(address . control@debbugs.gnu.org)
87ee6lg574.fsf@gnu.org
close 51890
quit
?