[PATCH] Shepherd: Add respawn-limit paramter to service class.

  • Done
  • quality assurance status badge
Details
3 participants
  • Ludovic Courtès
  • Mathieu Othacehe
  • Ryan Sundberg
Owner
unassigned
Submitted by
Ryan Sundberg
Severity
normal

Debbugs page

Ryan Sundberg wrote 3 years ago
(address . guix-patches@gnu.org)
dd8a192a-79ff-ba4e-977c-82b39ab4c5db@arctype.co
Hello Guix devs,

This patch to GNU Shepherd removes the hard-coded respawn limit and
makes it a configurable option.
The respawn limit works generally the same way as before, allowing N
respawns in M seconds:

#:respawn-limit '(N . M)

We can disable respawns by setting N to 0, which will abort the service
after the first crash. Likewise, we can always respawn by setting

#:respawn-limit #f


Sincerely,
Ryan Sundberg
Attachment: file
Attachment: OpenPGP_signature
Mathieu Othacehe wrote 3 years ago
(name . Ryan Sundberg)(address . ryan@arctype.co)(address . 50717@debbugs.gnu.org)
878rzdoy0n.fsf@gnu.org
Hello Ryan,

Toggle quote (5 lines)
> We can disable respawns by setting N to 0, which will abort the service
> after the first crash. Likewise, we can always respawn by setting
>
> #:respawn-limit #f

Looks nice, thanks for the patch. I have the following error while
applying it though:

Toggle snippet (4 lines)
Applying: service: Add respawn-limit paramter to the service class.
error: corrupt patch at line 52

Could you try to send it with git-send-email?

It would also be nice to add unit tests dedicated to this new feature and
update the documentation.

Thanks,

Mathieu
Ludovic Courtès wrote 1 years ago
Re: [bug#50717] [PATCH] Shepherd: Add respawn-limit paramter to service class.
(name . Ryan Sundberg)(address . ryan@arctype.co)(address . 50717-done@debbugs.gnu.org)
87il4bgye8.fsf@gnu.org
Hi Ryan,

Ryan Sundberg <ryan@arctype.co> skribis:

Toggle quote (7 lines)
> This patch to GNU Shepherd removes the hard-coded respawn limit and
> makes it a configurable option.
> The respawn limit works generally the same way as before, allowing N
> respawns in M seconds:
>
> #:respawn-limit '(N . M)

This is was eventually implemented (independently, oops!) in commit
93baa23baee1e0c62d46d9fd041fc1dabc081f26 (June 2023), which made it in
0.10.2.

Thanks,
Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 50717@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 50717
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help