[PATCH] gnu: thunar: Update to 4.17.1

  • Done
  • quality assurance status badge
Details
3 participants
  • André A. Gomes
  • Ludovic Courtès
  • Michael Rohleder
Owner
unassigned
Submitted by
André A. Gomes
Severity
normal
A
A
André A. Gomes wrote on 6 Sep 2021 21:47
(address . guix-patches@gnu.org)
871r614hbi.fsf@gmail.com
From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone@gmail.com>
Date: Mon, 6 Sep 2021 22:37:12 +0300
Subject: [PATCH] gnu: thunar: Update to 4.17.1.

* gnu/packages/xfce.scm (thunar): Update to 4.17.1.
[inputs]: Add gvfs.
---
gnu/packages/xfce.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (40 lines)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c506f5e463..b40c5ce70a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2020 Jonathan Brielmaier <jonathan.brielmaier@web.de>
;;; Copyright © 2020, 2021 Michael Rohleder <mike@rohleder.de>
;;; Copyright © 2021 Brendan Tildesley <mail@brendan.scot>
+;;; Copyright © 2021 André A. Gomes <andremegafone@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -781,7 +782,7 @@ like appearance, display, keyboard and mouse settings.")
(define-public thunar
(package
(name "thunar")
- (version "4.16.8")
+ (version "4.17.1")
(source (origin
(method url-fetch)
(uri (string-append "https://archive.xfce.org/src/xfce/"
@@ -789,7 +790,7 @@ like appearance, display, keyboard and mouse settings.")
"thunar-" version ".tar.bz2"))
(sha256
(base32
- "159ircj0mahx54fqsr3l3ynk690zlpc6ar5pnyhhpk90s8la5303"))))
+ "0w957z22asd7dgchib99013csr628pvakagsqg38w6zhsmb9dy9k"))))
(build-system gnu-build-system)
(native-inputs
`(("pkg-config" ,pkg-config)
@@ -797,6 +798,7 @@ like appearance, display, keyboard and mouse settings.")
(inputs
`(("exo" ,exo)
("gobject-introspection" ,gobject-introspection)
+ ("gvfs" ,gvfs)
("libexif" ,libexif)
("libgudev" ,libgudev)
("libnotify" ,libnotify)
--
2.33.0
L
L
Ludovic Courtès wrote on 15 Sep 2021 16:51
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 50438-done@debbugs.gnu.org)
87o88t51tt.fsf@gnu.org
Hi,

André A. Gomes <andremegafone@gmail.com> skribis:

Toggle quote (8 lines)
>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone@gmail.com>
> Date: Mon, 6 Sep 2021 22:37:12 +0300
> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>
> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
> [inputs]: Add gvfs.

Applied, thanks!

Ludo’.
Closed
M
M
Michael Rohleder wrote on 15 Sep 2021 17:10
(address . 50438@debbugs.gnu.org)
87k0jhg9ho.fsf@rohleder.de
Ludovic Courtès <ludo@gnu.org> writes:
Toggle quote (11 lines)
>>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone@gmail.com>
>> Date: Mon, 6 Sep 2021 22:37:12 +0300
>> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>>
>> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
>> [inputs]: Add gvfs.
>
> Applied, thanks!
>

I think, 4.17 is the development branch of xfce/thunar, no?


--
Sind Sie auch vom Vögeln wachgeworden?
Und verwechseln Sie auch manchmal Dativ und Akkusativ?
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmFCDPMRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyXaeQgAj+3AlHNLdNvNWvJHSx/gEypx695QGKnj
u2FOS/OKZKd7YeFjSE2Ki5UIfJVpS6zf1iRHbbHKW+99vjjCbqQ7VVtL7gt8XKS0
4PFU6f12PGoetUG31ajJanFpQyAtZZ4E8JCUFoEyptmrVvwS8/r3r4/3BGKf0uBK
pH/dvc63WTcIdeYm2TbbS39ysPiraKsz2gQMxL2rL/u4l3rKe3v4hLA/4HIXoQiG
hAsc8XusStRty42QI9vE4NkNZ+dx/OWtsW9e3U5tfNY2V2IlUEEjYYPZlKt4QjwU
G7bAw2r/quhCSL/tT0L3d4CWPbO/UAqA+MKrT5cvfBoniyyAaSddEw==
=JvEx
-----END PGP SIGNATURE-----

A
A
André A. Gomes wrote on 15 Sep 2021 20:48
(name . Michael Rohleder)(address . mike@rohleder.de)
87czp93ca5.fsf@gmail.com
Michael Rohleder <mike@rohleder.de> writes:

Toggle quote (16 lines)
> Ludovic Courtès <ludo@gnu.org> writes:
>>>>From f8c178fdff2fd8de69a7a09777d2b7588b6fe5de Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?Andr=C3=A9=20A=2E=20Gomes?= <andremegafone@gmail.com>
>>> Date: Mon, 6 Sep 2021 22:37:12 +0300
>>> Subject: [PATCH] gnu: thunar: Update to 4.17.1.
>>>
>>> * gnu/packages/xfce.scm (thunar): Update to 4.17.1.
>>> [inputs]: Add gvfs.
>>
>> Applied, thanks!
>>
>
> I think, 4.17 is the development branch of xfce/thunar, no?
>
> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)

Oh, I wasn't aware of this. I was confused myself, so I checked thunar's
wikipedia page that states that the stable release is 4.17.1. The
latest is 4.17.5 so I thought it made sense.


My goal with this patch was mainly to include gvfs. I don't really care
about the version.

How shall I proceed? Thanks.


--
André A. Gomes
"Free Thought, Free World"
M
M
Michael Rohleder wrote on 15 Sep 2021 22:22
(name . André A. Gomes)(address . andremegafone@gmail.com)
87a6kdfv1y.fsf@rohleder.de
André A. Gomes <andremegafone@gmail.com> writes:
Toggle quote (10 lines)
>> I think, 4.17 is the development branch of xfce/thunar, no?
>>
>> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)
>
> Oh, I wasn't aware of this. I was confused myself, so I checked thunar's
> wikipedia page that states that the stable release is 4.17.1. The
> latest is 4.17.5 so I thought it made sense.
>
> https://en.wikipedia.org/wiki/Thunar

xfce has a release model like this:

Currently, this means 4.16 is the released version, 4.17 is the
development version (which becomes 4.18).

I think wikipedia is wrong here, because the announcement of 4.17.5
says:

...
Release notes for 4.17.5
========================
[Please note that this is a development release.]
...

Toggle quote (5 lines)
> My goal with this patch was mainly to include gvfs. I don't really care
> about the version.
>
> How shall I proceed? Thanks.

Make a patch that just does that.
Maybe, it could be useful to mention the reason for the inclusion of
gvfs, but I'm not sure.


Regards
mike
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmFCVgkRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyVa9wf/VOSSCUWJqCXAW7TZxXUQBQFCAjVYAG2G
AIAflk6o4bRabaFoOKOBLfEUFUsArtOhZ7VViaGyvwtv+AF6cGWP5EQkjgsQfR9d
JcRUANjB5zBDdgDnCYQcdSpkKhsgEPMWHUb9Wr3QlXRCfiuF7dpj+zESjlqxEqNL
TBxoh6kgzXVOyc18A1pte7K3xE8XbdfhChPmPuULoh0tjccbFKaqeLJpcybg5v/Z
5q01y2IqsxFPaNEEpa1xf4YIco7NjwzAMp3nN11XvP0ZfphxpGu4ga5ApFAHLTo+
rUpzwgJc3MypkK9BbMelnbAYXJtcMDjmu7YmmJriaQoTXEe81+N71A==
=+QJG
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 16 Sep 2021 21:59
(name . Michael Rohleder)(address . mike@rohleder.de)
87pmt8z3z8.fsf@gnu.org
Hi,

Michael Rohleder <mike@rohleder.de> skribis:

Toggle quote (5 lines)
> André A. Gomes <andremegafone@gmail.com> writes:
>>> I think, 4.17 is the development branch of xfce/thunar, no?
>>>
>>> (https://lists.nongnu.org/archive/html/guix-patches/2021-02/msg00839.html)

Oh sorry, I had forgotten about that. :-/

I’ll revert the upgrade and keep the gvfs addition.

Thanks,
Ludo’.
?