[PATCH 0/1] Add python-flask-debugtoolbar.

Open

Details

4 participants

Arun Isaac
Munyoki Kilyungi
jgart
BonfaceKilz

Owner: unassigned

Submitted by: BonfaceKilz

Severity: normal

BonfaceKilz wrote on 16 Aug 2021 11:47

Recipients:(address . guix-patches@gnu.org)(name . BonfaceKilz)(address . me@bonfacemunyoki.com)

Message-ID:20210816094722.9883-1-me@bonfacemunyoki.com

Hi. Find attach a patch that adds python-flask-debugtoolbar to GUIX.

BonfaceKilz (1):

gnu: Add python-flask-debugtoolbar.

gnu/packages/python-web.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

2.31.1

BonfaceKilz wrote on 16 Aug 2021 11:50

[PATCH 1/1] gnu: Add python-flask-debugtoolbar.

Recipients:(address . 50076@debbugs.gnu.org)(name . BonfaceKilz)(address . me@bonfacemunyoki.com)

Message-ID:20210816095059.10480-1-me@bonfacemunyoki.com

* gnu/packages/python-web.scm (python-flask-debugtoolbar): New variable.

---

gnu/packages/python-web.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

Toggle diff (39 lines)diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 32b4aa4bf0..c8f0ab3940 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -3005,6 +3005,32 @@ and Jinja2 template engine.  It is called a micro framework because it does not
 presume or force a developer to use a particular tool or library.")
     (license license:bsd-3)))
 
+(define-public python-flask-debugtoolbar
+  (package
+  (name "python-flask-debugtoolbar")
+  (version "0.11.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "Flask-DebugToolbar" version))
+      (sha256
+        (base32
+          "1d5asdnk8bmh6m46pzg3i7677cjgdm9mlm3wcpk19q7dak9pjkiw"))))
+  (build-system python-build-system)
+  (propagated-inputs
+    `(("python-blinker" ,python-blinker)
+      ("python-flask" ,python-flask)
+      ("python-itsdangerous" ,python-itsdangerous)
+      ("python-werkzeug" ,python-werkzeug)))
+  (home-page
+   "https://flask-debugtoolbar.readthedocs.io/")
+  (synopsis
+    "A toolbar overlay for debugging Flask applications.")
+  (description
+    "This extension adds a toolbar overlay to Flask applications containing
+useful information for debugging.")
+  (license license:bsd-3)))
+
 (define-public python-flask-wtf
   (package
     (name "python-flask-wtf")
-- 
2.31.1

Arun Isaac wrote on 23 Aug 2021 22:53

Recipients:(name . BonfaceKilz)(address . me@bonfacemunyoki.com)(address . 50076@debbugs.gnu.org)

Message-ID:87tujfrihc.fsf@systemreboot.net

Hi Bonface,

Thanks for contributing! :-) Some feedback follows.

1. Please add a copyright header.

2. Could you try packaging the tests? I think tests use

pytest. Currently, no tests are run during the check phase.

Toggle quote (3 lines)

> + (synopsis

> + "A toolbar overlay for debugging Flask applications.")

3. Could you remove the article "A" at the beginning, and the period at

the end? Quoting from our manual at "(guix) Synopses and Descriptions":

Toggle snippet (6 lines)

Synopses must start with a capital letter and must not end with a

period. They must not start with “a” or “the”, which usually does not

bring anything; for instance, prefer “File-frobbing tool” over “A tool

that frobs files”.

Toggle quote (4 lines)

> + (description

> + "This extension adds a toolbar overlay to Flask applications containing

> +useful information for debugging.")

4. Finally, a nitpick: It would be more consistent with the rest of Guix

if the synopsis and description started on the same line instead of on

the next. So, something like this:

Toggle snippet (4 lines)

(description "This extension adds a toolbar overlay to Flask applications

containing useful information for debugging.")

Thanks!

Arun

Bonface Munyoki K. wrote on 27 Aug 2021 13:14

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 50076@debbugs.gnu.org)

Message-ID:86r1eff8cb.fsf@bonfacemunyoki.com

Arun Isaac <arunisaac@systemreboot.net> anaandika:

Toggle quote (5 lines)> Hi Bonface,
>
> Thanks for contributing! :-) Some feedback follows.
>
> 1. Please add a copyright header.

Cool. Thanks for the gentle reminder.

Toggle quote (3 lines)

> 2. Could you try packaging the tests? I think tests use

> pytest. Currently, no tests are run during the check phase.

Cool. I'll try to work out how to do that.

Toggle quote (23 lines)>> +  (synopsis
>> +    "A toolbar overlay for debugging Flask applications.")
>
> 3. Could you remove the article "A" at the beginning, and the period at
> the end? Quoting from our manual at "(guix) Synopses and Descriptions":
>
>    Synopses must start with a capital letter and must not end with a
> period.  They must not start with “a” or “the”, which usually does not
> bring anything; for instance, prefer “File-frobbing tool” over “A tool
> that frobs files”.
>
>
>> +  (description
>> +    "This extension adds a toolbar overlay to Flask applications containing
>> +useful information for debugging.")
>
> 4. Finally, a nitpick: It would be more consistent with the rest of Guix
> if the synopsis and description started on the same line instead of on
> the next. So, something like this:
>
>     (description "This extension adds a toolbar overlay to Flask applications
> containing useful information for debugging.")
>

Much thanks for the above suggestions! I'll work
on this and submit a revised patch over the
weekend.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: https://upbookclub.com | Twitter: @BonfaceKilz

jgart wrote on 19 May 2023 06:50

Re: [PATCH 0/1] Add python-flask-debugtoolbar.

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)

Message-ID:3f6848b904e82e3081743ef119a3b7fb@dismail.de

Hi Bonz,

Are you still interested in picking this issue up again?

The only problem I see with this package is that it vendors 63 javascript files including dependencies like jquery.

Hi Arun, is this a non issue for upstream guix or what should we do here?

What is our current policy regarding jquery?

all best,

jgart

Munyoki Kilyungi wrote on 22 May 2023 09:28

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)

Message-ID:87mt1w7rlc.fsf@saitama.mail-host-address-is-not-set

"jgart" <jgart@dismail.de> aliandika:

Toggle quote (4 lines)

> Hi Bonz,

> Are you still interested in picking this issue up again?

Sure no problem. I'll try looking at this later

tonight (EAT). Thanks for the follow-up.

Toggle quote (10 lines)> The only problem I see with this package is that it vendors 63 javascript files including dependencies like jquery.
>
> Hi Arun, is this a non issue for upstream guix or what should we do here?
>
> What is our current policy regarding jquery?
>
> all best,
>
> jgart

-- 
(Life is like a pencil that will surely run out,
    but will leave the beautiful writing of life.)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
    (hkp://keys.openpgp.org))

Arun Isaac wrote on 24 May 2023 20:07

Recipients:

Message-ID:878rddzjqb.fsf@systemreboot.net

Toggle quote (6 lines)

> The only problem I see with this package is that it vendors 63

> javascript files including dependencies like jquery.

> Hi Arun, is this a non issue for upstream guix or what should we do

> here?

As long as these javascript files are actual source and are not minified
source, this should be fine. Minified source is considered to be a
binary. This is the precedent set in packages such as js-mathjax.

jgart wrote on 29 Jun 08:55 +0200

Recipients:(address . 50076@debbugs.gnu.org)

Message-ID:871q4gnspq.fsf@dismail.de

Hi all,

This issue is pretty stale by now. Does anyone want to still work on

it?

If not, I recommend for us to close it and reopen when actively working

on it.

WDYT?

all the best,

jgart

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 50076@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 50076

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date