[PATCH 00/18] Remove Python 2 packages possibly added for Python 2 MediaGoblin.

The following packages were once dependencies of Python 2 MediaGoblin, but are

no longer used by MediaGoblin or any other Guix package. There may well be

people using these for non-Guix work, so I'll defer to maintainers as to

whether it's reasonable to remove them - I'm just trying to clean up after

MediaGoblin.

python2-openid-teams and python2-openid-cla weren't used by MediaGoblin

directly, but seem closely related to the removed python2-openid package and

are similarly not used by other Guix packages.

python2-psycopg2 is not removed here because although it's likely still a

popular Guix package, so should perhaps be one of the last Python 2 packages

to go.

Ben Sturmfels (18):

gnu: Remove python2-exif-read.

gnu: Remove python2-pyld.

gnu: Remove python2-jsonschema.

gnu: Remove python2-unidecode.

gnu: Remove python2-itsdangerous.

gnu: Remove python2-feedgenerator.

gnu: Remove python2-markdown.

gnu: Remove python2-configobj.

gnu: Remove python2-waitress.

gnu: Remove python2-email-validator.

gnu: Remove python2-py-bcrypt.

gnu: Remove python2-oauthlib.

gnu: Remove python2-wtforms.

gnu: Remove python2-pastescript.

gnu: Remove python2-openid-teams.

gnu: Remove python2-openid-cla.

gnu: Remove python2-openid.

gnu: Remove python2-celery.

gnu/packages/python-crypto.scm | 3 --

gnu/packages/python-web.scm | 39 ----------------------

gnu/packages/python-xyz.scm | 60 ++--------------------------------

3 files changed, 2 insertions(+), 100 deletions(-)

--

2.32.0

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 11 +----------

1 file changed, 1 insertion(+), 10 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-crypto.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 24 ------------------------

1 file changed, 24 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 11 +----------

1 file changed, 1 insertion(+), 10 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 14 --------------

1 file changed, 14 deletions(-)

Remove Python 2 leaf package.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

This is an additional dependency that has since been removed from

MediaGoblin, which is why I didn't catch in the initial patch set.

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Upon investigation, the following were added by cwebber or dthompson, so likely related to MediaGoblin:

python2-exif-read

python2-pyld

python2-jsonschema

python2-unidecode

python2-itsdangerous

python2-feedgenerator

python2-waitress

python2-oauthlib

python2-wtforms

python2-pastescript

python2-celery

The following were added by others, so probably had uses other than MediaGoblin:

python2-markdown

python2-configobj

python2-email-validator

python2-py-bcrypt

python2-openid-teams

python2-openid-cla

python2-openid

python2-celery

Of all the above only python2-jsonschema is failing to build.

Now that I think about it, I'm not sure that this ad-hoc approach to

removing Python 2 deps is all that useful. Maybe a systemic approach is

needed eg. drop all broken Python 2 packages and announce a future date

to drop all non-broken Python 2 packages.

Regards,

Ben

Hi,

On Tue, 31 Aug 2021 at 11:08, Ben Sturmfels via Guix-patches via <guix-patches@gnu.org> wrote:

This is more or less the plan. Although there is no fixed future date

to drop all the non-broken Python 2 packages. :-)

For instance #49272 remove 10 Python 2 packages and to find them:

then I pick only the leaf packages using “guix refresh -l”. The

dependency graph needs some care because sometimes the graph is

rewritten. For example,

$ guix refresh -l python2-plastid

No dependents other than itself: python2-plastid@0.4.8

Then, let try to locally build it in case something wrong happened on

the CI. Note that the missing is checked on Berlin but the build uses

both (Berlin and Bordeaux):

$ guix build python2-plastid --no-grafts

Or in some cases, it is a leaf package broken because another ’python2-’

package is broken. Here, ’python2-pandas’. In this case, it

depends. ;-) Try to fix ’python2-pandas’ because:

$ guix refresh -l python2-pandas

Building the following 7 packages would ensure 12 dependent packages are rebuilt: fio@3.27 python2-pybedtools@0.8.2 python2-plastid@0.4.8 python2-biom-format@2.1.7 python2-warpedlmm@0.21 poretools@0.6.0-1.e426b1f ribodiff@0.2.2

or simply remove all the dependants in the same patch set. Be careful,

the removal needs the correct order. :-)

Personally, I tend to remove leaf package brokens becaus they do not

build themselves and not because of broken dependencies. For instance,

in this list (from Guix a9eb969):

I would remove only the package ’ptpython2’. All the others depend on

’python2-pandas’ and remove ’python2-pandas’ means also remove ’fio’,

’poretools’ or ’ribodiff’. And I am not enough qualified to have an

opinion if it is worth to fix them. Therefore, I queue these packages

in my TODO list and then I revisit months later: if there are still

broken and no issue is open, it means they do not worth and can be

removed.

HTH.

All the best,

simon

On Tue, 31 Aug 2021, zimoun wrote:

Whoops! Thanks Simon, I had been mistakenly just grepping the sources to

find dependencies, so my earlier claims of packages being unused were

wrong.

Only the following have no dependencies (according to `guix refresh

-l`):

python2-exif-read

python2-pyld

python2-itsdangerous

python2-feedgenerator

python2-wtforms

python2-pastescript

python2-celery

python2-configobj

python2-email-validator

python2-openid-teams

python2-openid-cla

python2-openid

python2-celery

python2-translitcodec

These DO have dependencies, so should NOT be removed:

python2-markdown

python2-py-bcrypt

python2-waitress

python2-oauthlib

Regards,

Ben

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

The following patchset removes these Python 2 leaf package and replaces all

previous patches. Of this list, the following were added by cwebber or

dthompson, so highly likely for MediaGoblin:

python2-pyld

python2-itsdangerous

python2-feedgenerator

python2-wtforms

python2-pastescript

python2-translitcodec

These were added by other people:

python2-configobj

python2-email-validator

python2-openid-teams

python2-openid-cla

python2-openid

python2-celery

This time I've *properly* confirmed that these are indeed leaf packages:

$ guix refresh -l python2-pyld

No dependents other than itself: python2-pyld@1.0.5

$ guix refresh -l python2-itsdangerous

No dependents other than itself: python2-itsdangerous@1.1.0

$ guix refresh -l python2-feedgenerator

No dependents other than itself: python2-feedgenerator@1.9

$ guix refresh -l python2-configobj

No dependents other than itself: python2-configobj@5.0.6

$ guix refresh -l python2-email-validator

No dependents other than itself: python2-email-validator@1.0.2

$ guix refresh -l python2-wtforms

No dependents other than itself: python2-wtforms@2.1

$ guix refresh -l python2-pastescript

No dependents other than itself: python2-pastescript@2.0.2

$ guix refresh -l python2-openid-teams

No dependents other than itself: python2-openid-teams@1.1

$ guix refresh -l python2-openid-cla

No dependents other than itself: python2-openid-cla@1.2

$ guix refresh -l python2-openid

No dependents other than itself: python2-openid@2.2.5

$ guix refresh -l python2-celery

No dependents other than itself: python2-celery@4.2.1

Ben Sturmfels (12):

gnu: Remove python2-pyld.

gnu: Remove python2-itsdangerous.

gnu: Remove python2-feedgenerator.

gnu: Remove python2-configobj.

gnu: Remove python2-email-validator.

gnu: Remove python2-wtforms.

gnu: Remove python2-pastescript.

gnu: Remove python2-openid-teams.

gnu: Remove python2-openid-cla.

gnu: Remove python2-openid.

gnu: Remove python2-celery.

gnu: Remove python2-translitcodec.

gnu/packages/python-web.scm | 36 ------------------------------------

gnu/packages/python-xyz.scm | 29 +----------------------------

2 files changed, 1 insertion(+), 64 deletions(-)

--

2.33.0

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 24 ------------------------

1 file changed, 24 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package.

---

gnu/packages/python-web.scm | 3 ---

1 file changed, 3 deletions(-)

Remove Python 2 leaf package possibly added for Python 2 MediaGoblin.

---

gnu/packages/python-xyz.scm | 11 +----------

1 file changed, 1 insertion(+), 10 deletions(-)

Hi,

All these packages were removed last year as part of a larger effort to

remove python2 packages. I will close this issue then.

Vinicius