Fwd: issue website creates invalid comment expectations

  • Open
  • quality assurance status badge
Details
6 participants
  • François-René Rideau
  • Felix Lechner
  • John Kehayias
  • Ludovic Courtès
  • Maxim Cournoyer
  • Maxime Devos
Owner
unassigned
Submitted by
François-René Rideau
Severity
normal
Merged with

Debbugs page

François-René Rideau wrote 4 years ago
(address . bug-guix@gnu.org)
CAOhKva2gNhs+fZy=ngb06bn51dTH8JvL4DLe-Ks5A+MPd71cpw@mail.gmail.com
When viewing an issue on the website https://issues.guix.gnu.org/the
web interface allows you to post a comment, what more without
authentication. Unfortunately, I am told by ropstat and podiki[m] on
irc.libera.chat #guix that web comments don't actually work in their
experience. If this option cannot be fixed in a timely fashion, it
should not be offered at all. Otherwise, it only creates deep
frustration in users, and maybe even lost comments depending on what
client they use.

The same web interface also, correctly, invites users to instead send
mail to <bug-number>@debbugs.gnu.org — however, the same helpful IRC
users tell me that the mail is manually reviewed by a human moderator
and may take up to a day to show up. This as such is perfectly fine,
but does deserve mention as part of the same message on the web
interface, otherwise it will once again create wrong expectations from
users, frustration, messages sent multiple times, and more work for
both users and moderators.

PS: also, several of my attempts to post comments via the web form
failed with an unhelpful error message when posting "There was an
error submitting your comment!". At some point I conjectured that it
was due to my using an accent in my name "Faré", but one of my
attempts with that name did end up with "Your comment has been
submitted!". This is moot considering the above issue, but may become
important if the resolution is to fix web comments.
John Kehayias wrote 4 years ago
(name . 49968@debbugs.gnu.org)(address . 49968@debbugs.gnu.org)
hzts8z2GC_D5YeA13ZndhmoZGhhimirkS2kJwoWfT5e7ULYgUsE5hErZoldFbWXUeqbGZ76XSWDST-_7-08Z9kCdsWO6wyKn482PXCR9AtY=@protonmail.com
(I think the bug title should be "comments sent via issues.guix.gnu.org disappear" as they seem to get swallowed by the server)

I sent a comment just a few minutes ago via the webform, that got the message that was successful. I'll check back to see if it appears later, but have not had it work in the past.

Hope this helps if anyone is checking some logs for what is happening with the web comment suggestion.
Maxime Devos wrote 4 years ago
(name . François-René Rideau)(address . fare@mukn.io)(address . 49968@debbugs.gnu.org)
5a811d2835b3335afde69029ddb0eec30f41e7f4.camel@telenet.be
Toggle quote (2 lines)
> [... mumi ‘send comment’ interface doesn't work ...]

Some time ago, I received a copy of the logs and Ludovic
and I found out what causes comments to be swallowed:
https://issues.guix.gnu.org/49295. Ludovic has a suggestion
on how to fix it.

The source code is at
if anyone is interested in fixing it, or just disabling
the comment interface.

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYRKboRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ozUAQCxPdtRs53XP3BXgEwZQozVUECy
MikiBPV9bHVh4nknbwD/ZwqEVpC2/ziSV5YExsbi3/oDyimveR9lD8NPJ42s7AE=
=hF/u
-----END PGP SIGNATURE-----


John Kehayias wrote 4 years ago
Re: Fwd: issue website creates invalid comment expectations
(name . 49968@debbugs.gnu.org)(address . 49968@debbugs.gnu.org)
p2AOQOo0Zs-NpZBBMmpELaWOBPmNHErH8WwXejMXAQmQ-hbgq1B8Edw1Xv715Ba_jJOdvnuvbZVxEYtTohjXEUY64GcSZ1O0Aw7a-5GUpEE=@protonmail.com
Hi Maxime,

I took a quick look, but I'm not seeing how the proposed fix works: there is already that line for defining mu-debug in the only file that uses mu-message-send...? (Perhaps this should be sent to that original issue, I can send it again there if that is helpful.)

If there is not a relatively quick fix, I would vote for disabling the comment submission until it can be fixed. Otherwise, we're losing comments with no indication to the submitter.

John
Maxime Devos wrote 4 years ago
Re: bug#49968: Fwd: issue website creates invalid comment expectations
(name . John Kehayias)(address . john.kehayias@protonmail.com)(name . 49968@debbugs.gnu.org)(address . 49968@debbugs.gnu.org)(address . 49295@debbugs.gnu.org)
93b5944e604258145ff800329382806217a278d7.camel@telenet.be
John Kehayias via Bug reports for GNU Guix schreef op di 10-08-2021 om 17:46 [+0000]:
Toggle quote (7 lines)
> Hi Maxime,
>
> I took a quick look, but I'm not seeing how the proposed fix works: there is already
> that line for defining mu-debug in the only file that uses mu-message-send...?
> (Perhaps this should be sent to that original issue, I can send it again there if that
> is helpful.)

‘the current module’ is whatever (current-module) evaluates to.
It is not necessarily the module wherein 'mu-message-send' is used.
IIUC, every time a (define-module ([...])) form is encountered,
(current-module) is set to [...], or something like that (details
might be a little different). It works for stand-alone scripts and
in the REPL I guess, but otherwise it's a very cumbersome interface.

This interface should be changed (in mailutils) IMO.

Toggle quote (5 lines)
>
> If there is not a relatively quick fix, I would vote for disabling the comment
> submission until it can be fixed. Otherwise, we're losing comments with no indication
> to the submitter.

nckx has done that recently. Pages on https://issues.guix.gnu.org/NNN
now end with ‘Commenting via the web interface is currently disabled.’.

Greetings,
Ma
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYRwzJxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oNAAPwLpdr8KUfRd5KppISaepG80WGu
uYWUmcVA4E5ZG+VaDwD/UfRAvdbPkmLPmbUqwr2aJfWtulRnfDZ3u0/DVBk+fQQ=
=ql7V
-----END PGP SIGNATURE-----


Ludovic Courtès wrote 4 years ago
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 49968@debbugs.gnu.org)(name . François-René Rideau)(address . fare@mukn.io)
87pmts75r5.fsf@gnu.org
Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (10 lines)
> Some time ago, I received a copy of the logs and Ludovic
> and I found out what causes comments to be swallowed:
> <https://issues.guix.gnu.org/49295>. Ludovic has a suggestion
> on how to fix it.
>
> The source code is at
> <https://git.elephly.net/gitweb.cgi?p=software/mumi.git>,
> if anyone is interested in fixing it, or just disabling
> the comment interface.

Tobias disabled the comment interface a couple of weeks ago:


Ludo’.
Ludovic Courtès wrote 4 years ago
control message for bug #49295
(address . control@debbugs.gnu.org)
87o89c6y9y.fsf@gnu.org
merge 49295 49968
quit
Felix Lechner wrote 1 years ago
(no subject)
(address . control@debbugs.gnu.org)
87h6ii6d58.fsf@lease-up.com
reassign 65858 mumi
reassign 65809 mumi
reassign 49295 mumi
reassign 64833 mumi
reassign 54204 mumi
reassign 68920 mumi
reassign 55765 mumi
reassign 65923 mumi
reassign 63507 mumi
reassign 60226 mumi
reassign 63936 mumi
reassign 60951 mumi
reassign 66027 mumi
thanks
Maxim Cournoyer wrote 5 days ago
Re: bug#49968: Fwd: issue website creates invalid comment expectations
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 49295@debbugs.gnu.org)(address . 49968@debbugs.gnu.org)(name . Maxime Devos)(address . maximedevos@telenet.be)
871pv6viyb.fsf_-_@gmail.com
Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (4 lines)
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> skribis:

[...]

Toggle quote (7 lines)
> I pushed a patch to fix this in Mailutils in commit
> a5fb1f4eeb7563bd8519660c452a45afecd296c6, and also submitted it
> upstream.
>
> I guess we could try re-enabling the comments via the Web interface of
> mumi?

Since this feature has been broken repeatedly with nefarious
consequences (silently disappears user reported issues!), I think we
should come up with a test for it, if we want to re-enable it, so that
we can ensure it keeps working in the future.

--
Thanks,
Maxim
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 49968@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 49968
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help