[PATCH 00/29] gnu: Add ocaml-cohttp-lwt-unix.

Hi,

These patches add ocaml-cohttp-lwt-unix - an OCaml HTTP library - and dependencies.

Some known rough edges:

- ocaml-eqaf: Tests are disabled for now as I am not able to build ocaml-afl-persistent which is a dependency for ocaml-crowbar which is required to run ocaml-eqaf tests. There is ongoing work to port ocaml-afl-persistent to dune (https://github.com/stedolan/ocaml-afl-persistent/pull/7)with that it should be much easier to build it and enable tests for ocaml-eqaf.

- ocaml-mirage-crypto-ec: Contains generated code from Fiat-Crypto (https://github.com/mit-plv/fiat-crypto).It would be nicer to generate the C code from the Coq sources during Guix build, but that seems like a lot more work.

- ocaml-ca-certs: Tests requie access to `/etc/ssl/certs/*` which does not seem to be available during tests. Any ways to allow this in the test environment?

- ocaml-cohttp-lwt-unix: Seems to require network during tests. Can someone confirm this?

Thanks,

pukkamustard

pukkamustard (29):

gnu: Add ocaml-cohttp-lwt.

gnu: Add ocaml-domain-name.

gnu: Add ocaml-macaddr.

gnu: Add ocaml-ipaddr.

gnu: Add ocaml-ipaddr-cstruct.

gnu: Add ocaml-ipaddr-sexp.

gnu: Add ocaml-conduit.

gnu: Add ocaml-conduit-lwt.

gnu: Add ocaml-eqaf.

gnu: Add ocaml-mirage-crypto.

gnu: Add ocaml-duration.

gnu: Add ocaml-randomconv.

gnu: Add ocaml-mirage-crypto-rng.

gnu: Add ocaml-mirage-crypto-pk.

gnu: Add ocaml-ptime.

gnu: Add ocaml-asn1-combinators.

gnu: Add ocaml-ppx-deriving.

gnu: Add ocaml-ppx-deriving-yojson.

gnu: Add ocaml-mirage-crypto-ec.

gnu: Add ocaml-gmap.

gnu: Add ocaml-pbkdf.

gnu: Add ocaml-cstruct-unix.

gnu: Add ocaml-x509.

gnu: Add ocaml-ca-certs.

gnu: Add ocaml-lwt-log.

gnu: Add ocaml-lwt-ssl.

gnu: Add ocaml-conduit-lwt-unix.

gnu: Add ocaml-magic-mime.

gnu: Add ocaml-cohttp-lwt-unix

gnu/packages/ocaml.scm | 787 ++++++++++++++++++++++++++++++++++++++++-

1 file changed, 786 insertions(+), 1 deletion(-)

--

2.32.0

---

gnu/packages/ocaml.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++

1 file changed, 29 insertions(+)

---

gnu/packages/ocaml.scm | 19 +++++++++++++++++++

1 file changed, 19 insertions(+)

---

gnu/packages/ocaml.scm | 17 +++++++++++++++++

1 file changed, 17 insertions(+)

---

gnu/packages/ocaml.scm | 13 +++++++++++++

1 file changed, 13 insertions(+)

---

gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

---

gnu/packages/ocaml.scm | 33 +++++++++++++++++++++++++++++++++

1 file changed, 33 insertions(+)

---

gnu/packages/ocaml.scm | 20 ++++++++++++++++++++

1 file changed, 20 insertions(+)

---

gnu/packages/ocaml.scm | 32 ++++++++++++++++++++++++++++++++

1 file changed, 32 insertions(+)

---

gnu/packages/ocaml.scm | 18 ++++++++++++++++++

1 file changed, 18 insertions(+)

---

gnu/packages/ocaml.scm | 33 ++++++++++++++++++++++++++++++++-

1 file changed, 32 insertions(+), 1 deletion(-)

---

gnu/packages/ocaml.scm | 31 +++++++++++++++++++++++++++++++

1 file changed, 31 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 35 +++++++++++++++++++++++++++++++++++

1 file changed, 35 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 16 ++++++++++++++++

1 file changed, 16 insertions(+)

---

gnu/packages/ocaml.scm | 42 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 42 insertions(+)

---

gnu/packages/ocaml.scm | 34 ++++++++++++++++++++++++++++++++++

1 file changed, 34 insertions(+)

---

gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++

1 file changed, 29 insertions(+)

---

gnu/packages/ocaml.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 38 ++++++++++++++++++++++++++++++++++++++

1 file changed, 38 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 46 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 46 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)

On Wed, Aug 04 2021, pukkamustard wrote:

I managed to package ‘ocaml-afl-persistent’ with the attached patch,

but it doesn’t respect the ‘--without-tests’ transformation since the

tests are run as part of the build phase.

Thanks for working on this!

On Wed, Aug 04 2021, pukkamustard wrote:

Keep lines at ~80 characters. To keep the synopsis slighty shorter,

maybe

"Cryptographically secure pseudo-random number generator in OCaml"

WDYT?

On Wed, Aug 04 2021, pukkamustard wrote:

Use (string-append "https://erratique.ch..." version ".tbz") to make it

easier to update the package in the future.

What’s the reason for disabling tests?

^

Double spacing. :-)

Not really sure if this sentence is necessary. I think the previous

sentences has hade it pretty clear that it a time and date library.

This two sentences are probably also not necessary for users of the

package. It should be the packager’s job to specify the dependencies. :-)

On Wed, Aug 04 2021, pukkamustard wrote:

The description should contain full sentences, maybe

"This package provides an OCaml implementation of …"

On Wed, Aug 04 2021, pukkamustard wrote:

Keep lines at around ~80 characters (applies to the description too).

Maybe drop the second half of the synopsis, so

"Unix variation of the @code{ocaml-cstruct} library"

The desciption already mentions “access C-like structures directly from

OCaml.”; the synopsis of ‘ocaml-cstruct’ also mentions “Access C

structures via a camlp4 extension”.

WDYT?

On Wed, Aug 04 2021, pukkamustard wrote:

Nit: Use ‘---’ instead of just ‘-’, see the fifth bullet point in “2.1

General Syntactic Conventions” in the Texinfo manual.

On Wed, Aug 04 2021, pukkamustard wrote:

This sentence is a bit weird, maybe

This OCaml library provides helpers for logging; it has been

deprecated in favor of @code{ocaml-logs}.

COPYING[1] say lgpgl2.1+, and “with the additional exemption that

compiling, linking, and/or using OpenSSL is allowed”. You can probably

put a comment that mentions the exemption.

[1]: https://github.com/ocsigen/lwt_log/blob/master/COPYING

On Wed, Aug 04 2021, pukkamustard wrote:

Write a complete sentence, maybe

This OCaml library provides an Lwt-enabled…

?

On Wed, Aug 04 2021, pukkamustard wrote:

Keep lines at ~80 characters. :-)

On Wed, Aug 04 2021, pukkamustard wrote:

^^^^^^^^^^

Nit: @file{mime.types}

On Wed, Aug 04 2021, pukkamustard wrote:

Full sentence, maybe

This OCaml library provides an implementation of an HTTP…

Also, I don’t think Windows support should be mentioned since it’s

not supported by Guix, and it’s non-free software. :-)

Xinglu Chen <public@yoctocell.xyz> writes:

Sounds good! Fixed in V2.

Xinglu Chen <public@yoctocell.xyz> writes:

Done.

Laziness, I guess.. :)

Enabled in V2.

Thanks!

Agree, removed sentence.

Also agree. Removed sentences.

Xinglu Chen <public@yoctocell.xyz> writes:

Changed to: "This package provides an OCaml implementation of

PBKDF 1 and 2 as defined by PKCS#5 using

@code{ocaml-mirage-crypto}."

Note: A version 1.2.0 was released recently. However, it requires

CStruct 6.0.0. I will submit a patch to update ocaml-cstruct and

then ocaml-pbkdf can be updated to 1.2.0.

Xinglu Chen <public@yoctocell.xyz> writes:

I agree. Fixed in V2.

Also fixed a missing double-space in the description.

Xinglu Chen <public@yoctocell.xyz> writes:

Thanks! Done in V2.

Note: This has also been updated to 0.14.1 which requires Cstruct

6.0.0.

Xinglu Chen <public@yoctocell.xyz> writes:

Thanks for the pointers.

Inspired by the package definition for curl, I tried setting

NIX_SSL_CERT_FILE with native-search-paths:

```

(native-search-paths

(list

(search-path-specification

(variable "NIX_SSL_CERT_FILE")

(file-type 'regular)

(separator #f) ;single entry

(files '("/etc/ssl/certs/ca-certificates.crt")))))

```

and adding `nss-certs` to the native-inputs.

However, this does not work. Some observations/questions:

- The NIX_SSL_CERT_FILE does not appear in the

`environment-variables` file when running `guix build -K`. I

would have expected it to be set there.

- `nss-certs` does not provide the `ca-certificates.crt` file. It

is built when creating a profile with the

`ca-certificate-bundle` hook. Is this run when creating a build

environment?

I seem to be not understanding a lot of things about the build

environment ... Pointers very welcome!

Fixed in V2.

Xinglu Chen <public@yoctocell.xyz> writes:

While fixing the package definition, I notice that ocaml-lwt-log

already existed. V2 removes my patch for adding ocaml-lwt-log.

Xinglu Chen <public@yoctocell.xyz> writes:

Perfect. Using description as suggested in V2.

Xinglu Chen <public@yoctocell.xyz> writes:

Thanks! Fixed in V2.

Xinglu Chen <public@yoctocell.xyz> writes:

Fixed in V2.

Xinglu Chen <public@yoctocell.xyz> writes:

:) done and done (in V2).

Xinglu Chen <public@yoctocell.xyz> writes:

Fantastic! With your patch I've added ocaml-crowbar and enabled

tests for ocaml-eqaf in V2.

Tests for ocaml-crowbar are currently disabled as they require

ocaml-xmldiff which requires OCaml 4.12.0.

Thank you for your comments!

V2 follows.

-pukkamustard

---

gnu/packages/ocaml.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++

1 file changed, 29 insertions(+)

---

gnu/packages/ocaml.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++

1 file changed, 29 insertions(+)

---

gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

---

gnu/packages/ocaml.scm | 19 +++++++++++++++++++

1 file changed, 19 insertions(+)

---

gnu/packages/ocaml.scm | 13 +++++++++++++

1 file changed, 13 insertions(+)

---

gnu/packages/ocaml.scm | 17 +++++++++++++++++

1 file changed, 17 insertions(+)

---

gnu/packages/ocaml.scm | 31 +++++++++++++++++++++++++++++++

1 file changed, 31 insertions(+)

---

gnu/packages/ocaml.scm | 18 ++++++++++++++++++

1 file changed, 18 insertions(+)

---

gnu/packages/ocaml.scm | 32 ++++++++++++++++++++++++++++++++

1 file changed, 32 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 34 ++++++++++++++++++++++++++++++++++

1 file changed, 34 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 39 +++++++++++++++++++++++++++++++++++++++

1 file changed, 39 insertions(+)

---

gnu/packages/ocaml.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

---

gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 21 +++++++++++++++++++++

1 file changed, 21 insertions(+)

---

gnu/packages/ocaml.scm | 34 ++++++++++++++++++++++++++++++++++

1 file changed, 34 insertions(+)

---

gnu/packages/ocaml.scm | 35 +++++++++++++++++++++++++++++++++++

1 file changed, 35 insertions(+)

---

gnu/packages/ocaml.scm | 17 +++++++++++++++++

1 file changed, 17 insertions(+)

---

gnu/packages/ocaml.scm | 33 ++++++++++++++++++++++++++++++++-

1 file changed, 32 insertions(+), 1 deletion(-)

---

gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++

1 file changed, 29 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 46 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 46 insertions(+)

---

gnu/packages/ocaml.scm | 38 ++++++++++++++++++++++++++++++++++++++

1 file changed, 38 insertions(+)

---

gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/ocaml.scm | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)

On Sun, Aug 08 2021, pukkamustard wrote:

Maybe the environment variables in ‘native-search-paths’ are only set if

the package is installed in a profile (in ~/.guix-profile/etc/profile)?

I don’t think profile hooks are run in the build environment, so that’s

probably why.

In Nix, the bundle is created during the build phase[1], not sure if we

should do this too.

I think it’s fine to disable tests for now, but it would be great to see

what other people think too.

[1]: https://github.com/nixos/nixpkgs/blob/master/pkgs/data/misc/cacert/default.nix#L53

On Mon, Aug 09 2021, pukkamustard wrote:

The ‘ocaml-uucp’ package hasn’t been packaged yet.

Texinfo formatting:

@uref{http://lcamtuf.coredump.cx/afl/,afl-fuzz}

The rest of v2 looks good. :-)

On Sun, Aug 08 2021, pukkamustard wrote:

Cool, sounds good.

On Mon, Aug 09 2021, pukkamustard wrote: