[PATCH] Update nheko

  • Done
  • quality assurance status badge
Details
3 participants
  • Nicolò Balzarotti
  • Michael Rohleder
  • Nicholas von Klitzing
Owner
unassigned
Submitted by
Nicholas von Klitzing
Severity
normal

Debbugs page

Nicholas von Klitzing wrote 4 years ago
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
BxtV1pQsw3Vqdw0aQT_07IG8r4E53JAY4_ymgkL-IV_DI57gxckOg_vdcxM-StWkR6qEbdWUvEWG7HZfNPiUSvTKRYmbv62XMnQCRSbvJ6s=@nvk.pm
Hello,

Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.

Please be aware this is my first time using guile and submitting a guix patch. Feedback would be appreciated.

Kind regards,
Nicholas
Attachment: 0001-Updated-lmdb-and-switched-to-maintained-fork.patch
Attachment: signature.asc
Nicolò Balzarotti wrote 4 years ago
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(address . 49737@debbugs.gnu.org)
87eebmngta.fsf@guix.i-did-not-set--mail-host-address--so-tickle-me
Nicholas von Klitzing <nicholas@nvk.pm> writes:

Toggle quote (3 lines)
> Hello,
>

Hi,
Toggle quote (3 lines)
> Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
>

Have you taken a look at other patches available on the mailing list?

For example there are bug#46012 and bug#48822 to name a few. It
would be wonderful if somebody could review & merge bug#46012 (which
IIRC it's the best one). Could you compare yours with it and report
back on the other issue?

Thanks,
Nicolò
Nicholas von Klitzing wrote 4 years ago
(name . Nicolò Balzarotti)(address . anothersms@gmail.com)(address . 49737@debbugs.gnu.org)
Ovk2O2E1L5fLcMrZJ052hJLd6n5mf6PKAGqdDbq0r3R8Egft4RhMhVuAiET5QBdSJ0dDYImZBKE9YQ0wPRmMOzBldqpy9dmhBSCZ2f-O7HU=@nvk.pm
Hi Nicolò,

Thanks for informing me of those patches. I had not checked the GNU Bug Tracker.

The patch in bug#46012 looks good to me. It covers everything and more I wanted to address in my patch.


I unfortunately do not have the guix experience to be of much help for the issue relating to the exact specifics how it should be packaged.

What is currently blocking the merge?

Best,
Nicholas
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, July 26th, 2021 at 12:56 AM, Nicolò Balzarotti <anothersms@gmail.com> wrote:

Toggle quote (31 lines)
> Nicholas von Klitzing nicholas@nvk.pm writes:
>

> > Hello,
>

> Hi,
>

> > Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
>

> Have you taken a look at other patches available on the mailing list?
>

> For example there are bug#46012 and bug#48822 to name a few. It
>

> would be wonderful if somebody could review & merge bug#46012 (which
>

> IIRC it's the best one). Could you compare yours with it and report
>

> back on the other issue?
>

> Thanks,
>

> Nicolò
Attachment: publickey - nicholas@nvk.pm - 0xE46F87BA.asc
Attachment: signature.asc
Nicolò Balzarotti wrote 4 years ago
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(address . 49737@debbugs.gnu.org)
87pmv1utz4.fsf@guix.i-did-not-set--mail-host-address--so-tickle-me
Nicholas von Klitzing <nicholas@nvk.pm> writes:

Toggle quote (2 lines)
> Hi Nicolò,
>
Hi

Toggle quote (10 lines)
> Thanks for informing me of those patches. I had not checked the GNU Bug Tracker.
>
> The patch in bug#46012 looks good to me. It covers everything and more I wanted to address in my patch.
>
>
> I unfortunately do not have the guix experience to be of much help for the issue relating to the exact specifics how it should be packaged.
>
> What is currently blocking the merge?
>

I think we just need somebody who has the time to review it, unless
there's something blocking it which I'm not aware of.

Thanks, Nicolò

Toggle quote (37 lines)
> Best,
> Nicholas
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Monday, July 26th, 2021 at 12:56 AM, Nicolò Balzarotti <anothersms@gmail.com> wrote:
>
>> Nicholas von Klitzing nicholas@nvk.pm writes:
>>
>
>> > Hello,
>>
>
>> Hi,
>>
>
>> > Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
>>
>
>> Have you taken a look at other patches available on the mailing list?
>>
>
>> For example there are bug#46012 and bug#48822 to name a few. It
>>
>
>> would be wonderful if somebody could review & merge bug#46012 (which
>>
>
>> IIRC it's the best one). Could you compare yours with it and report
>>
>
>> back on the other issue?
>>
>
>> Thanks,
>>
>
>> Nicolò
Nicholas von Klitzing wrote 4 years ago
(name . Nicolò Balzarotti)(address . anothersms@gmail.com)(address . 49737@debbugs.gnu.org)
XKoTi7diFzbl6JTbI2d8kuigMyYm-X_ZTGpfnbtUShHNi1cT-anKU6KTU7XXYQ3SNBfI3h6gp56Wi2eGFywWvhEdcnX_cSueYICSfUUJXSQ=@nvk.pm
Do you have any estimates for when this patch will be reviewed?

The last update to bug#46012 was over 3 months ago.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, July 29th, 2021 at 3:31 PM, Nicolò Balzarotti <anothersms@gmail.com> wrote:

Toggle quote (73 lines)
> Nicholas von Klitzing nicholas@nvk.pm writes:
>

> > Hi Nicolò,
>

> Hi
>

> > Thanks for informing me of those patches. I had not checked the GNU Bug Tracker.
> >

> > The patch in bug#46012 looks good to me. It covers everything and more I wanted to address in my patch.
> >

> > I unfortunately do not have the guix experience to be of much help for the issue relating to the exact specifics how it should be packaged.
> >

> > What is currently blocking the merge?
>

> I think we just need somebody who has the time to review it, unless
>

> there's something blocking it which I'm not aware of.
>

> Thanks, Nicolò
>

> > Best,
> >

> > Nicholas
> >

> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >

> > On Monday, July 26th, 2021 at 12:56 AM, Nicolò Balzarotti anothersms@gmail.com wrote:
> >

> > > Nicholas von Klitzing nicholas@nvk.pm writes:
> >

> > > > Hello,
> >

> > > Hi,
> >

> > > > Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
> >

> > > Have you taken a look at other patches available on the mailing list?
> >

> > > For example there are bug#46012 and bug#48822 to name a few. It
> >

> > > would be wonderful if somebody could review & merge bug#46012 (which
> >

> > > IIRC it's the best one). Could you compare yours with it and report
> >

> > > back on the other issue?
> >

> > > Thanks,
> >

> > > Nicolò
Attachment: publickey - nicholas@nvk.pm - 0xE46F87BA.asc
Attachment: signature.asc
Nicolò Balzarotti wrote 4 years ago
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(address . 49737@debbugs.gnu.org)
87mtq4uh4f.fsf@guix.i-did-not-set--mail-host-address--so-tickle-me
Nicholas von Klitzing <nicholas@nvk.pm> writes:

Toggle quote (4 lines)
> Do you have any estimates for when this patch will be reviewed?
>
> The last update to bug#46012 was over 3 months ago.
>
You could try reply to that bug, or maybe ask on IRC hoping that someone
is willed to review it and eventually merge :)

Nicolò

Toggle quote (77 lines)
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Thursday, July 29th, 2021 at 3:31 PM, Nicolò Balzarotti <anothersms@gmail.com> wrote:
>
>> Nicholas von Klitzing nicholas@nvk.pm writes:
>>
>
>> > Hi Nicolò,
>>
>
>> Hi
>>
>
>> > Thanks for informing me of those patches. I had not checked the GNU Bug Tracker.
>> >
>
>> > The patch in bug#46012 looks good to me. It covers everything and more I wanted to address in my patch.
>> >
>
>> > I unfortunately do not have the guix experience to be of much help for the issue relating to the exact specifics how it should be packaged.
>> >
>
>> > What is currently blocking the merge?
>>
>
>> I think we just need somebody who has the time to review it, unless
>>
>
>> there's something blocking it which I'm not aware of.
>>
>
>> Thanks, Nicolò
>>
>
>> > Best,
>> >
>
>> > Nicholas
>> >
>
>> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> >
>
>> > On Monday, July 26th, 2021 at 12:56 AM, Nicolò Balzarotti anothersms@gmail.com wrote:
>> >
>
>> > > Nicholas von Klitzing nicholas@nvk.pm writes:
>> >
>
>> > > > Hello,
>> >
>
>> > > Hi,
>> >
>
>> > > > Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
>> >
>
>> > > Have you taken a look at other patches available on the mailing list?
>> >
>
>> > > For example there are bug#46012 and bug#48822 to name a few. It
>> >
>
>> > > would be wonderful if somebody could review & merge bug#46012 (which
>> >
>
>> > > IIRC it's the best one). Could you compare yours with it and report
>> >
>
>> > > back on the other issue?
>> >
>
>> > > Thanks,
>> >
>
>> > > Nicolò
Michael Rohleder wrote 2 years ago
Re: bug#49737: [PATCH] Update nheko
(name . Nicholas von Klitzing)(address . nicholas@nvk.pm)(address . 49737-done@debbugs.gnu.org)(name . Nicolò Balzarotti)(address . anothersms@gmail.com)
87wna56njv.fsf_-_@rohleder.de
I think this can be closed as we have merged #46012 (and several
versions of nheko after that).

--
If builders built buildings the way programmers wrote programs,
then the first woodpecker to come along would destroy civilization.
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmMi5EQRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyWlIAgAjePlQP4876muP6JFN537FzmRpIwcT81q
EK8nDQl5aQjYVI7kZVlxkpL5uX5oZa9D98apkBlzBIyhDZtiLo3rAbTnjGFVPQaK
31Oy5dgdoLts3kDQI9h1O6fAaNm5iaFv3YtgIFk8m3D81ADsjwm2YIEIAK5dM2Ik
QzP1Ie4ILOpq+5AiWphnn5LrcYBLzwJlGY6KUzHlG5VVfmqjpk2oL8+Te9aE1XNZ
qQz5vqE15VX8gow7ps8v/CyyARUdYtAxl7v6JLPybUZ+EL9wLwNJPumf4U4hxegM
UuYucKl/M/pX2B8/zP+mwZDewW/fe2+i+46epF1PzbGkoEj7WPuuQw==
=wPuv
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 49737@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 49737
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help