[PATCH] gnu: add the tos;dr initiative's extension

  • Open
  • quality assurance status badge
Details
2 participants
  • Sarah Morgensen
  • terramorpha
Owner
unassigned
Submitted by
terramorpha
Severity
normal
Merged with
T
T
terramorpha wrote on 9 Jul 2021 21:33
(address . guix-patches@gnu.org)
9d44234caf247026a5c19af90f5d4471@cock.li
This is a package definition for the terms of service;didn't read
initiative. It is useful to easily
know the privacy issues with whatever website the user is using.

Toggle diff (52 lines)
diff --git a/gnu/packages/browser-extensions.scm
b/gnu/packages/browser-extensions.scm
index a6120baf96..6cbe77b9c3 100644
--- a/gnu/packages/browser-extensions.scm
+++ b/gnu/packages/browser-extensions.scm
@@ -121,3 +121,41 @@ ungoogled-chromium.")

(define-public ublock-origin/chromium
(make-chromium-extension ublock-origin "chromium"))
+
+(define tosdr
+ (package
+ (name "tosdr")
+ (version "4.1.1")
+ (source (origin
+ (uri
+ (git-reference (url
"https://github.com/tosdr/browser-extensions.git")
+ (commit version)))
+ (sha256 (base32
"0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))
+ (method git-fetch)))
+ (inputs `(("bash" ,bash)
+ ("coreutils" ,coreutils)
+ ("node" ,node)
+ ("zip" ,zip)
+ ("unzip" ,unzip)))
+ (arguments
+ `(#:builder
+ (begin
+ (use-modules (guix build utils))
+ (set-path-environment-variable "PATH"
+ '("bin")
+ (map cdr %build-inputs))
+ (copy-recursively (assoc-ref %build-inputs "source") ".")
+ (invoke "sh" "./build.sh")
+ (invoke "unzip" "dist/chrome.zip" "-d" %output)
+ #t)
+ #:modules ((guix build utils))))
+ (build-system trivial-build-system)
+ (synopsis "extension for the Terms of Service; Didn't Read
initiative")
+ (description "This extension informs you instantly of your rights
online by
+showing an unintrusive icon in the toolbar. You can click on this icon
to get
+summaries from the Terms of Service; Didn't Read initiative.")
+ (license license:agpl3)
+ (home-page "https://tosdr.org/")))
+
+(define-public tosdr-chromium
+ (make-chromium-extension tosdr))
S
S
Sarah Morgensen wrote on 22 Jul 2021 23:49
(address . terramorpha@cock.li)(address . 49499@debbugs.gnu.org)
8635s6rpcf.fsf@mgsn.dev
Hi,

Thanks for the patch. Unfortunately I am unable to apply your patch; it
looks like your mail client wrapped long lines which broke the
patch. (That's why most of us send patches with `git send-email`, to
avoid this problem.)

I also have a few suggestions for your patch, annotated below...

terramorpha@cock.li writes:

Toggle quote (23 lines)
> This is a package definition for the terms of service;didn't read initiative. It
> is useful to easily
> know the privacy issues with whatever website the user is using.
>
> diff --git a/gnu/packages/browser-extensions.scm
> b/gnu/packages/browser-extensions.scm
> index a6120baf96..6cbe77b9c3 100644
> --- a/gnu/packages/browser-extensions.scm
> +++ b/gnu/packages/browser-extensions.scm
> @@ -121,3 +121,41 @@ ungoogled-chromium.")
>
> (define-public ublock-origin/chromium
> (make-chromium-extension ublock-origin "chromium"))
> +
> +(define tosdr
> + (package
> + (name "tosdr")
> + (version "4.1.1")
> + (source (origin
> + (uri
> + (git-reference (url
> "https://github.com/tosdr/browser-extensions.git")

This line is too long and should be wrapped.

Toggle quote (4 lines)
> + (commit version)))
> + (sha256 (base32
> "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))

Likewise.

Toggle quote (7 lines)
> + (method git-fetch)))
> + (inputs `(("bash" ,bash)
> + ("coreutils" ,coreutils)
> + ("node" ,node)
> + ("zip" ,zip)
> + ("unzip" ,unzip)))

These should be native-inputs rather than inputs, since they are just
used in building. Perhaps consider just using copy-build-system instead,
to avoid manually including these inputs and setting PATH below.

You can look at the ublock-origin package as an example (though I would
use the copy-build-system instead, adding back in a 'build phase, either
removing the "rm -rf build" from `build.sh` beforehand or unzipping the
zip immediately afterwards).

Toggle quote (15 lines)
> + (arguments
> + `(#:builder
> + (begin
> + (use-modules (guix build utils))
> + (set-path-environment-variable "PATH"
> + '("bin")
> + (map cdr %build-inputs))
> + (copy-recursively (assoc-ref %build-inputs "source") ".")
> + (invoke "sh" "./build.sh")
> + (invoke "unzip" "dist/chrome.zip" "-d" %output)
> + #t)
> + #:modules ((guix build utils))))
> + (build-system trivial-build-system)
> + (synopsis "extension for the Terms of Service; Didn't Read initiative")

The synopsis should begin with a capital letter.

Toggle quote (9 lines)
> + (description "This extension informs you instantly of your rights online by
> +showing an unintrusive icon in the toolbar. You can click on this icon to get
> +summaries from the Terms of Service; Didn't Read initiative.")
> + (license license:agpl3)
> + (home-page "https://tosdr.org/")))
> +
> +(define-public tosdr-chromium
> + (make-chromium-extension tosdr))

--
Sarah
S
S
Sarah Morgensen wrote on 25 Jul 2021 04:32
control message for bug #49499
(address . control@debbugs.gnu.org)
86fsw3p1h4.fsf@mgsn.dev
reassign 49582 guix-patches
merge 49499 49582
thanks
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 49499@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 49499
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch