[PATCH] gnu: add the tos;dr initiative's extension

OpenSubmitted by terramorpha.
Details
2 participants
  • Sarah Morgensen
  • terramorpha
Owner
unassigned
Severity
normal
Merged with
T
T
terramorpha wrote on 9 Jul 21:33 +0200
(address . guix-patches@gnu.org)
9d44234caf247026a5c19af90f5d4471@cock.li
This is a package definition for the terms of service;didn't read initiative. It is useful to easilyknow the privacy issues with whatever website the user is using.
Toggle diff (52 lines)diff --git a/gnu/packages/browser-extensions.scm b/gnu/packages/browser-extensions.scmindex a6120baf96..6cbe77b9c3 100644--- a/gnu/packages/browser-extensions.scm+++ b/gnu/packages/browser-extensions.scm@@ -121,3 +121,41 @@ ungoogled-chromium.")
(define-public ublock-origin/chromium (make-chromium-extension ublock-origin "chromium"))++(define tosdr+ (package+ (name "tosdr")+ (version "4.1.1")+ (source (origin+ (uri+ (git-reference (url "https://github.com/tosdr/browser-extensions.git")+ (commit version)))+ (sha256 (base32 "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))+ (method git-fetch)))+ (inputs `(("bash" ,bash)+ ("coreutils" ,coreutils)+ ("node" ,node)+ ("zip" ,zip)+ ("unzip" ,unzip)))+ (arguments+ `(#:builder+ (begin+ (use-modules (guix build utils))+ (set-path-environment-variable "PATH"+ '("bin")+ (map cdr %build-inputs))+ (copy-recursively (assoc-ref %build-inputs "source") ".")+ (invoke "sh" "./build.sh")+ (invoke "unzip" "dist/chrome.zip" "-d" %output)+ #t)+ #:modules ((guix build utils))))+ (build-system trivial-build-system)+ (synopsis "extension for the Terms of Service; Didn't Read initiative")+ (description "This extension informs you instantly of your rights online by+showing an unintrusive icon in the toolbar. You can click on this icon to get+summaries from the Terms of Service; Didn't Read initiative.")+ (license license:agpl3)+ (home-page "https://tosdr.org/")))++(define-public tosdr-chromium+ (make-chromium-extension tosdr))
S
S
Sarah Morgensen wrote on 22 Jul 23:49 +0200
(address . terramorpha@cock.li)(address . 49499@debbugs.gnu.org)
8635s6rpcf.fsf@mgsn.dev
Hi,
Thanks for the patch. Unfortunately I am unable to apply your patch; itlooks like your mail client wrapped long lines which broke thepatch. (That's why most of us send patches with `git send-email`, toavoid this problem.)
I also have a few suggestions for your patch, annotated below...
terramorpha@cock.li writes:
Toggle quote (23 lines)> This is a package definition for the terms of service;didn't read initiative. It> is useful to easily> know the privacy issues with whatever website the user is using.>> diff --git a/gnu/packages/browser-extensions.scm> b/gnu/packages/browser-extensions.scm> index a6120baf96..6cbe77b9c3 100644> --- a/gnu/packages/browser-extensions.scm> +++ b/gnu/packages/browser-extensions.scm> @@ -121,3 +121,41 @@ ungoogled-chromium.")>> (define-public ublock-origin/chromium> (make-chromium-extension ublock-origin "chromium"))> +> +(define tosdr> + (package> + (name "tosdr")> + (version "4.1.1")> + (source (origin> + (uri> + (git-reference (url> "https://github.com/tosdr/browser-extensions.git")
This line is too long and should be wrapped.
Toggle quote (4 lines)> + (commit version)))> + (sha256 (base32> "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))
Likewise.
Toggle quote (7 lines)> + (method git-fetch)))> + (inputs `(("bash" ,bash)> + ("coreutils" ,coreutils)> + ("node" ,node)> + ("zip" ,zip)> + ("unzip" ,unzip)))
These should be native-inputs rather than inputs, since they are justused in building. Perhaps consider just using copy-build-system instead,to avoid manually including these inputs and setting PATH below.
You can look at the ublock-origin package as an example (though I woulduse the copy-build-system instead, adding back in a 'build phase, eitherremoving the "rm -rf build" from `build.sh` beforehand or unzipping thezip immediately afterwards).
Toggle quote (15 lines)> + (arguments> + `(#:builder> + (begin> + (use-modules (guix build utils))> + (set-path-environment-variable "PATH"> + '("bin")> + (map cdr %build-inputs))> + (copy-recursively (assoc-ref %build-inputs "source") ".")> + (invoke "sh" "./build.sh")> + (invoke "unzip" "dist/chrome.zip" "-d" %output)> + #t)> + #:modules ((guix build utils))))> + (build-system trivial-build-system)> + (synopsis "extension for the Terms of Service; Didn't Read initiative")
The synopsis should begin with a capital letter.
Toggle quote (9 lines)> + (description "This extension informs you instantly of your rights online by> +showing an unintrusive icon in the toolbar. You can click on this icon to get> +summaries from the Terms of Service; Didn't Read initiative.")> + (license license:agpl3)> + (home-page "https://tosdr.org/")))> +> +(define-public tosdr-chromium> + (make-chromium-extension tosdr))
--Sarah
S
S
Sarah Morgensen wrote on 25 Jul 04:32 +0200
control message for bug #49499
(address . control@debbugs.gnu.org)
86fsw3p1h4.fsf@mgsn.dev
reassign 49582 guix-patchesmerge 49499 49582thanks
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 49499@debbugs.gnu.org