[PATCH] gnu: gccgo: Override empty GOROOT/GCCGOTOOLDIR

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Sarah Morgensen
Owner
unassigned
Submitted by
Sarah Morgensen
Severity
normal
S
S
Sarah Morgensen wrote on 6 Jul 2021 09:30
(address . guix-patches@gnu.org)
f3e624c4092f65a31d36bf5b8ecc0f04f1fe4a45.1625556128.git.iskarian@mgsn.dev
gnu/packages/gcc.scm (make-gccgo)[arguments]: Set tool paths
(GOROOT and GCCGOTOOLDIR) even if they are already set to "".
---
Hello all,

It turns out some tools use

GOROOT='' go env GOROOT

to find Go, which was breaking with Gccgo. This little patch fixes that.

As for the commit title, I wasn't sure if "gnu: gccgo" or "gnu: make-gccgo"
was more appropriate here... there aren't a lot of examples in the commit log!

Thanks,
Sarah

gnu/packages/gcc.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index 2fe30b1321..02d6824a99 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -871,9 +871,9 @@ provides the GNU compiler for the Go programming language.")
(tooldir (dirname (car (find-files exedir "^cgo$")))))
(wrap-program (string-append out "/bin/go")
`("GCCGOTOOLDIR" =
- (,(string-append "${GCCGOTOOLDIR-" tooldir "}")))
+ (,(string-append "${GCCGOTOOLDIR:-" tooldir "}")))
`("GOROOT" =
- (,(string-append "${GOROOT-" out "}")))))))
+ (,(string-append "${GOROOT:-" out "}")))))))
(add-before 'configure 'fix-gotools-runpath
(lambda _
(substitute* "gotools/Makefile.in"

base-commit: aa6e6fb2e9ea231d12d49a8925fddd8d2686ea94
--
2.31.1
E
E
Efraim Flashner wrote on 7 Dec 2021 14:27
(name . Sarah Morgensen)(address . iskarian@mgsn.dev)(address . 49432-done@debbugs.gnu.org)
Ya9hJKRNY8Lq/UIM@3900XT
Looks like this got dropped somewhere. Patch pushed!

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGvYSQACgkQQarn3Mo9
g1GzPA/+L4/qyATaHrmLGyliEaNZWCW88Gf/uxSxlj4ETW4R0/oxKDUyfsp+XxSw
tyTg5gm3vB94da+5OU38mXJM8EY6oaeq7LUow3vZjID1aLxoh9K4gkiX+1OdHrm4
2zgwARb3mM08My1aB/oWpBmp0pjfNtvJoexAQS0nhm3Sid6DzkUPtsmoNO7wTPJ8
/BVWor/9Xc14UqiLqbYv7aKVDmqSqebI2GY4X7t+y7WN5fmz+VsgIgxGk77pW5AI
fC6yMu1qS2yXIHbPXoofFPh2KloqRe5wHaDNn6uEjR6gdGiWl+afuALwo1CIWJ4R
S3KUAgxwdfkGN/p92Uy5FuHOOIEfHnqq0S95Zg820ZlwmeoEJ51b0ilo2T+7tq3X
Q9/lDIhDimyo26WRmRmzI02wPbg0sju473WLxjOdgjvhpEZQKGtaPYSpVTyZyNfY
s5Q7Q+2uu9+t4Bkd0/h4QPzQMEpDEmtbA8nnzNtT7Cfd9hDfiXEKtJjJSfHBneAq
OrE1bCLymIlj7aZWgZHRq+g6YGAH2hxP7/8rfyZ5iEU1dkWpO5eAEr6MUus7+c2J
2PSzrtbw658zDuP8+ulyLYuQuvB+eUAuFvb3CYgjx7TNUqZncLj8nnQgW1QZWtY5
GHugl6E1dRND9gnSO9Nv9s+b9HvBGMX5oEwGMCaJ9f6V3tpcjeg=
=i0Fi
-----END PGP SIGNATURE-----


Closed
?