[PATCH 00/??] Improve Ren'py package

  • Done
  • quality assurance status badge
Details
3 participants
  • Chris Marusich
  • Leo Prikler
  • zimoun
Owner
unassigned
Submitted by
Leo Prikler
Severity
normal
L
L
Leo Prikler wrote on 2 Jul 2021 14:39
(address . guix-patches@gnu.org)
e9943d256ded2136e82fbeb2f2cb917659ea62fc.camel@student.tugraz.at
Hi Guix,

Being one of the first package I've ever contributed to Guix, the renpy
package contains a few mistakes, some of which were fixed over time,
but many of which still remain. This series aims to address a few of
them. At the time of writing, I haven't yet finished it, I just want
to claim the bug ID, so that I can 'git send-email' later today.

Thanks
L
L
Leo Prikler wrote on 2 Jul 2021 15:58
[PATCH 2/4] gnu: python2-renpy: Update description.
(address . 49329@debbugs.gnu.org)
20210702135818.16084-2-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (python2-renpy)[description]: Mention,
that it's only used for bootstrapping renpy.
---
gnu/packages/game-development.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 22c44a585c..9b231ad333 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1250,8 +1250,10 @@ developed mainly for Ren'py.")
("xdg-utils" ,xdg-utils)))
(home-page "https://www.renpy.org/")
(synopsis "Ren'py python module")
- (description "This package contains the shared libraries and Python
-modules of Ren'py.")
+ (description "This package contains the shared libraries and Python modules
+of Ren'py. While functional, they are not meaningful on their own without
+the launcher and common Ren'py code provided by the @code{renpy} package and
+are only used to bootstrap it.")
(license license:expat)))
(define-public renpy
--
2.32.0
L
L
Leo Prikler wrote on 2 Jul 2021 15:58
[PATCH 3/4] gnu: python2-renpy: Correct inputs.
(address . 49329@debbugs.gnu.org)
20210702135818.16084-3-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (python2-renpy)[#:phases]<fix-commands>:
Search for ‘xdg-open’ in inputs.
<set-build-vars>: Search for ‘cython’ in native-inputs.
[native-inputs]: Move ‘xdg-utils’ from here…
[inputs]: … to here.
---
gnu/packages/game-development.scm | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)

Toggle diff (51 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 9b231ad333..7c5d45c412 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1186,10 +1186,11 @@ developed mainly for Ren'py.")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-commands
- (lambda _
+ (lambda* (#:key inputs #:allow-other-keys)
(substitute* "renpy/editor.py"
(("xdg-open")
- (which "xdg-open")))
+ (string-append (assoc-ref inputs "xdg-utils")
+ "/bin/xdg-open")))
#t))
(add-after 'unpack 'fix-include-paths
(lambda* (#:key inputs #:allow-other-keys)
@@ -1199,9 +1200,10 @@ developed mainly for Ren'py.")
"/include/fribidi")))
#t))
(add-after 'set-paths 'set-build-vars
- (lambda* (#:key inputs #:allow-other-keys)
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
(setenv "RENPY_CYTHON"
- (string-append (assoc-ref inputs "python2-cython")
+ (string-append (assoc-ref (or native-inputs inputs)
+ "python2-cython")
"/bin/cython"))
(setenv "RENPY_DEPS_INSTALL" (string-join (map cdr inputs) ":"))
#t))
@@ -1240,14 +1242,14 @@ developed mainly for Ren'py.")
("glew" ,glew)
("libpng" ,libpng)
("sdl-union"
- ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))))
+ ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))
+ ("xdg-utils" ,xdg-utils)))
(propagated-inputs
`(("python2-future" ,python2-future)
("python2-pygame" ,python2-pygame-sdl2)))
(native-inputs
`(("gcc" ,gcc-8) ; for const variables as initializer elements
- ("python2-cython" ,python2-cython)
- ("xdg-utils" ,xdg-utils)))
+ ("python2-cython" ,python2-cython)))
(home-page "https://www.renpy.org/")
(synopsis "Ren'py python module")
(description "This package contains the shared libraries and Python modules
--
2.32.0
L
L
Leo Prikler wrote on 2 Jul 2021 15:58
[PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources.
(address . 49329@debbugs.gnu.org)
20210702135818.16084-1-leo.prikler@student.tugraz.at
These sources are written in Ren'py (the language) and thus not particularly
useful before renpy itself is built. In particular, they serve no purpose
when installed without prior compilation.

* gnu/packages/game-development.scm (python2-renpy)[#:phases]<install>:
Drop installed "common" folder.
(renpy)[#:phases]<install>: Adjust comment accordingly.
---
gnu/packages/game-development.scm | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)

Toggle diff (50 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 9069b88d0c..22c44a585c 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1230,7 +1230,8 @@ developed mainly for Ren'py.")
(with-directory-excursion "module"
(apply (assoc-ref %standard-phases 'install) args))
(copy-recursively "renpy"
- (string-append out site "/renpy")))
+ (string-append out site "/renpy"))
+ (delete-file-recursively (string-append out site "/renpy/common")))
#t)))))
(inputs
`(("ffmpeg" ,ffmpeg)
@@ -1304,11 +1305,14 @@ modules of Ren'py.")
;; After finishing this step, "out" will have the following:
;; |-- bin/renpy
;; `-- share/renpy ; i.e. path_to_renpy_base()
- ;; `-- common
+ ;; |-- common
+ ;; `-- gui
;;
- ;; Note that common is also a de facto unused directory in
- ;; python2-renpy. On other systems, renpy_base would point to
- ;; site-packages or even somewhere in /opt.
+ ;; Note that common shares the source files that would be installed
+ ;; by python2-renpy (which are instead deleted from that package),
+ ;; but also contains their byte-compiled versions.
+ ;; On other systems, renpy_base would point to site-packages or
+ ;; even somewhere in /opt.
;; The former approach is not as straightforward as it seems
;; -- it causes renpy to load files twice for some weird reason --
;; and the latter is impossible on Guix. Hence the detour through
@@ -1319,9 +1323,11 @@ modules of Ren'py.")
;; well. This differs from the traditional layout, which is
;; roughly the following:
;; `-- Super Awesome Game
- ;; |-- game ; <- the folder we actually want
- ;; |-- lib ; compiled renpy module and dependencies
- ;; |-- renpy ; Ren'py python code (source + compiled)
+ ;; |-- game ; <- the folder we actually want
+ ;; |-- lib ; compiled renpy module and dependencies
+ ;; |-- renpy ; yet another copy of Ren'py's code
+ ;; | |-- common ; the common folder from above
+ ;; | `-- ... ; Python code (source + compiled)
;; |-- Super Awesome Game.py
;; `-- Super Awesome Game.sh
(let* ((out (assoc-ref outputs "out"))
--
2.32.0
L
L
Leo Prikler wrote on 2 Jul 2021 15:58
[PATCH 4/4] gnu: renpy: Correct inputs.
(address . 49329@debbugs.gnu.org)
20210702135818.16084-4-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (renpy)[#:modules]: Add SRFI-1.
[#:imported-modules]: Likewise.
[#:phases]<fix-commands>: Search for ‘python2’ and ‘xdg-open’ in inputs.
<start-xserver>: Search for ‘xorg-server’ in native-inputs.
<install>: Search for ‘python2’ in inputs.
<wrap>: Search for python dependencies in inputs.
[inputs]: Add python2, drop python2-pygame (already propagated by
python2-renpy). Move xorg-server from here…
[native-inputs]: … to here.
[propagated-inputs]: Empty.
---
gnu/packages/game-development.scm | 54 +++++++++++++++++++++++--------
1 file changed, 40 insertions(+), 14 deletions(-)

Toggle diff (95 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 7c5d45c412..5d5fa5cf8b 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1266,15 +1266,22 @@ are only used to bootstrap it.")
(arguments
`(#:tests? #f ; see python2-renpy
#:python ,python-2
+ #:modules ((srfi srfi-1)
+ (guix build python-build-system)
+ (guix build utils))
+ #:imported-modules ((srfi srfi-1) ,@%python-build-system-modules)
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-commands
- (lambda* (#:key outputs #:allow-other-keys)
+ (lambda* (#:key inputs outputs #:allow-other-keys)
(substitute* "launcher/game/choose_directory.rpy"
- (("/usr/bin/python") (which "python2")))
+ (("/usr/bin/python")
+ (string-append (assoc-ref inputs "python2")
+ "/bin/python2")))
(substitute* "launcher/game/front_page.rpy"
(("xdg-open")
- (which "xdg-open")))
+ (string-append (assoc-ref inputs "xdg-utils")
+ "/bin/xdg-open")))
(substitute* "launcher/game/project.rpy"
(("cmd = \\[ executable, \"-EO\", sys.argv\\[0\\] \\]")
(string-append "cmd = [ \"" (assoc-ref outputs "out")
@@ -1291,8 +1298,9 @@ are only used to bootstrap it.")
((", \"game\",") ","))
#t))
(add-before 'build 'start-xserver
- (lambda* (#:key inputs #:allow-other-keys)
- (let ((xorg-server (assoc-ref inputs "xorg-server")))
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (let ((xorg-server (assoc-ref (or native-inputs inputs)
+ "xorg-server")))
(setenv "HOME" (getcwd))
(system (format #f "~a/bin/Xvfb :1 &" xorg-server))
(setenv "DISPLAY" ":1")
@@ -1344,7 +1352,8 @@ are only used to bootstrap it.")
(call-with-output-file bin/renpy
(lambda (port)
- (format port "#!~a~%" (which "python2"))
+ (format port "#!~a/bin/python2~%"
+ (assoc-ref inputs "python2"))
(format port "
from __future__ import print_function
@@ -1433,15 +1442,32 @@ if __name__ == \"__main__\":
#t))
(replace 'wrap
(lambda* (#:key inputs outputs #:allow-other-keys)
- (wrap-program (string-append (assoc-ref outputs "out")
- "/bin/renpy")
- `("PYTHONPATH" = (,(getenv "PYTHONPATH"))))
- #t)))))
+ (let ((out (assoc-ref outputs "out"))
+ (site (string-append "/lib/python"
+ (python-version
+ (assoc-ref inputs "python"))
+ "/site-packages")))
+ (wrap-program (string-append out "/bin/renpy")
+ `("PYTHONPATH" =
+ (,@(delete-duplicates
+ (map
+ (lambda (store-path)
+ (string-append store-path site))
+ (cons (assoc-ref outputs "out")
+ (map cdr
+ (filter
+ (lambda (input)
+ (string-prefix? "python2" (car input)))
+ inputs))))))))
+ #t))))))
(inputs
- `(("python2-tkinter" ,python-2 "tk")
- ("python2-pygame" ,python2-pygame-sdl2)
- ("python2-renpy" ,python2-renpy)
- ("xorg-server" ,xorg-server)))
+ `(("python2-renpy" ,python2-renpy)
+ ("python2-tkinter" ,python-2 "tk")
+ ("python2" ,python-2) ; for ‘fix-commands’ and ‘wrap’
+ ("xdg-utils" ,xdg-utils)))
+ (propagated-inputs '())
+ (native-inputs
+ `(("xorg-server" ,xorg-server-for-tests)))
(outputs
(list "out" "tutorial" "the-question"))
(home-page "https://www.renpy.org/")
--
2.32.0
Z
Z
zimoun wrote on 3 Jul 2021 09:50
Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources.
8635sval9h.fsf@gmail.com
Hi Leo,

Just a general comment about Python 2. :-)

On Fri, 02 Jul 2021 at 15:58, Leo Prikler <leo.prikler@student.tugraz.at> wrote:

Toggle quote (2 lines)
> * gnu/packages/game-development.scm (python2-renpy)[#:phases]<install>:

Is Ren’py working only with Python 2? Or does it also work with Python
3? Because Python 2 is EOL, officially since January 2020, if Ren’py is
Python 2 only, maybe it could go to the channel guix-past [1], soon or
later. :-) WDYT?


Cheers,
simon
L
L
Leo Prikler wrote on 3 Jul 2021 10:35
68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at
Hi simon,

Am Samstag, den 03.07.2021, 09:50 +0200 schrieb zimoun:
Toggle quote (19 lines)
> Hi Leo,
>
> Just a general comment about Python 2. :-)
>
> On Fri, 02 Jul 2021 at 15:58, Leo Prikler <
> leo.prikler@student.tugraz.at> wrote:
>
> > * gnu/packages/game-development.scm (python2-
> > renpy)[#:phases]<install>:
>
> Is Ren’py working only with Python 2? Or does it also work with
> Python
> 3? Because Python 2 is EOL, officially since January 2020, if Ren’py
> is
> Python 2 only, maybe it could go to the channel guix-past [1], soon
> or
> later. :-) WDYT?
>
> 1: <https://gitlab.inria.fr/guix-hpc/guix-past>
Ren'py does have a Python 3 compatibility layer, but I haven't gone
around to doing a pure Python 3 build yet. I imagine it could also be
used with Tauthon[1], which was suggested to be used as python2
replacement in places where projects can't trivially be ported to the
newer python 3 stuffs.

Furthermore, Ren'py 8 will use Python 3 as a base. I don't know if
it'll be backwards compatible with Ren'py 7 then – probably not. If
not, moving Ren'py 7 to Guix-Past sounds like a good idea.

I must admit, I haven't been following the Python 2 removal plan too
closely. Is it already time to move working leaf packages?

Cheers,
Leo

L
L
Leo Prikler wrote on 3 Jul 2021 11:28
[PATCH v2 1/5] gnu: python2-renpy: Drop unused Ren'py sources.
(address . 49329@debbugs.gnu.org)
20210703092842.32189-1-leo.prikler@student.tugraz.at
These sources are written in Ren'py (the language) and thus not particularly
useful before renpy itself is built. In particular, they serve no purpose
when installed without prior compilation.

* gnu/packages/game-development.scm (python2-renpy)[#:phases]<install>:
Drop installed "common" folder.
(renpy)[#:phases]<install>: Adjust comment accordingly.
---
0001 up to 0004 are identical to v1.

gnu/packages/game-development.scm | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)

Toggle diff (50 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 9069b88d0c..22c44a585c 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1230,7 +1230,8 @@ developed mainly for Ren'py.")
(with-directory-excursion "module"
(apply (assoc-ref %standard-phases 'install) args))
(copy-recursively "renpy"
- (string-append out site "/renpy")))
+ (string-append out site "/renpy"))
+ (delete-file-recursively (string-append out site "/renpy/common")))
#t)))))
(inputs
`(("ffmpeg" ,ffmpeg)
@@ -1304,11 +1305,14 @@ modules of Ren'py.")
;; After finishing this step, "out" will have the following:
;; |-- bin/renpy
;; `-- share/renpy ; i.e. path_to_renpy_base()
- ;; `-- common
+ ;; |-- common
+ ;; `-- gui
;;
- ;; Note that common is also a de facto unused directory in
- ;; python2-renpy. On other systems, renpy_base would point to
- ;; site-packages or even somewhere in /opt.
+ ;; Note that common shares the source files that would be installed
+ ;; by python2-renpy (which are instead deleted from that package),
+ ;; but also contains their byte-compiled versions.
+ ;; On other systems, renpy_base would point to site-packages or
+ ;; even somewhere in /opt.
;; The former approach is not as straightforward as it seems
;; -- it causes renpy to load files twice for some weird reason --
;; and the latter is impossible on Guix. Hence the detour through
@@ -1319,9 +1323,11 @@ modules of Ren'py.")
;; well. This differs from the traditional layout, which is
;; roughly the following:
;; `-- Super Awesome Game
- ;; |-- game ; <- the folder we actually want
- ;; |-- lib ; compiled renpy module and dependencies
- ;; |-- renpy ; Ren'py python code (source + compiled)
+ ;; |-- game ; <- the folder we actually want
+ ;; |-- lib ; compiled renpy module and dependencies
+ ;; |-- renpy ; yet another copy of Ren'py's code
+ ;; | |-- common ; the common folder from above
+ ;; | `-- ... ; Python code (source + compiled)
;; |-- Super Awesome Game.py
;; `-- Super Awesome Game.sh
(let* ((out (assoc-ref outputs "out"))
--
2.32.0
L
L
Leo Prikler wrote on 3 Jul 2021 11:28
[PATCH v2 2/5] gnu: python2-renpy: Update description.
(address . 49329@debbugs.gnu.org)
20210703092842.32189-2-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (python2-renpy)[description]: Mention,
that it's only used for bootstrapping renpy.
---
gnu/packages/game-development.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 22c44a585c..9b231ad333 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1250,8 +1250,10 @@ developed mainly for Ren'py.")
("xdg-utils" ,xdg-utils)))
(home-page "https://www.renpy.org/")
(synopsis "Ren'py python module")
- (description "This package contains the shared libraries and Python
-modules of Ren'py.")
+ (description "This package contains the shared libraries and Python modules
+of Ren'py. While functional, they are not meaningful on their own without
+the launcher and common Ren'py code provided by the @code{renpy} package and
+are only used to bootstrap it.")
(license license:expat)))
(define-public renpy
--
2.32.0
L
L
Leo Prikler wrote on 3 Jul 2021 11:28
[PATCH v2 3/5] gnu: python2-renpy: Correct inputs.
(address . 49329@debbugs.gnu.org)
20210703092842.32189-3-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (python2-renpy)[#:phases]<fix-commands>:
Search for ‘xdg-open’ in inputs.
<set-build-vars>: Search for ‘cython’ in native-inputs.
[native-inputs]: Move ‘xdg-utils’ from here…
[inputs]: … to here.
---
gnu/packages/game-development.scm | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)

Toggle diff (51 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 9b231ad333..7c5d45c412 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1186,10 +1186,11 @@ developed mainly for Ren'py.")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-commands
- (lambda _
+ (lambda* (#:key inputs #:allow-other-keys)
(substitute* "renpy/editor.py"
(("xdg-open")
- (which "xdg-open")))
+ (string-append (assoc-ref inputs "xdg-utils")
+ "/bin/xdg-open")))
#t))
(add-after 'unpack 'fix-include-paths
(lambda* (#:key inputs #:allow-other-keys)
@@ -1199,9 +1200,10 @@ developed mainly for Ren'py.")
"/include/fribidi")))
#t))
(add-after 'set-paths 'set-build-vars
- (lambda* (#:key inputs #:allow-other-keys)
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
(setenv "RENPY_CYTHON"
- (string-append (assoc-ref inputs "python2-cython")
+ (string-append (assoc-ref (or native-inputs inputs)
+ "python2-cython")
"/bin/cython"))
(setenv "RENPY_DEPS_INSTALL" (string-join (map cdr inputs) ":"))
#t))
@@ -1240,14 +1242,14 @@ developed mainly for Ren'py.")
("glew" ,glew)
("libpng" ,libpng)
("sdl-union"
- ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))))
+ ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))
+ ("xdg-utils" ,xdg-utils)))
(propagated-inputs
`(("python2-future" ,python2-future)
("python2-pygame" ,python2-pygame-sdl2)))
(native-inputs
`(("gcc" ,gcc-8) ; for const variables as initializer elements
- ("python2-cython" ,python2-cython)
- ("xdg-utils" ,xdg-utils)))
+ ("python2-cython" ,python2-cython)))
(home-page "https://www.renpy.org/")
(synopsis "Ren'py python module")
(description "This package contains the shared libraries and Python modules
--
2.32.0
L
L
Leo Prikler wrote on 3 Jul 2021 11:28
[PATCH v2 4/5] gnu: renpy: Correct inputs.
(address . 49329@debbugs.gnu.org)
20210703092842.32189-4-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (renpy)[#:modules]: Add SRFI-1.
[#:imported-modules]: Likewise.
[#:phases]<fix-commands>: Search for ‘python2’ and ‘xdg-open’ in inputs.
<start-xserver>: Search for ‘xorg-server’ in native-inputs.
<install>: Search for ‘python2’ in inputs.
<wrap>: Search for python dependencies in inputs.
[inputs]: Add python2, drop python2-pygame (already propagated by
python2-renpy). Move xorg-server from here…
[native-inputs]: … to here.
[propagated-inputs]: Empty.
---
gnu/packages/game-development.scm | 54 +++++++++++++++++++++++--------
1 file changed, 40 insertions(+), 14 deletions(-)

Toggle diff (95 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 7c5d45c412..5d5fa5cf8b 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1266,15 +1266,22 @@ are only used to bootstrap it.")
(arguments
`(#:tests? #f ; see python2-renpy
#:python ,python-2
+ #:modules ((srfi srfi-1)
+ (guix build python-build-system)
+ (guix build utils))
+ #:imported-modules ((srfi srfi-1) ,@%python-build-system-modules)
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-commands
- (lambda* (#:key outputs #:allow-other-keys)
+ (lambda* (#:key inputs outputs #:allow-other-keys)
(substitute* "launcher/game/choose_directory.rpy"
- (("/usr/bin/python") (which "python2")))
+ (("/usr/bin/python")
+ (string-append (assoc-ref inputs "python2")
+ "/bin/python2")))
(substitute* "launcher/game/front_page.rpy"
(("xdg-open")
- (which "xdg-open")))
+ (string-append (assoc-ref inputs "xdg-utils")
+ "/bin/xdg-open")))
(substitute* "launcher/game/project.rpy"
(("cmd = \\[ executable, \"-EO\", sys.argv\\[0\\] \\]")
(string-append "cmd = [ \"" (assoc-ref outputs "out")
@@ -1291,8 +1298,9 @@ are only used to bootstrap it.")
((", \"game\",") ","))
#t))
(add-before 'build 'start-xserver
- (lambda* (#:key inputs #:allow-other-keys)
- (let ((xorg-server (assoc-ref inputs "xorg-server")))
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (let ((xorg-server (assoc-ref (or native-inputs inputs)
+ "xorg-server")))
(setenv "HOME" (getcwd))
(system (format #f "~a/bin/Xvfb :1 &" xorg-server))
(setenv "DISPLAY" ":1")
@@ -1344,7 +1352,8 @@ are only used to bootstrap it.")
(call-with-output-file bin/renpy
(lambda (port)
- (format port "#!~a~%" (which "python2"))
+ (format port "#!~a/bin/python2~%"
+ (assoc-ref inputs "python2"))
(format port "
from __future__ import print_function
@@ -1433,15 +1442,32 @@ if __name__ == \"__main__\":
#t))
(replace 'wrap
(lambda* (#:key inputs outputs #:allow-other-keys)
- (wrap-program (string-append (assoc-ref outputs "out")
- "/bin/renpy")
- `("PYTHONPATH" = (,(getenv "PYTHONPATH"))))
- #t)))))
+ (let ((out (assoc-ref outputs "out"))
+ (site (string-append "/lib/python"
+ (python-version
+ (assoc-ref inputs "python"))
+ "/site-packages")))
+ (wrap-program (string-append out "/bin/renpy")
+ `("PYTHONPATH" =
+ (,@(delete-duplicates
+ (map
+ (lambda (store-path)
+ (string-append store-path site))
+ (cons (assoc-ref outputs "out")
+ (map cdr
+ (filter
+ (lambda (input)
+ (string-prefix? "python2" (car input)))
+ inputs))))))))
+ #t))))))
(inputs
- `(("python2-tkinter" ,python-2 "tk")
- ("python2-pygame" ,python2-pygame-sdl2)
- ("python2-renpy" ,python2-renpy)
- ("xorg-server" ,xorg-server)))
+ `(("python2-renpy" ,python2-renpy)
+ ("python2-tkinter" ,python-2 "tk")
+ ("python2" ,python-2) ; for ‘fix-commands’ and ‘wrap’
+ ("xdg-utils" ,xdg-utils)))
+ (propagated-inputs '())
+ (native-inputs
+ `(("xorg-server" ,xorg-server-for-tests)))
(outputs
(list "out" "tutorial" "the-question"))
(home-page "https://www.renpy.org/")
--
2.32.0
L
L
Leo Prikler wrote on 3 Jul 2021 11:28
[PATCH v2 5/5] gnu: Add python-pygame-sdl2.
(address . 49329@debbugs.gnu.org)
20210703092842.32189-5-leo.prikler@student.tugraz.at
* gnu/packages/game-development.scm (python-pygame-sdl2): New variable.
Inherit package definition from previous python2-pygame-sdl2, with the
following additions:
[source]: Also drop “gen3” in snippet.
[arguments]: Drop #:python.
[native-inputs]: Use ‘python-cython’ instead of ‘python2-cython’.
(python2-pygame-sdl2): Define in terms of python-pygame-sdl2.
---
gnu/packages/game-development.scm | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

Toggle diff (55 lines)
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 5d5fa5cf8b..e1593c0f82 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1106,12 +1106,12 @@ to create fully featured games and multimedia programs in the python language.")
(define-public python2-pygame
(package-with-python2 python-pygame))
-(define-public python2-pygame-sdl2
+(define-public python-pygame-sdl2
(let ((real-version "2.1.0")
(renpy-version "7.4.6"))
(package
- (inherit python2-pygame)
- (name "python2-pygame-sdl2")
+ (inherit python-pygame)
+ (name "python-pygame-sdl2")
(version (string-append real-version "-for-renpy-" renpy-version))
(source
(origin
@@ -1124,12 +1124,12 @@ to create fully featured games and multimedia programs in the python language.")
'(begin
;; drop generated sources
(delete-file-recursively "gen")
+ (delete-file-recursively "gen3")
(delete-file-recursively "gen-static")
#t))))
(build-system python-build-system)
(arguments
`(#:tests? #f ; tests require pygame to be installed first
- #:python ,python-2
#:phases
(modify-phases %standard-phases
(add-after 'set-paths 'set-sdl-vars
@@ -1149,7 +1149,7 @@ to create fully featured games and multimedia programs in the python language.")
`(("sdl-union"
,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf)))))
(native-inputs
- `(("python2-cython" ,python2-cython)))
+ `(("python-cython" ,python-cython)))
(home-page "https://www.renpy.org/")
(synopsis "Reimplementation of the Pygame API using SDL2")
(description "Pygame_SDL2 reimplements the Pygame API using SDL2,
@@ -1158,6 +1158,9 @@ While it aims to be used as a drop-in replacement, it appears to be
developed mainly for Ren'py.")
(license (list license:lgpl2.1 license:zlib)))))
+(define-public python2-pygame-sdl2
+ (package-with-python2 python-pygame-sdl2))
+
(define-public python2-renpy
(package
(name "python2-renpy")
--
2.32.0
C
C
Chris Marusich wrote on 11 Jul 2021 05:50
Re: bug#49329: [PATCH 00/??] Improve Ren'py package
87fswl5x0s.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (35 lines)
> Hi simon,
>
> Am Samstag, den 03.07.2021, 09:50 +0200 schrieb zimoun:
>> Hi Leo,
>>
>> Just a general comment about Python 2. :-)
>>
>> On Fri, 02 Jul 2021 at 15:58, Leo Prikler <
>> leo.prikler@student.tugraz.at> wrote:
>>
>> > * gnu/packages/game-development.scm (python2-
>> > renpy)[#:phases]<install>:
>>
>> Is Ren’py working only with Python 2? Or does it also work with
>> Python
>> 3? Because Python 2 is EOL, officially since January 2020, if Ren’py
>> is
>> Python 2 only, maybe it could go to the channel guix-past [1], soon
>> or
>> later. :-) WDYT?
>>
>> 1: <https://gitlab.inria.fr/guix-hpc/guix-past>
> Ren'py does have a Python 3 compatibility layer, but I haven't gone
> around to doing a pure Python 3 build yet. I imagine it could also be
> used with Tauthon[1], which was suggested to be used as python2
> replacement in places where projects can't trivially be ported to the
> newer python 3 stuffs.
>
> Furthermore, Ren'py 8 will use Python 3 as a base. I don't know if
> it'll be backwards compatible with Ren'py 7 then – probably not. If
> not, moving Ren'py 7 to Guix-Past sounds like a good idea.
>
> I must admit, I haven't been following the Python 2 removal plan too
> closely. Is it already time to move working leaf packages?

It sounds like the plan is in flux, but essentially yes:


It seems to me that Python 2 will likely remain in Guix for some time,
but the various Python 2 packages will over time become hidden or
removed in favor of their Python 3 variants.

The Ren'Py plan is outlined here (I think?):


It sounds like it's going to be a slow (years) process for them. Other
issues can be found here:


Personally, I don't think it would be bad to add Ren'Py 7 to Guix
proper, even if it still depends on Python 2 and Python 2 libraries.
Until upstream supports Python 3, there is no other option, and for now
it sounds like we are not planning on removing all of the Python 2
libraries just yet.

If the maintenance burden becomes too great or we decide to eliminate
more Python 2 dependencies from Guix proper, we can always drop Ren'Py 7
or move it to Guix-Past along with its dependencies. Hopefully Ren'Py 8
will bring Python 3 support sooner sooner than that, though, and we can
just drop Ren'Py 7 in favor of Ren'Py 8 at that time.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqapMVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkaduDwP/i4TdXO0fx6nAmKNdtvig4SdJopL
WLAzPknQyWvsV/f7E8kyLr3hnS2JhqksvwUghjqEU2MQ60Wa6YfiQWwGLeWb5NS+
LlPqPUSwHA+CVZb9cB9mOAniwZvDWV7wGwU/IzOTnsc1O5kwPZiXbjtDRi74xRJ1
A7xt7zBp600umbCRLMHYr6TjEcg7p+TFRcXjTjMciTEDvYgPU+G8HE4e91zuM8ya
6xdSQqgNs4Qnu5Vjzic/kVqXprgilIV03H7QgRBsfFgtfvUgbYu3N2X9fmWXxrFd
KFhXvulgh+LzMyOuKmBJcZmGmPiMq34Rtw5h8hmXf/ILRnXCNMnIlB/7ttoEMhBj
rntNtZAyUnDdM7UDoQWqxt+z/zduIm68D2sgebw1ZDEIAZqhg11B3XCQbBhaSbf9
KKC5ZgdoVsYu0iGN7yX/sBZl296JLvWUUTUma61+xRZ496RPrR9y9/vua1htvA4o
f24lORLpfy1TjIprXr0BpwqGnZNriom4Fc1RF9jRB3pMaxhnZdCirYN7L4orxNAv
nsY8x27QPM0oBEc6Fqs62Pyc+eS3tDaaFcFqJMue5as8IEfX4WGMh8G2O+APEzvZ
tnTHU4zBPidtRFc54E7zxDT3je4zhz2Oqueoarmb0tVTbCZrKkIfhFmQVlZsfVLY
NKF3odvp9yrbO9PQ
=67xY
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 11 Jul 2021 06:37
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
8735sl5uu8.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (28 lines)
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> [...]
> #t))
> (replace 'wrap
> (lambda* (#:key inputs outputs #:allow-other-keys)
> - (wrap-program (string-append (assoc-ref outputs "out")
> - "/bin/renpy")
> - `("PYTHONPATH" = (,(getenv "PYTHONPATH"))))
> - #t)))))
> + (let ((out (assoc-ref outputs "out"))
> + (site (string-append "/lib/python"
> + (python-version
> + (assoc-ref inputs "python"))
> + "/site-packages")))
> + (wrap-program (string-append out "/bin/renpy")
> + `("PYTHONPATH" =
> + (,@(delete-duplicates
> + (map
> + (lambda (store-path)
> + (string-append store-path site))
> + (cons (assoc-ref outputs "out")
> + (map cdr
> + (filter
> + (lambda (input)
> + (string-prefix? "python2" (car input)))
> + inputs))))))))
> + #t))))))

What's the motivation for doing this? It seems like the new version
deletes duplicates, but has the downside of being a little more
complicated and relying on the package names to determine what goes into
the PYTHONPATH.

Duplicate entries in the PYTHONPATH should not be a problem for
correctness or performance, right? I feel like this section was perhaps
better the way it was originally. Am I missing something?

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqdZ8VHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadt48QANHE5O25M4VFKZBCFRiNqyJe0AJh
ccusZ23P4wPvg97hLKZT6c9GKCjiPLWZGHRIh5a9Fmh4MH6XN6KXRg5zA4V5GzjF
WriXfbpzT8kRGHvaLLiM8F1U+xQWfYnry0Cz1tp13NZU9U7LNpnVF1mMTnc/IDX2
Bo5G1r+uq3g+Q5DPQjbKiJyko/Up8bL53360h2W+dYX+ZN6tZ+pExKVl+E97a2Wz
5D38S5W3j5Epn1UxzlbVp5eY8H3SvCU5DNN+LFiWVKLWH4M6vBVi7Flagi3GTLRW
kDWtJk1usrZHR8rS9M3tG56JQ9FeGSxsQ0EXSnaD3tKQLhwHaqYwMDA+HhM8B4r7
YY7xglQ6dCPj5WZdulVaiS6SQWHS+WvuArrgm07Ef+Oxg8h4aiQm/h1NMdYflJ67
rzuDFlrZtUanL33K+yZnIwbOBg03+6STCkSzRPNMzcv9txB6KGva5B6zdvtUgLX8
vIMJq4DgymEMlD8BarfPy+euXt9QhnvWnWA0zIoUvJmt41+CsVIUzVBUjF5yfjb9
5GT1WZjZhQtNtdhGEh4LS+q8K/4jVdGi+YFNEt/tX39kphb1qcqM7t4ORm5dSaOS
GB7rBHDwFXT847+hAluItvV9z9x09aOziiK5O/TeVhRXxBDqIl7RPuE7+PtczPd+
NSqPJAGVgWsjgJp8
=hvkH
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 11 Jul 2021 06:44
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
87y2ad4fyq.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (4 lines)
> * gnu/packages/game-development.scm (python-pygame-sdl2): New variable.
> Inherit package definition from previous python2-pygame-sdl2, with the
> following additions:

Actually, it inherits from python-pygame, right?

Toggle quote (5 lines)
> [source]: Also drop “gen3” in snippet.
> [arguments]: Drop #:python.
> [native-inputs]: Use ‘python-cython’ instead of ‘python2-cython’.
> (python2-pygame-sdl2): Define in terms of python-pygame-sdl2.

LGTM.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqdy0VHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadrEgP/1J8Mm1TM9ArQyEiaWP6NgfAI+oK
Ex9zkA/LUaDpi6+6JP+anrJZ7euk04sK5MNx5lXlyPub9FHpbViDshTpcyO/hDHj
WavLpckc1H2OE21oaUazMT+P2YAIp4x1v0U2hHFjXwP+Gdr1ul9VAKPQ80/LGxlR
7LDRUagPztSQrdzDfNE0299xtcRiDJGZDAvIdLi5klf1Kz6yqZNONVv0QdRyp7hM
pDk2wlEVHnqneRv9J4luT/277cf7fmzTn6YprpCCNb5SuEmEZ1lwOhlVB33XzsYl
vjHw1PM0HPAEW059d2g01Zbv79yhWRjWKpbutRRfwl1fbKu7cGKRTV7K8tV7AI6I
kARld40N+yCJC96vBJiA7cXPbYmozHshEgAkUOKWNCUinWwgpp1yy5VrPEpvPRm0
l0/uuUzNRIhM0oV7TAHUcGCkocBTNI5+5/ujNGO30nKHdsdu+U7vguEqIKbChX9+
ZHDYdP8M4S51/gXGGUo3mANK+3Dn98SnSyZzPGDhLbPZMesm7Lok2HbpCSO16j++
0JlicIoXqD1vGfWg0rR6PxoXCKeETrmWGcLM0eiETcURhrYUxHmdN6YFZRMUva7e
d0FDaos/eC10TUL45sZ0Qo3RAReUopeYIyJIc8Kk2GAed/wQTO4UR1i+cDALJNrC
05WcPGwPB2O4T/z6
=HQFc
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 11 Jul 2021 06:52
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
87r1g54fla.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (4 lines)
> These sources are written in Ren'py (the language) and thus not particularly
> useful before renpy itself is built. In particular, they serve no purpose
> when installed without prior compilation.

Could we pre-compile those sources on installation, instead of deleting
the common directory? I haven't used Ren'Py much (or at all in Guix),
so I don't really understand the purpose of the common directory. I
could just be missing some context/info.

Other than that, this patch seems OK as far as I can tell.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeREVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadR1sP/0lLnM6/0IBtgJ8d2BJK7yLZt0/y
vPnk8/4WDwgwLoytvEl70z8SesWz5IUqN30h+2iQi4VOklGbftuMSOK8fxU0IIgA
Qt/xbfWhWg/fCaJ3K0tCcjPkzE0AYigF2kWBBBhAKxhnZeYVPgrXOm6i5JBzXcpV
gAkzfrXlApk/+wrqOVQGSC9z3/Skwqc2UZKcPotsiF9RDAyr1rHrymIh4iDxF8r4
1kGthvVW0hWpwuRrUy+NNrpS3TD5T1B9lU0tEAeKllgg9PHUmtYsjHR+/P3vLXbK
5a3KUar2Ekq2LycU3QTaLn3oAJTdzIHfF3J4iiQr0POCA5Kn2uEGK43BsrpdRIOU
xw/oBAGalEy0dPdAzhMnw86Rr7bnli1hi2ZEPC39V2LlgEc3JhOKj7H6NYbtHTLW
tDJxPDZd6SOMGMSd3rf6CFHbh8ifYsntnV5Vhc7k60fGt7UOzZ/EkXJbHKv1MzQE
DGrXpKlqDX1wAkk/z72Qh25sMCW7rVi+N9afsEGoaYOPKSaxawE8MfsKgAiZRZIj
4T8CkW60v3FfgOtvLc6kdU3BXwBS0LbDeYkRofuRS7cQhJlBrN0s5BpIr4+/BStp
fsGXv33xnqNFNBbpFZXddrSZlx/IPvljQc1q6nXhSTC8arFh5lxRBHbq8oYYi18K
eGL2NgKjJAyP/YD5
=rl1E
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 11 Jul 2021 06:53
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
87mtqt4fjf.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (24 lines)
> * gnu/packages/game-development.scm (python2-renpy)[description]: Mention,
> that it's only used for bootstrapping renpy.
> ---
> gnu/packages/game-development.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
> index 22c44a585c..9b231ad333 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.")
> ("xdg-utils" ,xdg-utils)))
> (home-page "https://www.renpy.org/")
> (synopsis "Ren'py python module")
> - (description "This package contains the shared libraries and Python
> -modules of Ren'py.")
> + (description "This package contains the shared libraries and Python modules
> +of Ren'py. While functional, they are not meaningful on their own without
> +the launcher and common Ren'py code provided by the @code{renpy} package and
> +are only used to bootstrap it.")
> (license license:expat)))
>
> (define-public renpy

LGTM. If this isn't meant to be installed by users, should it be
non-public or perhaps hidden?

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeVQVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadnLAQAKfClHdXxGOJwdgD6nPmFwe14qNa
cepgbzrr2grd4nLF642emjk/4KeF8EDWaaJGn9ClLalOkfTqmunUHGVHwjLLTepY
9DaZ6OdpbKFFWF2coFgzDr6EGtppivpbY9Vgq12sYIwaNbrsq+yEu2bIUkhWBHV0
MxVmmAmR8n9IHpIEWfiqOFaBsq20hHRhYlp9W1ogLVIDRQeDEy6V/b6RDhhQXzZW
VbgW8cgnz7/yLOr/nLfTy0VP98isgKeG0g2qY0/lyi3xjLbe+37mGhXdXfIRIbT6
yvz78ZbQlHyDupPE93ZF9NgYCWPDWbDfa1PxoeUpD2Gxf06+DFm6MkROoHpxL1VQ
7CdcdGgHBtYYZP8ZHh3AyGfcPf7kxBA2FQLn/4XOR0JGq1aBg8ywJ80S1tmIubmZ
/AAIU8r9J9cZTIm7fJiWi02g5bBfuRWy3ZcnXQeUWgh1luUWnPSlmz/7X/3PTDCO
qAmkxXn43MDmTISMGmlogr37URctW9nR/PV8q/jYszX3crQvkIg8nNZ8cmZOlVRf
TsYjMoKTkI8G54x+l6kN6Izuo1m5GaK9UuavhuBMXdhu5O8y/CBZTkHpmNFfJohn
oaDDas5VCuu6ewhxI/s/1YKu4GJc3nqf6M1YbALny+izDzjD6oNsKXEhn0kApXxR
kXbMiRu23CVX1YRV
=WsUU
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 11 Jul 2021 06:55
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
87im1h4fh5.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (6 lines)
> * gnu/packages/game-development.scm (python2-renpy)[#:phases]<fix-commands>:
> Search for ‘xdg-open’ in inputs.
> <set-build-vars>: Search for ‘cython’ in native-inputs.
> [native-inputs]: Move ‘xdg-utils’ from here…
> [inputs]: … to here.

LGTM.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeaYVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadBNgP/jl/X+8c2MM+RIbkbSrlW3E7Tx8H
CeVxQOyoEkuuVQsuCq5t6k2teLkD/0yjwnJXn2XxmVnBef1Sr4JOjylh+rZy2C4m
EoHAsqKssbv4Wq1p5nvmkYZOB2DlegPm3oEjL+1a3/YMKrpw1uuDwfA23w3mED7X
pZrXwQ4qWval4pbbfTc0hKKH8mfk2VV85pR7GOfbKBTjyvOYupaIlbloIkCQyV3W
3e4SElFHSKNwwwnQAX57kjD8qEDdWtcRsFD/SSUaC9Hg04nfLuOMob3XaDAKB4Xc
W6bVCCmwIR+R/YT7/CDwXmcMDkOWQfaSOjCkKWZtlsCJOikE1EIzyJU/ALqrXjkr
EGAMT0bhZUgs7/1G+VEXkjFFdy527IMyEQ64ISQj4MIHYANz1kqs++9RLKV9DdEw
d6apaSWvjvh8ugk5F9v4LHtrJIuPWZA+qXDQ0fByXcyoMRSBFr9v+7el4FXLOVeO
6yc4f5n94qq+XPawknW6+ZvT2FfRpfleHKLsSZkWJJGFTCa40bMb31I0UEna5q3y
shyLnjwq50xgS256dNZpR9m0S/OxcZB+fN40cTBfE63fSeY+bjnrkc+ZlEoE9zxH
jMQo4QmIToAsw1LZDHSeCW6z8CrZaIusTnh8KyV2AFPmSxmRS8znhF9lAFU9QOWh
xG9wPNq5zai3Zkpr
=HQuh
-----END PGP SIGNATURE-----

L
L
Leo Prikler wrote on 11 Jul 2021 08:58
(name . Chris Marusich)(address . cmmarusich@gmail.com)(address . 49329@debbugs.gnu.org)
235456dfa9f27b6a3b612fb0a8d6e86aa4b5d362.camel@student.tugraz.at
Am Samstag, den 10.07.2021, 21:37 -0700 schrieb Chris Marusich:
Toggle quote (44 lines)
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> > development.scm
> > [...]
> > #t))
> > (replace 'wrap
> > (lambda* (#:key inputs outputs #:allow-other-keys)
> > - (wrap-program (string-append (assoc-ref outputs
> > "out")
> > - "/bin/renpy")
> > - `("PYTHONPATH" = (,(getenv "PYTHONPATH"))))
> > - #t)))))
> > + (let ((out (assoc-ref outputs "out"))
> > + (site (string-append "/lib/python"
> > + (python-version
> > + (assoc-ref inputs
> > "python"))
> > + "/site-packages")))
> > + (wrap-program (string-append out "/bin/renpy")
> > + `("PYTHONPATH" =
> > + (,@(delete-duplicates
> > + (map
> > + (lambda (store-path)
> > + (string-append store-path site))
> > + (cons (assoc-ref outputs "out")
> > + (map cdr
> > + (filter
> > + (lambda (input)
> > + (string-prefix? "python2"
> > (car input)))
> > + inputs))))))))
> > + #t))))))
>
> What's the motivation for doing this? It seems like the new version
> deletes duplicates, but has the downside of being a little more
> complicated and relying on the package names to determine what goes
> into
> the PYTHONPATH.
>
> Duplicate entries in the PYTHONPATH should not be a problem for
> correctness or performance, right? I feel like this section was
> perhaps
> better the way it was originally. Am I missing something?
The reason is that I want to avoid having native-inputs in PYTHONPATH
(which the naïve getenv-based solution will always return). For native
builds these currently can't be avoided even with the above snippet,
but for cross-builds and maybe future native-builds which separate
inputs and native-inputs, this ought to do "the correct thing".

delete-duplicates is more of a style thing than anything else, in my
personal opinion the wrapper script is more readable with it.

Regards,
Leo
L
L
Leo Prikler wrote on 11 Jul 2021 09:00
(name . Chris Marusich)(address . cmmarusich@gmail.com)(address . 49329@debbugs.gnu.org)
c0a0641ee1901cb9d8a85175f9d4b259635355ea.camel@student.tugraz.at
Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich:
Toggle quote (9 lines)
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > * gnu/packages/game-development.scm (python-pygame-sdl2): New
> > variable.
> > Inherit package definition from previous python2-pygame-sdl2, with
> > the
> > following additions:
>
> Actually, it inherits from python-pygame, right?
"Inherit" as in "use the code that was originally written for python2-
pygame-sdl2". Did the inherit field change with this patch? If so, I
should reflect it in the commit message.

Toggle quote (7 lines)
> > [source]: Also drop “gen3” in snippet.
> > [arguments]: Drop #:python.
> > [native-inputs]: Use ‘python-cython’ instead of ‘python2-cython’.
> > (python2-pygame-sdl2): Define in terms of python-pygame-sdl2.
>
> LGTM.
>
L
L
Leo Prikler wrote on 11 Jul 2021 09:03
(name . Chris Marusich)(address . cmmarusich@gmail.com)(address . 49329@debbugs.gnu.org)
af3157a9db0d5d6a5356a2d082248f491922eed4.camel@student.tugraz.at
Am Samstag, den 10.07.2021, 21:52 -0700 schrieb Chris Marusich:
Toggle quote (16 lines)
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > These sources are written in Ren'py (the language) and thus not
> > particularly
> > useful before renpy itself is built. In particular, they serve no
> > purpose
> > when installed without prior compilation.
>
> Could we pre-compile those sources on installation, instead of
> deleting
> the common directory? I haven't used Ren'Py much (or at all in
> Guix),
> so I don't really understand the purpose of the common directory. I
> could just be missing some context/info.
>
> Other than that, this patch seems OK as far as I can tell.
You need Ren'py (as in the package you're currently compiling) to
compile these sources. These sources will get compiled just fine in
the renpy package given that we already have python2-renpy available by
then, so they are shipped as part of that instead of this package.

Regards,
Leo
L
L
Leo Prikler wrote on 11 Jul 2021 09:09
(name . Chris Marusich)(address . cmmarusich@gmail.com)(address . 49329@debbugs.gnu.org)
f7416b08a973416f91440c62b55b8c2b5796c16d.camel@student.tugraz.at
Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich:
Toggle quote (34 lines)
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > * gnu/packages/game-development.scm (python2-renpy)[description]:
> > Mention,
> > that it's only used for bootstrapping renpy.
> > ---
> > gnu/packages/game-development.scm | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> > development.scm
> > index 22c44a585c..9b231ad333 100644
> > --- a/gnu/packages/game-development.scm
> > +++ b/gnu/packages/game-development.scm
> > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.")
> > ("xdg-utils" ,xdg-utils)))
> > (home-page "https://www.renpy.org/")
> > (synopsis "Ren'py python module")
> > - (description "This package contains the shared libraries and
> > Python
> > -modules of Ren'py.")
> > + (description "This package contains the shared libraries and
> > Python modules
> > +of Ren'py. While functional, they are not meaningful on their own
> > without
> > +the launcher and common Ren'py code provided by the @code{renpy}
> > package and
> > +are only used to bootstrap it.")
> > (license license:expat)))
> >
> > (define-public renpy
>
> LGTM. If this isn't meant to be installed by users, should it be
> non-public or perhaps hidden?
Good point, but I don't think users will accidentally install it like
they do with gcc. This description was written to address a point made
by Ludovic in IRC concerning the package's lack of one. Having the
package publicly exported also makes my own life easier when updating
the recipe. Last, but not least, these are functional modules and
could be used to develop code, that depends on Ren'py's internals, but
none of the "common" renpy stuff (or the common renpy stuff could
otherwise be extracted from the renpy package and changed to the
developer's desires).

Regards,
Leo
Z
Z
zimoun wrote on 11 Jul 2021 10:28
Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources.
86r1g5i7ai.fsf@gmail.com
Hi Leo,

On Sat, 03 Jul 2021 at 10:35, Leo Prikler <leo.prikler@student.tugraz.at> wrote:

Toggle quote (3 lines)
> I must admit, I haven't been following the Python 2 removal plan too
> closely. Is it already time to move working leaf packages?

The Python EOL is January, 1rst 2020 [1]. So now, we are 1.5 years
ahead, so yes it seems already time to cook a plan. :-)

However, there is no consensus about such plan. ;-) Some related
discussions:

2019-11: http://issues.guix.gnu.org/issue/38420 Failed attempt to cook something

From my understanding, the “implemented” plan is described by Maxim
here:


I just want to point that it is less work to transfer a functional and
supported by upstream package than to transfer a package starting to
have issues. Other said, I think it is easier to find motivation to do
the transfer for this previous case than to do some “janitor” work
later. For what my opinion is worth. :-)

About Ren’Py 7, I do not have an opinion. Yeah, waiting Ren’Py 8 seems
The Right Thing™ to do. :-)

Hope that helps,
simon

L
L
Leo Prikler wrote on 11 Jul 2021 11:53
794829194e7b95660ac164920bc62f68e14a0508.camel@student.tugraz.at
Hi simon,

Am Sonntag, den 11.07.2021, 10:28 +0200 schrieb zimoun:
Toggle quote (14 lines)
> Hi Leo,
>
> On Sat, 03 Jul 2021 at 10:35, Leo Prikler <
> leo.prikler@student.tugraz.at> wrote:
>
> > I must admit, I haven't been following the Python 2 removal plan
> > too
> > closely. Is it already time to move working leaf packages?
>
> The Python EOL is January, 1rst 2020 [1]. So now, we are 1.5 years
> ahead, so yes it seems already time to cook a plan. :-)
>
> However, there is no consensus about such plan. ;-) Some related
> discussions:
I know, but to be fair, we aren't the only ones behind on the Python
removal. Python 2 is very much a zombie at this point, still kept
alive by other (mostly dead, but some live) projects that people rely
on for various reasons.

Toggle quote (12 lines)
> 2019-10: <
> https://yhetil.org/guix/CAJ3okZ33HsXxgVgK3XyVHvYUfDUrbcwBnOn7FC6=3AG_YvAUbQ@mail.gmail.com/
> >
> 2019-11: <http://issues.guix.gnu.org/issue/38420> Failed attempt to
> cook something
> 2021-01: <https://yhetil.org/guix/86pn1pgf7z.fsf@gmail.com/>
>
> From my understanding, the “implemented” plan is described by Maxim
> here:
>
> <https://yhetil.org/guix/87pn1oxv0m.fsf@gmail.com/>
Using this plan as a starting point, I think renpy counts as a non-
variant package relying on some python2-variant.

Toggle quote (7 lines)
> I just want to point that it is less work to transfer a functional
> and
> supported by upstream package than to transfer a package starting to
> have issues. Other said, I think it is easier to find motivation to
> do
> the transfer for this previous case than to do some “janitor” work
> later. For what my opinion is worth. :-)
Fair enough, I could open up a merge request to have renpy in Guix Past
"ahead of time", but OTOH I feel like `guix time-machine` offers
similar benefits. If we're going to *mirror* python packages, because
they will soon be broken, I think it would also be a good idea to start
from python2 instead of leaf packages.

Regards,
Leo
C
C
Chris Marusich wrote on 15 Jul 2021 08:47
Re: bug#49329: [PATCH 00/??] Improve Ren'py package
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)
87h7gwysxn.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (20 lines)
>> From my understanding, the “implemented” plan is described by Maxim
>> here:
>>
>> <https://yhetil.org/guix/87pn1oxv0m.fsf@gmail.com/>
> Using this plan as a starting point, I think renpy counts as a non-
> variant package relying on some python2-variant.
>
>> I just want to point that it is less work to transfer a functional
>> and
>> supported by upstream package than to transfer a package starting to
>> have issues. Other said, I think it is easier to find motivation to
>> do
>> the transfer for this previous case than to do some “janitor” work
>> later. For what my opinion is worth. :-)
> Fair enough, I could open up a merge request to have renpy in Guix Past
> "ahead of time", but OTOH I feel like `guix time-machine` offers
> similar benefits. If we're going to *mirror* python packages, because
> they will soon be broken, I think it would also be a good idea to start
> from python2 instead of leaf packages.

I feel like keeping it all in Guix proper but vaguely "moving things
toward Python 3 wherever possible" is the best approach for now. An
approach like the one Maxim suggested in the above link sounds good.

Moving Ren'Py to Guix-Past would be fine, I guess, but I have to admit
it feels a little strange. After all, Ren'Py is neither stale nor
unmaintained. However, some of its dependencies are (like Python 2),
and their plan for upgrading to Python 3 sounds like it will take years.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv2gQVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadtMwQAI0zEp0oIlaHHD/t2Jl4lFTnjfG1
5eDhP77DI+Jx6S1Eza4H5E2A2dmYnkdEIvCV8Ar+YDb26qUn/OOCZrKZRnxQjIQN
YD4XgkCVpXx6S4ABPhVYYxSDjAExCfCIgn45Gs0gI+4bwzOV0meAatejc1dOPZ/P
PR8c9Y1rHTwfO//sfU2TuZ/Vo5VcLMWAvX2qx3kgtLLGVCQ8OLM2VUMQmzBPO2vW
5VKXeA8+gp9sNYETFVjbML8mOU6XMhiHos7FvJwtmopSRVpsoiyPI7NtbZNp80SL
gZEkdubNcb4sRPX+4qeRyniXyC9CUTglGBqapqDsKIFcLmwCTFqCi2KMzllDrV15
1T5JMrMmciopLpKcoUFAYyqz72SzLUBX6SNNjB6GdIClbEbX2nuXHN37OhQF32jk
tA1/L8uCC5ukRHbkDXsb35I2ChNpc2Xv2+5eqV0+kTSngSpt6pvr0IYKilC5zvho
ceLfOUXRTG7+qw3oPdXcXKXliVUocMLC2wROHdR6+0XcgEvaYNBHfAfexfyTY32g
6BoWv5jzAc/rlw5mf/fHxQaADhyJ828bu1MYVuL0O/VD9GHBRT0ilb4C5KwWsTBH
yHD6jBMBwRsOUt0LX7C4E/h3DJ0pLmb9eYLzfWL9qoXhQWedZfOxFjn6nQIUqM1V
H7M3t4myPFxl55qW
=f0bT
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 15 Jul 2021 08:48
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
87czrkysw6.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (45 lines)
> Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich:
>> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>>
>> > * gnu/packages/game-development.scm (python2-renpy)[description]:
>> > Mention,
>> > that it's only used for bootstrapping renpy.
>> > ---
>> > gnu/packages/game-development.scm | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
>> > development.scm
>> > index 22c44a585c..9b231ad333 100644
>> > --- a/gnu/packages/game-development.scm
>> > +++ b/gnu/packages/game-development.scm
>> > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.")
>> > ("xdg-utils" ,xdg-utils)))
>> > (home-page "https://www.renpy.org/")
>> > (synopsis "Ren'py python module")
>> > - (description "This package contains the shared libraries and
>> > Python
>> > -modules of Ren'py.")
>> > + (description "This package contains the shared libraries and
>> > Python modules
>> > +of Ren'py. While functional, they are not meaningful on their own
>> > without
>> > +the launcher and common Ren'py code provided by the @code{renpy}
>> > package and
>> > +are only used to bootstrap it.")
>> > (license license:expat)))
>> >
>> > (define-public renpy
>>
>> LGTM. If this isn't meant to be installed by users, should it be
>> non-public or perhaps hidden?
> Good point, but I don't think users will accidentally install it like
> they do with gcc. This description was written to address a point made
> by Ludovic in IRC concerning the package's lack of one. Having the
> package publicly exported also makes my own life easier when updating
> the recipe. Last, but not least, these are functional modules and
> could be used to develop code, that depends on Ren'py's internals, but
> none of the "common" renpy stuff (or the common renpy stuff could
> otherwise be extracted from the renpy package and changed to the
> developer's desires).

OK. I'm fine with that, then.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv2jkVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadVywP/iQEzsCmMrvu/B4xlzCFnjOHi9lw
n3bsl/jFaVkE5uTRBuTdhXPuxPuwV3wPVbkPF8Qm9d/0MMXSSm/chR0WXsRBEA3G
Tbno8VH6fSs8mYhD0+1TG4B0xAiXHCnmANbrN4wZelO0HpKZArNm0mwbJMXR95/e
m/KTlFtJQRXkKJiXy5tGfdaRhrLIRyZneuOi/vJRMTORIxLfZeQuBGkQCucJw9lc
1zT/TXiBqkK7XS+P7kD4fBUWkL82cwGq0GNKp3xxfEuz3CdCo4KuRQlbSwtRViKr
yU/mY8BeP7tLLBzfwsqc/tj8dHZ7d7TIY/lkK/5+fPhE0hOwUZ4IpYsKbY/ujaqC
jB1Lf3LFsfjh0WE6Rh5zEdQhIFQvg7vRcxdvJoS5RyFBtCNu7oWH4AKiOg3/EPok
6BVarsKTxH5FmAzRayZHNbd5bVKnYPBfI4GvqqrRRdHT2etn5Y89je9VAW/DD3Qt
DlDTBj7cpkrRyPDfxMGNwPmOaIT8CVkGdEFLgM6kx91gZ+IJoBqSRgxfUxRaaCc1
RUMshO2KDw/HTz0keJBRZUjPFDkdW2FCjatPLhN5Z6iY5hoEiKGZeXiba/am9Rk7
MV/+s/NP/S4WzCKRctGwaizvWU5FQX8qLdueWaWQB3bT3jJPlUuCmoBvpzcV3oCu
2WA3zEV+MKnoLuFX
=MStQ
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 15 Jul 2021 09:21
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
875yxcxcsw.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (14 lines)
> Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich:
>> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>>
>> > * gnu/packages/game-development.scm (python-pygame-sdl2): New
>> > variable.
>> > Inherit package definition from previous python2-pygame-sdl2, with
>> > the
>> > following additions:
>>
>> Actually, it inherits from python-pygame, right?
> "Inherit" as in "use the code that was originally written for python2-
> pygame-sdl2". Did the inherit field change with this patch? If so, I
> should reflect it in the commit message.

I see now what you mean. It's fine.

Personally, I think the word "re-use" would have been clearer, since it
is not possible to confuse it with the "inherit" feature of package
records.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv4e8VHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadpQ0P/2xDhdxsXZ6/VnWj2ahJR0f57alp
EjiVqCD2NjrqXTFrnsjwAgE0ghsJbMndAvbUxIkuCLTeNxkGXTebf91gSJQXOVB1
BZZSurVFiCt35aFRSGaKzLl60Rv/p51KTrQyrSEEicRklXHlAETFNGfyO70pNe9R
DgEqpqElTZ6CybqalwR1Dct3HFQ7gMtFS769z8hZO56YS68Ah2hGT0LraIP0Lof3
KXpld72akVHGbVe4OkVhm0pYq5ZNmuFCv5xAgT2J97GgpyTwuJ67tTYf/8X6ggti
PGGqmjxkKLK3nd/iil12lRl1+0XOJacKlF/+Q9XI+5hzk4zQExRtrNKFUJ8xZqWZ
FS+NG+uroyk+1KFVe8NT8xTm/d87PU8JWtktwpaFYGCmtceU9xeuO/IT7CyAIoO6
gkh1fLX1H34gvIvkRQxbkb1HjLUPLcAN44fFAykw9kAg95x+RcGSfFb0uDfZmOjp
e6t49fAdRihWoYpVpKH/uZIoxPkEp4HZ5ukf6ETs/F2xRV5emImqV/TTT6zoUmiZ
HpsIisCawaT+Wqr2+u9yGlHzcrZP8wl/P+qm9jLfwVmtXvgeVHBURf/obcCtNR6a
szK4fSguAq6OawQ57ZkGqgde/St55PFXqzW5DOH6wzPdzybFWXPuY8ZgglvTdqyB
pYPYMzkl4c4FLNGk
=Osuz
-----END PGP SIGNATURE-----

C
C
Chris Marusich wrote on 15 Jul 2021 09:22
(name . Leo Prikler)(address . leo.prikler@student.tugraz.at)(address . 49329@debbugs.gnu.org)
8735sgxcql.fsf_-_@gmail.com
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (22 lines)
> Am Samstag, den 10.07.2021, 21:52 -0700 schrieb Chris Marusich:
>> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>>
>> > These sources are written in Ren'py (the language) and thus not
>> > particularly
>> > useful before renpy itself is built. In particular, they serve no
>> > purpose
>> > when installed without prior compilation.
>>
>> Could we pre-compile those sources on installation, instead of
>> deleting
>> the common directory? I haven't used Ren'Py much (or at all in
>> Guix),
>> so I don't really understand the purpose of the common directory. I
>> could just be missing some context/info.
>>
>> Other than that, this patch seems OK as far as I can tell.
> You need Ren'py (as in the package you're currently compiling) to
> compile these sources. These sources will get compiled just fine in
> the renpy package given that we already have python2-renpy available by
> then, so they are shipped as part of that instead of this package.

OK, I think I understand. This seems fine.

--
Chris
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv4kIVHGNtbWFydXNp
Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadpHAP/2uLdOg43jOwyzcb1vCglW+JaK+g
gilegCueN0kiikfyD/jN8Sne7+s+BGyM0sQxltiXnaPPRKMQoWbliTdu2xl6HXWo
q+VCtlSQu1ZOuMIZkO2n2hq21utDgn05xuT/937ntmr5I6PfRHBvqNmysLWnaPAO
Zh8rOSRfHXGjVX3pmd7/GhF9wXkUbFj0zPA/4RMXoeGsY9ncak6YM1sqaXp/nSFy
1jEKJmsKiUpBmpyWJJ9jG+iQZlQ+mbaIziiCXRiCy37rJ+ERVr06al+xgYfnt502
PCvtM83skwZaFWoy76Zi7Kw5hfxjHRlBfvUC16+8EOhUAc+slAMLhKCt0NT3xwok
xm2LuzOubedYE1p2BKGk+3MU+guDGPlk/VsD1Hf9Bmd5At8QIL/Xtxo5aR7aEcr2
C80XAlH5NLGpYgz/YeM3PKmZ0h/TPRkM+URlFUta2D60EyYSnC2ACSHvIkbMg7YN
nvkZ5PAlSkCVf+Ilk5LBgjG5IXmLVwDJP/FfteG5Z6SAAOQGt/QEwoE//r/ycNYE
JdSE4cBSae2vwqyhtraCKI1iV5r77XVOLTWxr6SNq+dXTEd2WO71EMj31aQmQJac
O/+wS8h9OkPjAdFs0+AeLdglx3TkYkaJMfSEubBUkQ8aAR/Iul6cU62CFigD0JoX
RWZbBSZ+YnRkdVMC
=cw3l
-----END PGP SIGNATURE-----

L
L
Leo Prikler wrote on 15 Jul 2021 13:46
(name . Chris Marusich)(address . cmmarusich@gmail.com)(address . 49329-done@debbugs.gnu.org)
26e29ba3e5a2514d340eab8d49dcb838c4f8224c.camel@student.tugraz.at
Am Donnerstag, den 15.07.2021, 00:21 -0700 schrieb Chris Marusich:
Toggle quote (25 lines)
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich:
> > > Leo Prikler <leo.prikler@student.tugraz.at> writes:
> > >
> > > > * gnu/packages/game-development.scm (python-pygame-sdl2): New
> > > > variable.
> > > > Inherit package definition from previous python2-pygame-sdl2,
> > > > with
> > > > the
> > > > following additions:
> > >
> > > Actually, it inherits from python-pygame, right?
> > "Inherit" as in "use the code that was originally written for
> > python2-
> > pygame-sdl2". Did the inherit field change with this patch? If
> > so, I
> > should reflect it in the commit message.
>
> I see now what you mean. It's fine.
>
> Personally, I think the word "re-use" would have been clearer, since
> it
> is not possible to confuse it with the "inherit" feature of package
> records.
I've changed the commit message to say "reuse" and pushed this now.
Thanks!
Closed
?