brdf-explorer assumes #!/bin/sh exists

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Maxime Devos
Owner
unassigned
Submitted by
Maxime Devos
Severity
normal
M
M
Maxime Devos wrote on 2 Jul 2021 10:16
(address . bug-guix@gnu.org)
290ba406313d5aafd6b76860630365eb411a9569.camel@telenet.be
Hi guix,

From the package definition of "brdf-explorer":

(format port "#!/bin/sh
# Run the thing from its home, otherwise it just bails out.
cd \"~a\"
exec -a \"$0\" ~a/.brdf-real~%" ...)

That should be #!/gnu/store/.../bin/sh instead ...

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iIsEABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYN7LRRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pFcAPj7XZfQuNA79lgVO2a6aTysLlt7
SqIeA69gk1gx42GjAPixyKhyCnv9uXCmPwDw/HF9d95Vj1468T3dBXB6zjwJ
=XRhF
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 19 Jul 2021 16:26
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 49325@debbugs.gnu.org)
87v956nzwb.fsf@gnu.org
Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (9 lines)
> From the package definition of "brdf-explorer":
>
> (format port "#!/bin/sh
> # Run the thing from its home, otherwise it just bails out.
> cd \"~a\"
> exec -a \"$0\" ~a/.brdf-real~%" ...)
>
> That should be #!/gnu/store/.../bin/sh instead ...

No, it’s OK, because the ‘patch-shebangs’ phase kicks in right after
that and fixes it:

Toggle snippet (5 lines)
$ head -2 $(guix build brdf-explorer)/bin/brdf
#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
# Run the thing from its home, otherwise it just bails out.

Ludo’.
L
L
Ludovic Courtès wrote on 19 Jul 2021 16:26
control message for bug #49325
(address . control@debbugs.gnu.org)
87tukqnzw2.fsf@gnu.org
tags 49325 notabug
close 49325
quit
?