[PATCH] gnu: Add aspell-dict-ro.

  • Done
  • quality assurance status badge
Details
2 participants
  • Julien Lepiller
  • Sergiu Ivanov
Owner
unassigned
Submitted by
Sergiu Ivanov
Severity
normal
S
S
Sergiu Ivanov wrote on 29 Apr 2021 10:17
(address . guix-patches@gnu.org)
87czudzeri.fsf@colimite.fr
Dear Guix,

Please find attached my first ever patch adding the Romanian
aspell dictionary.

The addition seems very simple and I tested building and installing it
in my custom channel and building within a Git checkout of Guix.

Do tell me if there are any improvement opportunities, I am here to
learn :-)

-
Sergiu
From 2188a7e01a024fafadfa62b9bd37803fa73b9a98 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <sivanov@colimite.fr>
Date: Tue, 27 Apr 2021 21:33:11 +0200
Subject: [PATCH] gnu: Add aspell-dict-ro.

---
gnu/packages/aspell.scm | 8 ++++++++
1 file changed, 8 insertions(+)

Toggle diff (21 lines)
diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 26c0cf4332..99e878e08a 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -356,6 +356,14 @@ dictionaries, including personal ones.")
(base32
"137i4njvnslab6l4s291s11xijr5jsy75lbdph32f9y183lagy9m")))
+(define-public aspell-dict-ro
+ (aspell-dictionary "ro" "Romanian"
+ #:version "3.3-2"
+ #:prefix "aspell5-"
+ #:sha256
+ (base32
+ "0gb8j9iy1acdl11jq76idgc2lbc1rq3w04favn8cyh55d1v8phsk")))
+
;;;
;;; Hunspell packages made from the Aspell word lists.
--
2.31.1
J
J
Julien Lepiller wrote on 30 Apr 2021 12:54
(name . Sergiu Ivanov)(address . sivanov@colimite.fr)(address . 48101-done@debbugs.gnu.org)
20210430125416.1cec31e1@tachikoma.lepiller.eu
Le Thu, 29 Apr 2021 10:17:05 +0200,
Sergiu Ivanov <sivanov@colimite.fr> a écrit :

Toggle quote (14 lines)
> Dear Guix,
>
> Please find attached my first ever patch adding the Romanian
> aspell dictionary.
>
> The addition seems very simple and I tested building and installing it
> in my custom channel and building within a Git checkout of Guix.
>
> Do tell me if there are any improvement opportunities, I am here to
> learn :-)
>
> -
> Sergiu

Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
changes:

I added a copyright line for you at the top of the file.

There was an alignment issue, caused by tabulations. I replaced them
with spaces (please don't use tabs).

You should be able to use the package after running "guix pull". Thanks
for your contribution!
Closed
S
S
Sergiu Ivanov wrote on 30 Apr 2021 15:17
(name . Julien Lepiller)(address . julien@lepiller.eu)(address . 48101-done@debbugs.gnu.org)
87o8dvx66g.fsf@colimite.fr
Thus quoth Julien Lepiller on Fri Apr 30 2021 at 12:54 (+0200):
Toggle quote (22 lines)
> Le Thu, 29 Apr 2021 10:17:05 +0200,
> Sergiu Ivanov <sivanov@colimite.fr> a écrit :
>
>> Dear Guix,
>>
>> Please find attached my first ever patch adding the Romanian
>> aspell dictionary.
>>
>> The addition seems very simple and I tested building and installing it
>> in my custom channel and building within a Git checkout of Guix.
>>
>> Do tell me if there are any improvement opportunities, I am here to
>> learn :-)
>>
>> -
>> Sergiu
>
> Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
> changes:
>
> I added a copyright line for you at the top of the file.

Oh, thank you, I completely forgot about that!

Toggle quote (3 lines)
> There was an alignment issue, caused by tabulations. I replaced them
> with spaces (please don't use tabs).

Ooops, sorry, I've just disabled tabs in my Emacs configuration.
Not sure why I kept them enabled anyway.

Toggle quote (3 lines)
> You should be able to use the package after running "guix pull". Thanks
> for your contribution!

Thank you for your time!
Closed
?