[PATCH] Add package: ibus-chewing

  • Open
  • quality assurance status badge
Details
2 participants
  • Guu, Jin-Cheng
  • Raghav Gururajan
Owner
unassigned
Submitted by
Guu, Jin-Cheng
Severity
normal
G
G
Guu, Jin-Cheng wrote on 19 Apr 2021 02:02
(address . guix-patches@gnu.org)
CAErjG5c9zLn24hd0wPUdkHcDPuNzKu5YdBZJkMJ6iZjrKJ8HnA@mail.gmail.com
Hello all,

Attached is my first patch to guix. It's for the package
`ibus-chewing`, an IBus front-end of Chewing, which is an intelligent
Chinese input method for Zhuyin (BoPoMoFo) users. A dependency `gob`
is also added. Hopefully, this will attract more Chinese users to
guix.

Special thanks for their patience and guides to nckx and
raghavgururajan on #guix. Most of the code work came from
raghavgururajan.

Regards,
Jin
Attachment: 0001-gnu-Add-gob-and-ibus-chewing.patch
R
R
Raghav Gururajan wrote on 19 Apr 2021 14:21
(address . 47884@debbugs.gnu.org)
0a063953-4699-72e5-ead5-3d9bea22f7b9@raghavgururajan.name
Hi Jin-Cheng!

Congratulations on your first patch. \o/

You don't have to under-sell your work. I just cleaned up the pack-def
and fixed the glib schema error. All others are your work. :-)

Also, if anyone helps you with code/snippet in #guix, you don't have to
use the same code/snippet. You are free to adopt them in any way you see
fit. Folks usually share a code/snippet, purely for informational purposes.

REVIEW:

[1] As Julien mentioned in #guix, it is better to make two patches, one
for dependency package and one for the main package.

[2] Package gob appears to be a candidate for glib.scm. So its better to
move this package to glib.scm.

[3] In Guix, we try to avoid bundled stuff, for better security and
reproducibilty. It'd be great if you package cmake-fedora separately
(like gob) and remove the use of `recursive? #t`, in ibus-chewing.

As usual, if you have any questions, feel to free to ask around in
#guix. ;-)

Regards,
RG.
Attachment: OpenPGP_signature
?