Hello all, Attached is my first patch to guix. It's for the package`ibus-chewing`, an IBus front-end of Chewing, which is an intelligentChinese input method for Zhuyin (BoPoMoFo) users. A dependency `gob`is also added. Hopefully, this will attract more Chinese users toguix. Special thanks for their patience and guides to nckx andraghavgururajan on #guix. Most of the code work came fromraghavgururajan. Regards,Jin
From bb226b2680d5b66a863ff234d2d0a6207f7f8cb0 Mon Sep 17 00:00:00 2001From: jcguu95 <firstname.lastname@example.org>Date: Sun, 18 Apr 2021 18:32:00 -0500Subject: [PATCH] gnu: Add gob and ibus-chewing. * gnu/packages/ibus.scm: Add two packages: gob and ibus-chewing.--- gnu/packages/ibus.scm | 138 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 138 insertions(+)
Hi Jin-Cheng! Congratulations on your first patch. \o/ You don't have to under-sell your work. I just cleaned up the pack-def and fixed the glib schema error. All others are your work. :-) Also, if anyone helps you with code/snippet in #guix, you don't have to use the same code/snippet. You are free to adopt them in any way you see fit. Folks usually share a code/snippet, purely for informational purposes. REVIEW:  As Julien mentioned in #guix, it is better to make two patches, one for dependency package and one for the main package.  Package gob appears to be a candidate for glib.scm. So its better to move this package to glib.scm.  In Guix, we try to avoid bundled stuff, for better security and reproducibilty. It'd be great if you package cmake-fedora separately (like gob) and remove the use of `recursive? #t`, in ibus-chewing. As usual, if you have any questions, feel to free to ask around in #guix. ;-) Regards,RG.