[PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.

DoneSubmitted by Masaya Tojo.
Details
3 participants
  • Ludovic Courtès
  • Masaya Tojo
  • Maxime Devos
Owner
unassigned
Severity
normal
M
M
Masaya Tojo wrote on 8 Apr 19:25 +0200
(address . guix-patches@gnu.org)(name . Masaya Tojo)(address . masaya@tojo.tokyo)
20210408172526.24437-1-masaya@tojo.tokyo
* gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change fromguile-lib to guile2.2-lib.--- gnu/packages/guile-xyz.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Toggle diff (24 lines)diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scmindex e2ee5454a0..75256e0f11 100644--- a/gnu/packages/guile-xyz.scm+++ b/gnu/packages/guile-xyz.scm@@ -28,7 +28,7 @@ ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us> ;;; Copyright © 2020 Julien Lepiler <julien@lepiller.eu> ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>-;;; Copyright © 2020 Masaya Tojo <masaya@tojo.tokyo>+;;; Copyright © 2020, 2021 Masaya Tojo <masaya@tojo.tokyo> ;;; Copyright © 2020 Jesse Gibbons <jgibbons2357@gmail.com> ;;; Copyright © 2020 Mike Rosset <mike.rosset@gmail.com> ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>@@ -3519,7 +3519,7 @@ feature-set, fully programmable in Guile Scheme.") texlive-fonts-iwona))) ("pkg-config" ,pkg-config))) (propagated-inputs- `(("guile-lib" ,guile-lib)))+ `(("guile-lib" ,guile2.2-lib))) (home-page "https://www.gnu.org/software/guile-cv/") (synopsis "Computer vision library for Guile") (description "Guile-CV is a Computer Vision functional programming library-- 2.31.1
M
M
Maxime Devos wrote on 8 Apr 22:05 +0200
49f68d34c83f414b48f1a97bff7113426f12a412.camel@telenet.be
On Fri, 2021-04-09 at 02:25 +0900, Masaya Tojo wrote:
Toggle quote (3 lines)> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from> guile-lib to guile2.2-lib.
I believe the current naming convention for guile packages is:
* guile1.8-PACKAGE: for guile@1.8* guile2.0-PACKAGE: for guile@2.0* guile2.2-PACKAGE: for guile@2.2* guile-PACKAGE: for guile@3.0
... though this is not always adhered to. Basically, ‘we’ want to usethe latest version of guile by default.
So I would suggest:
A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'. But perhaps guile-cv does not (yet) support guile-3.0 (there have been a few incompatible 2.2 -> 3.0 changes)orB: your patch, and rename guile-cv to guile2.2-cv.
Greetings,Maxime.
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYG9iGBccbWF4aW1lZGV2b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gtkAP0RvtJoMt8GK/XKITnv594fWyGIonH3EGZuCy2Z9JK56wD7BgAFOAsY5GneFMFZN+lpAgioqL/RGt46ccHpfta3/AI==GJP2-----END PGP SIGNATURE-----

M
M
Masaya Tojo wrote on 9 Apr 16:36 +0200
87zgy7h6d8.fsf@tojo.tokyo
Hello,
Toggle quote (6 lines)> A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'. But perhaps> guile-cv does not (yet) support guile-3.0 (there have been a few incompatible> 2.2 -> 3.0 changes)> or> B: your patch, and rename guile-cv to guile2.2-cv.
I tested to build guile-cv with guile-3.0. But guile-cv's test isfailed, so your suggesion A is not easy.
Therefore, I think suggesion B is better.
Best Regards,
--Masaya Tojo
L
L
Ludovic Courtès wrote on 9 Apr 17:28 +0200
Re: bug#47659: [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
(name . Masaya Tojo)(address . masaya@tojo.tokyo)
871rbj5vf7.fsf@gnu.org
Hi,
Masaya Tojo <masaya@tojo.tokyo> skribis:
Toggle quote (3 lines)> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from> guile-lib to guile2.2-lib.
I agree with Maxime that Guile 3.0 would be best, but in the meantime,your patch looks like the right thing.
Applied, thanks!
Ludo’.
Closed
?