[PATCH 0/1] Update rtl8812au-aircrack-ng-linux-module

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • David Dashyan
Owner
unassigned
Submitted by
David Dashyan
Severity
normal

Debbugs page

David Dashyan wrote 4 years ago
(address . guix-patches@gnu.org)(name . David Dashyan)(address . mail@davie.li)
20210329150630.4905-1-mail@davie.li
Hello Guix!

After kernel upgrade aircrack module stoped building succesfully again.
Here is my version bump.

I've been using updated package for several days, seems fine.
I think fix was introduced in this pr:

Toggle quote (2 lines)
Here is the original traceback:
Toggle quote (18 lines)
> CC [M] /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/os_dep/linux/ioctl_cfg80211.o
> /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/os_dep/linux/ioctl_cfg80211.c: In function 'rtw_cfg80211_ch_switch_notify':
> /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/os_dep/linux/ioctl_cfg80211.c:458:3: error: too few arguments to function 'cfg80211_ch_switch_started_notify'
> cfg80211_ch_switch_started_notify(adapter->pnetdev, &chdef, 0);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/include/osdep_service_linux.h:97:0,
> from /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/include/osdep_service.h:58,
> from /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/include/drv_types.h:26,
> from /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/os_dep/linux/ioctl_cfg80211.c:17:
> ./include/net/cfg80211.h:7585:6: note: declared here
> void cfg80211_ch_switch_started_notify(struct net_device *dev,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> make[2]: *** [scripts/Makefile.build:279: /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout/os_dep/linux/ioctl_cfg80211.o] Error 1
> make[1]: *** [Makefile:1806: /tmp/guix-build-rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003.drv-0/rtl8812au-aircrack-ng-linux-module-5.6.4.2-3.62cb003-checkout] Error 2
> make[1]: Leaving directory '/gnu/store/j95f6n74j98zn2an26kwbqimxfmz3dx7-linux-libre-module-builder-5.11.7/lib/modules/build'
> make: *** [Makefile:2246: modules] Error 2
> command "make" "KSRC=/gnu/store/j95f6n74j98zn2an26kwbqimxfmz3dx7-linux-libre-module-builder-5.11.7/lib/modules/build" failed with status 2

David Dashyan (1):
gnu: rtl8812au-aircrack-ng-linux-module: Update to 5.6.4.2-4.059e06a

gnu/packages/linux.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 099026df5ba6443a9291e8f9d91ccacfdce2f00d
--
2.30.1
David Dashyan wrote 4 years ago
[PATCH 1/1] gnu: rtl8812au-aircrack-ng-linux-module: Update to 5.6.4.2-4.059e06a
(address . 47469@debbugs.gnu.org)(name . David Dashyan)(address . mail@davie.li)
20210329151304.5189-1-mail@davie.li
---
gnu/packages/linux.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 80afd125d9..7704c4b4f0 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -1135,8 +1135,8 @@ and should be used with caution, especially on untested models.")
(license license:gpl3+))) ; see README.md (no licence headers)
(define-public rtl8812au-aircrack-ng-linux-module
- (let ((commit "62cb003043e4daeeba0b8805137fa604af450ed2")
- (revision "3"))
+ (let ((commit "059e06a51be025fde5b2bec6565540b3d9981b0b")
+ (revision "4"))
(package
(name "rtl8812au-aircrack-ng-linux-module")
(version (git-version "5.6.4.2" revision commit))
@@ -1148,7 +1148,7 @@ and should be used with caution, especially on untested models.")
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1kragxkjprjy7nl9h2rd0mwcry1ygw07zb1p2qkj7cmz0r2035yz"))
+ (base32 "0h6l2r3yj7j9zf11dw0zcdyn50ajnjw8yvv86dzlfj80dn75n98f"))
(modules '((guix build utils)))
(snippet
'(begin
--
2.30.1
Leo Famulari wrote 4 years ago
Re: [bug#47469] [PATCH 0/1] Update rtl8812au-aircrack-ng-linux-module
(name . David Dashyan)(address . mail@davie.li)(address . 47469-done@debbugs.gnu.org)
YGIDdg8iySgjTWzb@jasmine.lan
On Mon, Mar 29, 2021 at 06:06:30PM +0300, David Dashyan wrote:
Toggle quote (3 lines)
> After kernel upgrade aircrack module stoped building succesfully again.
> Here is my version bump.

Thanks for the patch!

Toggle quote (5 lines)
> I've been using updated package for several days, seems fine.
> I think fix was introduced in this pr:
>
> > https://github.com/aircrack-ng/rtl8812au/pull/811

And thanks for saying that you've tested it, and the pointer to upstream
discussion.

This is exactly the information that reviewers want to know :) By
including this information, the review process is accelerated.

Pushed as a8bbda7f941ef1cd60972e24455cd50ab5c63706
Closed
David Dashyan wrote 4 years ago
(name . Leo Famulari)(address . leo@famulari.name)
87zgyhkkyu.fsf@davie.li
Leo Famulari writes:

Toggle quote (8 lines)
> And thanks for saying that you've tested it, and the pointer to upstream
> discussion.
>
> This is exactly the information that reviewers want to know :) By
> including this information, the review process is accelerated.
>
> Pushed as a8bbda7f941ef1cd60972e24455cd50ab5c63706

Great! <3

--
David aka zzappie
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 47469@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 47469
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help