guile2.2-bytestructures fails to compile.

  • Done
  • quality assurance status badge
Details
4 participants
  • Ludovic Courtès
  • Maxime Devos
  • Taylan Kammer
  • zimoun
Owner
unassigned
Submitted by
Maxime Devos
Severity
normal
M
M
Maxime Devos wrote on 1 Mar 2021 09:06
(address . bug-guix@gnu.org)
3f495538d371826b84b9ec6864503c60844c1d95.camel@telenet.be
Hi Guix,

guile2.2-bytestructures and guile2.0-bytestructures don't compile.
The reason seems to be that v1.0.9 uses (scheme eval), which isn't
defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)

Here's the commit that seems to introduce the issue while fixing
another:

guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures

According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
"guile2.2-parted" and "guile2.2-guix" depend on these packages,
so unless someone needs "guile2.2-guix", it should be safe to remove
these packages.

Greetings,
Maxime.

(This issue prevents creating an environment for https://issues.guix.gnu.org/46826)
-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYDygmhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7o50AP9cx1z24oHKVTMUkl+uk8Qq2Ip2
qQn67vse1csfi1o5KgEAv8dJLkQLchNdukeGl63IC0R43Pvd0M07r7vHbMux3gc=
=Hwtx
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 1 Mar 2021 15:14
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 46844@debbugs.gnu.org)
87h7lvrmfc.fsf@gnu.org
Hi,

Maxime Devos <maximedevos@telenet.be> skribis:

Toggle quote (4 lines)
> guile2.2-bytestructures and guile2.0-bytestructures don't compile.
> The reason seems to be that v1.0.9 uses (scheme eval), which isn't
> defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)

Perhaps worth reporting upstream.

Toggle quote (11 lines)
> Here's the commit that seems to introduce the issue while fixing
> another:
>
> guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures
>
> According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
> on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
> "guile2.2-parted" and "guile2.2-guix" depend on these packages,
> so unless someone needs "guile2.2-guix", it should be safe to remove
> these packages.

‘guile2.2-guix’ exists mostly to check compatibility with 2.2. I’d like
to drop 2.2 support soonish, though it’s okay to keep as long as it’s
not a burden (which it’s slowly becoming).

Thanks,
Ludo’.
T
T
Taylan Kammer wrote on 1 Mar 2021 15:47
Re: bug#46844: guile2.2-bytestructures fails to compile.
d7e52a55-58bd-4dc1-47c8-fd0f58434793@gmail.com
On 01.03.2021 09:06, Maxime Devos wrote:
Toggle quote (23 lines)
> Hi Guix,
>
> guile2.2-bytestructures and guile2.0-bytestructures don't compile.
> The reason seems to be that v1.0.9 uses (scheme eval), which isn't
> defined in guile2.0 and guile2.2. v1.0.8 doesn't use (scheme eval)
>
> Here's the commit that seems to introduce the issue while fixing
> another:
>
> guix time-machine --commit=0a1da4652d9bb93d530ca52710f30b5d05a4251d -- build guile2.0-bytestructures guile2.2-bytestructures
>
> According to a "guix refresh --list-dependent guile2.0-bytestructures guile2.2-bytestructures"
> on 372b15f8625e7f20cafdba2677d4bf3f5eccc127, only "guile2.0-git",
> "guile2.2-parted" and "guile2.2-guix" depend on these packages,
> so unless someone needs "guile2.2-guix", it should be safe to remove
> these packages.
>
> Greetings,
> Maxime.
>
> (This issue prevents creating an environment for https://issues.guix.gnu.org/46826)
>

Thanks for the report, I'm looking into it.

Actually 1.0.8 is the first version that uses '(scheme eval)' and 1.0.9
only makes a change to the environment argument passed to 'eval'. I'm
assuming that the last working version was 1.0.7.

The reason '(scheme eval)' is needed is that I use the 'environment'
procedure to create an environment object to be passed as the second
argument to 'eval'.

I suppose I could instead use 'resolve-module' which should work across
2.x and 3.x.

I'll report as soon as I have an update.


- Taylan
T
T
Taylan Kammer wrote on 3 Mar 2021 15:56
13c054b7-223d-42b3-cc4c-b58609013cf5@gmail.com
On 01.03.2021 15:47, Taylan Kammer wrote:
Toggle quote (2 lines)
> I'll report as soon as I have an update.

I just released 1.0.10 which should work across Guile 2.0, 2.2, and 3.0.

I haven't yet updated the Guix package for bytestructures. I'm quite
out of the loop and don't remember which branch that should be pushed,
given it's a dependency of Guix and all. Is it always safe to push to
master? (With regard to rebuilding the whole world.)

- Taylan
M
M
Maxime Devos wrote on 5 Mar 2021 16:36
b1ae67cabdb8e2d6c6cb816cddd53e4bc32d5510.camel@telenet.be
On Wed, 2021-03-03 at 15:56 +0100, Taylan Kammer wrote:
Toggle quote (7 lines)
> On 01.03.2021 15:47, Taylan Kammer wrote:
> [...]
> I haven't yet updated the Guix package for bytestructures. I'm quite
> out of the loop and don't remember which branch that should be pushed,
> given it's a dependency of Guix and all. Is it always safe to push to
> master? (With regard to rebuilding the whole world.)

Let's see what would be rebuilt:

$ guix refresh --list-dependent guile-bytestructures guile2.0-bytestructures guile2.2-bytestructures

Building the following 15 packages would ensure 19 dependent packages are rebuilt: guile-wiredtiger@0.7.0 guile-libyaml@0-1.f5d33a6
guile-parted@0.0.4 guix-data-service@0.0.1-25.b7ba8d0 guix-minimal@1.2.0-13.a53f711 cuirass@0.0.1-72.543e26a emacs-guix@0.5.2-3.a694fdb
guix-jupyter@0.2.1 guix-build-coordinator@0-20.1f79fc3 gwl@0.3.0 hpcguix-web@0.0.1-5.9de6356 guix-daemon@1.2.0-13.a53f711
guile2.0-git@0.4.0 guile2.2-parted@0.0.4 guile2.2-guix@1.2.0-13.a53f711

I suggest you run "./pre-inst-env guix build guix" first to make sure guix can still
be built, but otherwise there shouldn't be any issue with pushing to master.

Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYEJQBxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gHmAPwOy7qpsrUvXwbLjBw86UKj9dB/
VsaW5ZtaVED4JA+kzgD/c2VFjfDAuDYWIcM3VEke1uMRUnT+SyKXQvijLZjh4g4=
=07bb
-----END PGP SIGNATURE-----


T
T
Taylan Kammer wrote on 10 Mar 2021 20:10
71c3a56c-b039-1242-95dd-1c8eaacd664e@gmail.com
I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
and guile2.2-bytestructures builds for me.

- Taylan
Z
Z
zimoun wrote on 10 Mar 2021 21:12
(address . 46844-done@debbugs.gnu.org)
CAJ3okZ207T76wO-p13S66wp+aGxjts6aAWZYQC0n21tS+PWG2w@mail.gmail.com
Hi,

On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:

Toggle quote (3 lines)
> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
> and guile2.2-bytestructures builds for me.

Just to say that the commit breaks "guix pull".


Cheers,
simon
T
T
Taylan Kammer wrote on 10 Mar 2021 21:55
(address . 46844-done@debbugs.gnu.org)
41e96e07-2525-11ef-aaf2-d6f8824b6ca8@gmail.com
On 10.03.2021 21:12, zimoun wrote:
Toggle quote (9 lines)
> Hi,
>
> On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:
>
>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
>> and guile2.2-bytestructures builds for me.
>
> Just to say that the commit breaks "guix pull".

Ugh, sorry. Looking into it now.


- Taylan
T
T
Taylan Kammer wrote on 10 Mar 2021 22:11
41aee6f6-b4ae-f033-0f57-a3910d53dc59@gmail.com
On 10.03.2021 21:55, Taylan Kammer wrote:
Toggle quote (10 lines)
> On 10.03.2021 21:12, zimoun wrote:
>> Hi,
>>
>> On Wed, 10 Mar 2021 at 20:12, Taylan Kammer <taylan.kammer@gmail.com> wrote:
>>
>>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
>>> and guile2.2-bytestructures builds for me.
>>
>> Just to say that the commit breaks "guix pull".

Hmm, I can't seem to reproduce. Guix pull finished successfully for
commit 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6 (two commits after mine).

tkammer@debian:~/src/guix$ guix --version
guix (GNU Guix) 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6
Copyright (C) 2021 the Guix authors
License GPLv3+: GNU GPL version 3 or later
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Z
Z
zimoun wrote on 10 Mar 2021 22:44
(name . Taylan Kammer)(address . taylan.kammer@gmail.com)
CAJ3okZ34aX0=wU9z8qAokwTp40=2AKz__fJcD4zboEsf=ECGFQ@mail.gmail.com
Hi,

On Wed, 10 Mar 2021 at 22:11, Taylan Kammer <taylan.kammer@gmail.com> wrote:

Toggle quote (8 lines)
> >>> I just pushed the update to guile-bytestructures 1.0.10 to Guix master,
> >>> and guile2.2-bytestructures builds for me.
> >>
> >> Just to say that the commit breaks "guix pull".
>
> Hmm, I can't seem to reproduce. Guix pull finished successfully for
> commit 6c5d358cc25ca94d9c0c75a3a086e81b2d63d1b6 (two commits after mine).

No worry and all is explained there:


Cheers,
simon
?