make check FAILs: publish.scm store.scm

  • Done
  • quality assurance status badge
Details
3 participants
  • Leo Famulari
  • Maxim Cournoyer
  • Sanne Wouda
Owner
unassigned
Submitted by
Sanne Wouda
Severity
normal
S
S
Sanne Wouda wrote on 25 Feb 2021 15:51
(address . bug-guix@gnu.org)
88ece1ae-9074-4dc5-a079-b71ed906ae0c@www.fastmail.com
I'm seeing two failures when running the guix test suite on HEAD (c1da9829f8b6)

publish.scm "with cache" fails on line 456:

(= #o644 (stat:perms (lstat nar)))

which seems to be due to umask:

$ umask
0002

If I set umask to 022, the test passes.

The second failure is a crash in store.scm, which appears to be due to %shell being initialized to #f. I run make check inside guix environment guix --pure . Before running make check, SHELL=/bin/bash , so I'm not sure how (getenv "SHELL") would return #f.
L
L
Leo Famulari wrote on 2 Mar 2021 22:51
(name . Sanne Wouda)(address . yt@dutchman.dev)(address . 46772@debbugs.gnu.org)
YD6zbBin/J8aA7yA@jasmine.lan
On Thu, Feb 25, 2021 at 02:51:29PM +0000, Sanne Wouda wrote:
Toggle quote (13 lines)
> I'm seeing two failures when running the guix test suite on HEAD (c1da9829f8b6)
>
> publish.scm "with cache" fails on line 456:
>
> (= #o644 (stat:perms (lstat nar)))
>
> which seems to be due to umask:
>
> $ umask
> 0002
>
> If I set umask to 022, the test passes.

I wonder if this is the same as https://bugs.gnu.org/46413

Toggle quote (2 lines)
> The second failure is a crash in store.scm, which appears to be due to %shell being initialized to #f. I run make check inside guix environment guix --pure . Before running make check, SHELL=/bin/bash , so I'm not sure how (getenv "SHELL") would return #f.

I submitted a patch for this:

M
M
Maxim Cournoyer wrote on 17 Nov 13:26 +0100
(name . Leo Famulari)(address . leo@famulari.name)
87wmh2dp28.fsf@gmail.com
Hello,

Leo Famulari <leo@famulari.name> writes:

Toggle quote (25 lines)
> On Thu, Feb 25, 2021 at 02:51:29PM +0000, Sanne Wouda wrote:
>> I'm seeing two failures when running the guix test suite on HEAD (c1da9829f8b6)
>>
>> publish.scm "with cache" fails on line 456:
>>
>> (= #o644 (stat:perms (lstat nar)))
>>
>> which seems to be due to umask:
>>
>> $ umask
>> 0002
>>
>> If I set umask to 022, the test passes.
>
> I wonder if this is the same as <https://bugs.gnu.org/46413>
>
>> The second failure is a crash in store.scm, which appears to be due
>> to %shell being initialized to #f. I run make check inside guix
>> environment guix --pure . Before running make check, SHELL=/bin/bash
>> , so I'm not sure how (getenv "SHELL") would return #f.
>
> I submitted a patch for this:
>
> https://bugs.gnu.org/46445

This was merged and tests/publish.scm passes on master. Closing.

--
Thanks,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 46772@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 46772
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch