[PATCH 1/3] gnu: ghc-protolude: Update to 0.3.0.

  • Done
  • quality assurance status badge
Details
3 participants
  • Léo Le Bouter
  • Stefan Reichör
  • zimoun
Owner
unassigned
Submitted by
Stefan Reichör
Severity
normal
Merged with
S
S
Stefan Reichör wrote on 19 Feb 2021 21:04
(address . guix-patches@gnu.org)(name . Stefan Reichör)(address . stefan@xsteve.at)
20210219200427.105200-1-stefan@xsteve.at
* gnu/packages/haskell-xyz.scm (ghc-protolude): Update to 0.3.0.
---
gnu/packages/haskell-xyz.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (32 lines)
diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index d6c50ade71..f1709e342a 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -28,6 +28,7 @@
;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407@member.fsf.org>
;;; Copyright © 2020 Carlo Holl <carloholl@gmail.com>
;;; Copyright © 2020 Christopher Lemmer Webber <cwebber@dustycloud.org>
+;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -10535,7 +10536,7 @@ the ideal templating system.")
(define-public ghc-protolude
(package
(name "ghc-protolude")
- (version "0.2.3")
+ (version "0.3.0")
(source
(origin
(method url-fetch)
@@ -10545,7 +10546,7 @@ the ideal templating system.")
".tar.gz"))
(sha256
(base32
- "0zzkyxz0vmcbncpid7gp72fpjj0fla3gqhlfkij5c5lg12skjgfj"))))
+ "1b6wprbwfdjyvds2bm6na0fbqgzdkj5ikkk33whbkyh3krd3i0s0"))))
(build-system haskell-build-system)
(inputs
`(("ghc-async" ,ghc-async)
--
2.25.1
L
L
Léo Le Bouter wrote on 24 Feb 2021 15:11
(address . control@debbugs.gnu.org)
eb917824f6577757f0d73211083feb9d62b87c1f.camel@zaclys.net
merge 46643 46644 46645
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmA2Xn4ACgkQRaix6GvN
EKY7WBAAlvf3JOyw7rc9CQSxqn1TIzU+ozQdsXCeocet+p/yVAHeWpzB2g8X1F+z
XAKfWvtrsFQBXUwAXPEJwSHKGRH1y2AjIgG78fwOLSAU2luTvD+dD59wJ76GKW3n
L6F3NJNFoXYC4/y4Fo8oY3twkoKFAoWMmuB/MggZ9MUKEyKtwF8B+/Nu6VoZk8sg
s1jZW5oa/Xhk0MRvgDzaXCMR2wkAbcjJvZ3Qv03YDXGkyIopHaIIuF2kAJHjmXbN
sLPngqLxIRFaq+3C1l62cmPHBzBR4W4cllLs+PCC9r0BPxAaxlX8tcwG83olScOn
HpqVCileUbXSoFHZbzv3GwAYEvdv6mlRnvt2+ylMCQ9+ftIckAvERT8HmRZZoU2R
lcLQm4FcFiFzlldml05vbboy1jv1QbtV/Vvsjec1g7DJK5fKKE5O28rQ8/XgWihf
AzNs+4TUtSVDdePW/NNs8hE/xzDC2Xa39PoAhESHuMxy4ffmVTZizOSsmdpt43Jc
tiKVDZgEowTY1ui8i7NQNKQ+ov2OiIs+f4VR72+Oe2A4oKnT+5Fpl6KD9Jc83uv9
/LpjOPltmwvaji/HqPbPpXfnWHSY8wYT2MkrWlmMzU4L0N8iFckZc86tfWIMhWRr
ogFJ5DdIahKi7UeXubfMOhygp1IjIoYFaVBT0uw19ZcGcZfspSk=
=9rLf
-----END PGP SIGNATURE-----


L
L
Léo Le Bouter wrote on 24 Feb 2021 15:27
(address . 46643-done@debbugs.gnu.org)
1fb2ba44f701f4bf10876deb73a3d45cb4b53e9b.camel@zaclys.net
Pushed all patches in a1386815503036773a1092554f36d45dd9361efe.

It seems the licenses for ghc-wordexp and greenclip is BSD-3-Clause

Also, your upgrade of ghc-protolude broke the purescript build which
depends on ghc-protolude<0.2.4 so I created a secondary ghc-protolude-
0.2 package that purescript now depends on.

Think about running "$ guix refresh -l <package>" if you modify any
package to check for all its dependents and then try to build all the
dependents see if they don't break and if they do break please fix
them. That's what I did here.

I also fixed lint errors on ghc-wordexp. Think about running "$ guix
lint <package>" on any package you are adding or altering before
submitting.

Thank you!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmA2Yl8ACgkQRaix6GvN
EKY2Zw//fBZ+gvAJiZ2yZc+kcazXUQm1WKhuxVNtBxZCEc1tIzub2aZNTq4NPDiB
03XEAEJlbkqa9UTKwZae67ss+basCHJ4/RZdyQK4NcgAdELusshsDfjZUIuB7D7t
pF+qMTywba2L+6T2cOitPFGyP9me42q29ZOc49qxEo5jouT11XPcGPbt93zBBYwq
XPCV3l04CJ2cK+48mKDC1lBHUwZjhvlX76HNQtJC+BQh2ckPtWmGTaETkYK8GaAq
ffo2dT1JxHZjotloYntFaEkbVOWwfl/ScU00M/asyz7Y72ikPMKR88C4DGBMmcG2
gGa9bQxvBnVVHI8dTs4uSiDAOht2BUTgg3Z+FgMKCZ7ysCqkB84T19wxIjVbla7a
5terskX5wVktGSMXSgm6OrK3Mcs1h9TVP1njXvKwW2+LWYTHDeO8RmG59MV4BtET
781PorDtyqz7IFgS0NeMq3Wjy/O7pH7yXF+oUZ9B0K7dg34bXggJnb07LpcPQP+O
ys96pKDV9xfGgSFWDe/Yt3Cbc7CaayBHOxaFAc0ODE1H/K+FR4lX+UwwfB5Qzs5T
p7BvL2tga6amMm8sHFSh7VqnvHz+YROiSnf7OIbDDQS8nIi+/8ACWJGsUhArOOSn
gSYudVmqfszEaj1Ty7bFX1MFULASgjotinrYju2TVeThiBG8eXA=
=QsML
-----END PGP SIGNATURE-----


Closed
Z
Z
zimoun wrote on 24 Feb 2021 16:40
(address . 46643-done@debbugs.gnu.org)
CAJ3okZ2bLzq+wiqL_sbDFhXr0oxM8bDzozb7Y7mx2RtwGYJqvg@mail.gmail.com
Hi Léo,

On Wed, 24 Feb 2021 at 15:28, Léo Le Bouter via Guix-patches via
<guix-patches@gnu.org> wrote:

Toggle quote (4 lines)
> Also, your upgrade of ghc-protolude broke the purescript build which
> depends on ghc-protolude<0.2.4 so I created a secondary ghc-protolude-
> 0.2 package that purescript now depends on.

Usually, IIUC, the Haskell packages follows one LTS. And there are
updated in one go to avoid the Cabal Hell. Well, the current
%default-lts-version is 14.27 which has protolude at 0.2.3 [1]. LTS
14.27 supports GHC 8.6 which is the default current ghc in Guix.
Using LTS 17.4 seems a bad idea since it supports GHC 8.10 which is
not yet included in Guix. Therefore, ghc-protolude should not be
updated and ghc-protolude-0.2 should not be added, neither. Or I am
missing something. Except corner cases, please keep the Haskell
packages consistent with one LTS. The linter should warn about this
but it does not; I have not investigated why.

If greenclip cannot be built with ghc-protolude@0.2.3, please let the
"define-public ghc-protolude" at 0.2.3 and instead define
ghc-protolude-0.3. As it is done for ghc-atomic-write or
ghc-generic-random or ghc-prettyprinter or ghc-repline.

Thanks,
simon

L
L
Léo Le Bouter wrote on 24 Feb 2021 18:00
(address . 46643@debbugs.gnu.org)
3f58e4c2479d81ac22aa4e591910240bed8fde21.camel@zaclys.net
On Wed, 2021-02-24 at 16:40 +0100, zimoun wrote:
Toggle quote (2 lines)
> Hi Léo,

Hello! :-)

Toggle quote (5 lines)
> If greenclip cannot be built with ghc-protolude@0.2.3, please let the
> "define-public ghc-protolude" at 0.2.3 and instead define
> ghc-protolude-0.3. As it is done for ghc-atomic-write or
> ghc-generic-random or ghc-prettyprinter or ghc-repline.

I see, pushed 6bea71afac702fcab9fb420daa30aec95652e1a0 to hopefully fix
these concerns. Will keep in mind!

What about ghc-wordexp? Is the version on LTS channel? I couldnt find
much about that online (not very at ease with Stackage).

Thank you!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmA2hiIACgkQRaix6GvN
EKbOOQ//Zv4h3NHqwR2cqAyuz6jJiJOj53SBc7zvaZIuoL4sYHZsJ9Vnko6oaXiH
TSbAHeBbd/baDcLvPBK/7mC4zBt6/fLJmsYzb1hlWg89r92Q421p7Ibl5sv7Yq7J
TAgGd+zWICIcImJkdhf0d1n5su/Ic1JQbaspnZ1iNTecvzkVdvmWMe2/BpoQPVsn
Q/nf/sWqtyfByBkacqLHfUM1jdWTh9h1ESP/IdqR9HDHHdyXoT+FfMaBFNL7bF+H
h3f/SI81Zo9+MSBZja9o9dTBPUn5IK1ZdG77s+ZAjeKpUe0RZO/WltFH0LcHuoFe
hJMUIgyqSY7TvUQUxtvrplXhNU7NEDAuAaS+03om3F5YUdzIJUs60OstqCvCixTv
0xg541Ox+RU+3B4OwyQ6FCGhc7hMgqv9S7rAuqy9C5zPRwfXIAt0JRvnvFiLU8KP
qzFHRlN2Qotq/s5y8NZEaa6TM7pD9uDQLb0Y2KVcul8KEQVf2KwXX1qCVVaNvFJs
+pTX79RH+Q6O5/5j5nm3dLXIIC1TlRg2kL4adWB2bILZeCt6q7ol0GQabITnMDwM
3HwKruIC1B2Mo0+ndApiU5apJUQdMpz1Q5uBCa/jltYPWhjVVmRPHWv1UJDVCTLz
whgofTsU0lCUSGUKSeW6RT5AuzCuByH6IzHj1CP3MVkKoHuEEqs=
=dVio
-----END PGP SIGNATURE-----


S
S
Stefan Reichör wrote on 24 Feb 2021 20:14
(name . Léo Le Bouter)(address . lle-bout@zaclys.net)
87eeh5b7mc.fsf@xsteve.at
Hi Léo, Hi Simon,

thank you both for your kind help.

I already enjoy using Guix and I hope to master it more and more in the future!

Stefan.

Toggle quote (17 lines)
> On Wed, 2021-02-24 at 16:40 +0100, zimoun wrote:
>> Hi Léo,
>
> Hello! :-)
>
>> If greenclip cannot be built with ghc-protolude@0.2.3, please let the
>> "define-public ghc-protolude" at 0.2.3 and instead define
>> ghc-protolude-0.3. As it is done for ghc-atomic-write or
>> ghc-generic-random or ghc-prettyprinter or ghc-repline.
>
> I see, pushed 6bea71afac702fcab9fb420daa30aec95652e1a0 to hopefully fix
> these concerns. Will keep in mind!
>
> What about ghc-wordexp? Is the version on LTS channel? I couldnt find
> much about that online (not very at ease with Stackage).
>
> Thank you!
?