[PATCH] system: hurd: Have the static networking provision 'networking.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Christopher Baines
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal
C
C
Christopher Baines wrote on 14 Feb 2021 11:58
(address . guix-patches@gnu.org)
20210214105827.27729-1-mail@cbaines.net
Some services require networking, I'm looking at the Guix Build Coordinator
agent. Networking seems to work in the childhurd VM, so I think this change
makes sense.

* gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
parameter for the static-networking service.
---
gnu/system/hurd.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/system/hurd.scm b/gnu/system/hurd.scm
index 8b46e65e31..8f3a27834b 100644
--- a/gnu/system/hurd.scm
+++ b/gnu/system/hurd.scm
@@ -79,7 +79,7 @@
(list (static-networking (interface "lo")
(ip "127.0.0.1")
(requirement '())
- (provision '(loopback))
+ (provision '(loopback networking))
(name-servers '("10.0.2.3")))))
(syslog-service)
(service guix-service-type
--
2.30.0
L
L
Ludovic Courtès wrote on 22 Feb 2021 11:06
(name . Christopher Baines)(address . mail@cbaines.net)(address . 46506@debbugs.gnu.org)
87h7m4ct78.fsf@gnu.org
Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (7 lines)
> Some services require networking, I'm looking at the Guix Build Coordinator
> agent. Networking seems to work in the childhurd VM, so I think this change
> makes sense.
>
> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
> parameter for the static-networking service.

LGTM, thanks!

Ludo’.
C
C
Christopher Baines wrote on 22 Feb 2021 23:22
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 46506-done@debbugs.gnu.org)
87eeh7n3p0.fsf@cbaines.net
Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (13 lines)
> Hi Chris,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Some services require networking, I'm looking at the Guix Build Coordinator
>> agent. Networking seems to work in the childhurd VM, so I think this change
>> makes sense.
>>
>> * gnu/system/hurd.scm (%base-services/hurd): Add 'networking to the provision
>> parameter for the static-networking service.
>
> LGTM, thanks!

Thanks for taking a look, pushed as
5c7874adb00c834e55e58a9b964ebc5fd1bb872c.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmA0LotfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xf5gRAAl1OmxuzMT5cGz9NZF47ggzCzb+RgnSoj
gD0OJlF8A4d6hws7pS29s7BLlDmBoNN70j62PGEJ8bjHLB6Kly31vBPGosYfAMJc
avtPvxByWTIQ2DXTusjXyBWEDVVWxujKN7L42Xkz6ZUeGmERAkPAr2ayFl2gfeA3
B2QKWP69s+6NVZ75cudIS5FSi1001mV/9N5iTzR4dDh4JNMUuVlUhnzWjiEUmcDn
5wMVqJTFpcRfIQxSr9ol+fqFrcOULIPZL4fRyCE8fin1I9WpvE0+SltQwoHilmh3
Oj85HoeJIUypJPudqAkXeD7UHE/tv3wH760chTaGThLIKU3rmGGCKGM1qR1CH7Zh
jgc04AFNO2vnfje4qLL7UVBdygIDxKXkUYD0U6J/8lNFdm9tXOYgkGSzp8hL0AZs
Qs5WekuHjMNAnzHr8Ol6UkclK51n3I/uLeZlzuUL27i1N5QQXfUV65gZtjvXeMlG
fhUAUui34IQtFU8VLBeRZtKMc6z8WnlVSGiRbe1vsIFKqTgg9373CSnxzxegm4nl
3Nh/n+NGahvPh8fgSPunucPhefhQOFCmiK3Hoc+8cYkp9KmAl+tbu5QR8bTodGRA
cHg28krPFB3D/nnV9941IMrWt+/w2HeZPTJ/eHZ8hqe1j6lPzBFvz0g7xjecI8yE
gZQ98mEUhhI=
=uTJA
-----END PGP SIGNATURE-----

Closed
?