Assert, that user and group names are unique -> breaks guix system reconfigure

DoneSubmitted by Jonathan Brielmaier.
Details
2 participants
  • Jonathan Brielmaier
  • Leo Prikler
Owner
unassigned
Severity
normal
J
J
Jonathan Brielmaier wrote on 13 Jan 2021 00:03
(address . bug-guix@gnu.org)(address . leo.prikler@student.tugraz.at)
c07aaeac-480a-d64c-95ff-b1db5e7afc39@web.de
Hi Leo,

your commit a3002104:
system: Assert, that user and group names are unique.

breaks `guix system reconfigure` for me and other people (at least two
in IRC).

$ guix system reconfigure config.scm
guix system: error: the following groups appear more than once: lp

$ sudo grep lp /etc/group
lp:x:989:

lpadmin:x:975:

$ sudo grep lp /etc/passwd
lp:!:18467::::::

The same happend on my server with the `nginx` group.

I reverted it for the mean time, as I find it pretty grave...

~Jonathan
J
J
Jonathan Brielmaier wrote on 13 Jan 2021 00:18
(address . 45830@debbugs.gnu.org)
1a6370f4-f45a-0197-5b60-275cd18791c8@web.de
The original bug with the patch leading to this issue is:
L
L
Leo Prikler wrote on 13 Jan 2021 00:23
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 45830@debbugs.gnu.org)
5563afb3edc7b5b2aba212e3b3faa9d7c0b45d8a.camel@student.tugraz.at
Hi Jonathan,

Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
Toggle quote (19 lines)
> Hi Leo,
>
> your commit a3002104:
> system: Assert, that user and group names are unique.
>
> breaks `guix system reconfigure` for me and other people (at least
> two
> in IRC).
>
> $ guix system reconfigure config.scm
> guix system: error: the following groups appear more than once: lp
>
> $ sudo grep lp /etc/group
> lp:x:989:
>
> lpadmin:x:975:
>
> $ sudo grep lp /etc/passwd
> lp:!:18467::::::
It would seem you have two or more services adding an lp group then.
Or one service and a manually defined one.

Toggle quote (1 lines)
> The same happend on my server with the `nginx` group.
Same problem here; you're probably adding an nginx group twice in some
way. This is especially concerning, given that it's groups twice – for
some reason nothing is adding additional users or else that check would
have been triggered first.

Toggle quote (1 lines)
> I reverted it for the mean time, as I find it pretty grave...
I would have preferred, if you could instead have demoted it to a
warning. I understand, that stuff suddenly breaking can be
frustrating, but I doubt the configurations you're using are fine.

Toggle quote (1 lines)
> ~Jonathan
Regards,
Leo
L
L
Leo Prikler wrote on 13 Jan 2021 00:53
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 45830-done@debbugs.gnu.org)
d33df2f4d5acdc35647f22884f475a6c0e4b5854.camel@student.tugraz.at
Hello again,
Am Mittwoch, den 13.01.2021, 00:23 +0100 schrieb Leo Prikler:
Toggle quote (42 lines)
> Hi Jonathan,
>
> Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
> > Hi Leo,
> >
> > your commit a3002104:
> > system: Assert, that user and group names are unique.
> >
> > breaks `guix system reconfigure` for me and other people (at least
> > two
> > in IRC).
> >
> > $ guix system reconfigure config.scm
> > guix system: error: the following groups appear more than once: lp
> >
> > $ sudo grep lp /etc/group
> > lp:x:989:
> >
> > lpadmin:x:975:
> >
> > $ sudo grep lp /etc/passwd
> > lp:!:18467::::::
> It would seem you have two or more services adding an lp group then.
> Or one service and a manually defined one.
>
> > The same happend on my server with the `nginx` group.
> Same problem here; you're probably adding an nginx group twice in
> some
> way. This is especially concerning, given that it's groups twice –
> for
> some reason nothing is adding additional users or else that check
> would
> have been triggered first.
>
> > I reverted it for the mean time, as I find it pretty grave...
> I would have preferred, if you could instead have demoted it to a
> warning. I understand, that stuff suddenly breaking can be
> frustrating, but I doubt the configurations you're using are fine.
>
> > ~Jonathan
> Regards,
> Leo
I've re-applied the patch with errors demoted to warnings. I hope you
and the other people, who've reported this in IRC will be able to
figure out where the duplicate groups come from.

Regards,
Leo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 45830@debbugs.gnu.org