Assert, that user and group names are unique -> breaks guix system reconfigure

  • Done
  • quality assurance status badge
Details
2 participants
  • Jonathan Brielmaier
  • Leo Prikler
Owner
unassigned
Submitted by
Jonathan Brielmaier
Severity
normal

Debbugs page

Jonathan Brielmaier wrote 4 years ago
(address . bug-guix@gnu.org)(address . leo.prikler@student.tugraz.at)
c07aaeac-480a-d64c-95ff-b1db5e7afc39@web.de
Hi Leo,

your commit a3002104:
system: Assert, that user and group names are unique.

breaks `guix system reconfigure` for me and other people (at least two
in IRC).

$ guix system reconfigure config.scm
guix system: error: the following groups appear more than once: lp

$ sudo grep lp /etc/group
lp:x:989:

lpadmin:x:975:

$ sudo grep lp /etc/passwd
lp:!:18467::::::

The same happend on my server with the `nginx` group.

I reverted it for the mean time, as I find it pretty grave...

~Jonathan
Jonathan Brielmaier wrote 4 years ago
(address . 45830@debbugs.gnu.org)
1a6370f4-f45a-0197-5b60-275cd18791c8@web.de
The original bug with the patch leading to this issue is:
Leo Prikler wrote 4 years ago
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 45830@debbugs.gnu.org)
5563afb3edc7b5b2aba212e3b3faa9d7c0b45d8a.camel@student.tugraz.at
Hi Jonathan,

Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
Toggle quote (19 lines)
> Hi Leo,
>
> your commit a3002104:
> system: Assert, that user and group names are unique.
>
> breaks `guix system reconfigure` for me and other people (at least
> two
> in IRC).
>
> $ guix system reconfigure config.scm
> guix system: error: the following groups appear more than once: lp
>
> $ sudo grep lp /etc/group
> lp:x:989:
>
> lpadmin:x:975:
>
> $ sudo grep lp /etc/passwd
> lp:!:18467::::::
It would seem you have two or more services adding an lp group then.
Or one service and a manually defined one.

Toggle quote (1 lines)
> The same happend on my server with the `nginx` group.
Same problem here; you're probably adding an nginx group twice in some
way. This is especially concerning, given that it's groups twice – for
some reason nothing is adding additional users or else that check would
have been triggered first.

Toggle quote (1 lines)
> I reverted it for the mean time, as I find it pretty grave...
I would have preferred, if you could instead have demoted it to a
warning. I understand, that stuff suddenly breaking can be
frustrating, but I doubt the configurations you're using are fine.

Toggle quote (1 lines)
> ~Jonathan
Regards,
Leo
Leo Prikler wrote 4 years ago
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 45830-done@debbugs.gnu.org)
d33df2f4d5acdc35647f22884f475a6c0e4b5854.camel@student.tugraz.at
Hello again,
Am Mittwoch, den 13.01.2021, 00:23 +0100 schrieb Leo Prikler:
Toggle quote (42 lines)
> Hi Jonathan,
>
> Am Mittwoch, den 13.01.2021, 00:03 +0100 schrieb Jonathan Brielmaier:
> > Hi Leo,
> >
> > your commit a3002104:
> > system: Assert, that user and group names are unique.
> >
> > breaks `guix system reconfigure` for me and other people (at least
> > two
> > in IRC).
> >
> > $ guix system reconfigure config.scm
> > guix system: error: the following groups appear more than once: lp
> >
> > $ sudo grep lp /etc/group
> > lp:x:989:
> >
> > lpadmin:x:975:
> >
> > $ sudo grep lp /etc/passwd
> > lp:!:18467::::::
> It would seem you have two or more services adding an lp group then.
> Or one service and a manually defined one.
>
> > The same happend on my server with the `nginx` group.
> Same problem here; you're probably adding an nginx group twice in
> some
> way. This is especially concerning, given that it's groups twice –
> for
> some reason nothing is adding additional users or else that check
> would
> have been triggered first.
>
> > I reverted it for the mean time, as I find it pretty grave...
> I would have preferred, if you could instead have demoted it to a
> warning. I understand, that stuff suddenly breaking can be
> frustrating, but I doubt the configurations you're using are fine.
>
> > ~Jonathan
> Regards,
> Leo
I've re-applied the patch with errors demoted to warnings. I hope you
and the other people, who've reported this in IRC will be able to
figure out where the duplicate groups come from.

Regards,
Leo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 45830@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 45830
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help