Emacs can't load org mode after last update

DoneSubmitted by Marinus Savoritias.
Details
4 participants
  • Nicolas Goaziou
  • Marinus Savoritias
  • Michael Rohleder
  • Pierre Langlois
Owner
unassigned
Severity
normal
M
M
Marinus Savoritias wrote on 26 Dec 2020 18:42
(address . bug-guix@gnu.org)
f089662a-7464-a38d-7c05-52ee789dfa81@oezhayl.dev
I update Guix yesterday and org-mode doesn't load anymore.

The debug trace is this:

Debugger entered--Lisp error: (error "Invalid version syntax: ‘’ (must
start with a number)")
  signal(error ("Invalid version syntax: ‘’ (must start with a number)"))
  error("Invalid version syntax: `%s' (must start with a number)" "")
  version-to-list("")
  version<("" "9.0")
  #f(compiled-function () #<bytecode 0x5c3b49>)()
  funcall(#f(compiled-function () #<bytecode 0x5c3b49>))
  (lambda nil (funcall '#f(compiled-function () #<bytecode 0x5c3b49>)))()
eval-after-load-helper("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
  run-hook-with-args(eval-after-load-helper
"/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
do-after-load-evaluation("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
  require(org)
byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\300\306!\210\307\310\311\312\313\314%\210\315\316\317\320\313\310\321\322&\7\210\315\323\324\325\313\310\321..."
[require elfeed org dash s cl-lib xml custom-declare-group elfeed-org
nil "Configure the Elfeed RSS reader with an Orgmode fi..." :group comm
custom-declare-variable rmh-elfeed-org-tree-id "elfeed" "The tag or ID
property on the trees containing the..." :type string
rmh-elfeed-org-ignore-tag "ignore" "The tag on the feed trees that will
be ignored." rmh-elfeed-org-auto-ignore-invalid-feeds "Tag feeds to
ignore them when a feed could not loa..." bool rmh-elfeed-org-files
(list "~/.emacs.d/elfeed.org") "The files where we look to find trees
with the `rm..." (repeat (file :tag "org-mode file"))] 8)
  require(elfeed-org)
  eval-buffer(#<buffer  *load*> nil "/home/marinus/.emacs" nil t)  ;
Reading at buffer position 39
  load-with-code-conversion("/home/marinus/.emacs"
"/home/marinus/.emacs" t t)
  load("~/.emacs" noerror nomessage)
  startup--load-user-init-file(#f(compiled-function () #<bytecode
0x5c3f71>) #f(compiled-function () #<bytecode 0x5c3f85>) t)
  command-line()
  normal-top-level()

Everytime I try to open a org file I get the same error. I noticed that
after I removed the elfeed-org requirement to see if that was the problem.

Emacs commit is this:
 /gnu/store/lhw3zwhzra0w5l8a4jw8fvm58i75xyl8-emacs-27.1

Guix System config is this:

Generation 15   Dec 26 2020 15:25:17    (current)
  guix 4969b51
    branch: master
    commit: 4969b51d175497bfcc354c91803e9d70542b7113

My .emacs file has nothing besides this:

;;Elfeed config

(require 'elfeed-org)
(setq rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org"))

Marinus
M
M
Michael Rohleder wrote on 27 Dec 2020 10:19
(name . Marinus Savoritias)(address . marinus.savoritias@oezhayl.dev)(address . 45448@debbugs.gnu.org)
87czyvy5bb.fsf@rohleder.de
Hello Marinus,

thank you for reporting!

I can reproduce this.

It seems, commit 93a81f5f643782926bd0e87eb4a55efd9c67ad18 broke
emacs-org and packages that depend on it.

e.g. emacs-org-re-reveal:
...
starting phase `build'
Checking /gnu/store/vlaq8yndpjmv55y8nwks82x1lnsm0q95-emacs-org-re-reveal-3.1.1/share/emacs/site-lisp/...
Compiling /gnu/store/vlaq8yndpjmv55y8nwks82x1lnsm0q95-emacs-org-re-reveal-3.1.1/share/emacs/site-lisp/org-re-reveal-autoloads.el...
Compiling /gnu/store/vlaq8yndpjmv55y8nwks82x1lnsm0q95-emacs-org-re-reveal-3.1.1/share/emacs/site-lisp/org-re-reveal.el...
Compiling /gnu/store/vlaq8yndpjmv55y8nwks82x1lnsm0q95-emacs-org-re-reveal-3.1.1/share/emacs/site-lisp/ox-re-reveal.el...
Invalid version syntax: ‘’ (must start with a number)
command "/gnu/store/k826y34z8zzjj57jv2nldmpw6vsdd145-emacs-minimal-27.1/bin/emacs" "--quick" "--batch" "--eval=(eval '(progn (setq byte-compile-debug t) (byte-recompile-directory (file-name-as-directory \"/gnu/store/vlaq8yndpjmv55y8nwks82x1lnsm0q95-emacs-org-re-reveal-3.1.1/share/emacs/site-lisp\") 0 1)) t)" failed with status 255
builder for `/gnu/store/q0nyh14394g1g2q9kj2cljc6kapjwdh7-emacs-org-re-reveal-3.1.1.drv' failed with exit code 1
build of /gnu/store/q0nyh14394g1g2q9kj2cljc6kapjwdh7-emacs-org-re-reveal-3.1.1.drv failed
I tried searching for a broken version string in org el's, but couldn't
find one.
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl/oUZgRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyXhEgf+KVOiEG/l2okdetqrxzKh/qWl23w+7iCs
m7dFv2YJEcVsbAo7j4HwUjR1FxfziFkXmbfSKRwXYsQVYMsUZetNA0yLNy9zx044
R/MOWItP5fwVNnUeHYp0VTACgqJvVSGOGInUQYTDOML+FMDL0Oo5RsxQXZ9+Umwl
jwAvHdzOtKLQXUOj2ktUK/1pAkh0xXF8mBEkDcYkrXu6SICrON1fs/dUCui7gVqB
CNzR7BixeuTzJdq+VIfeFFPw6OREnrmnoNiWnjyki1QdmmnXhRveYH9LZ1sNa5b6
vfFaxZT/PkvSAXrDQv86Nz/e7YKy2ku2HA/Zpa1UF2Zpfl5mxhoDuA==
=YGqP
-----END PGP SIGNATURE-----

P
P
Pierre Langlois wrote on 27 Dec 2020 12:03
(name . Marinus Savoritias)(address . marinus.savoritias@oezhayl.dev)
875z4nlddy.fsf@gmx.com
Hi!

Marinus Savoritias writes:

Toggle quote (58 lines)
> I update Guix yesterday and org-mode doesn't load anymore.
>
> The debug trace is this:
>
> Debugger entered--Lisp error: (error "Invalid version syntax: ‘’ (must start
> with a number)")
> signal(error ("Invalid version syntax: ‘’ (must start with a number)"))
> error("Invalid version syntax: `%s' (must start with a number)" "")
> version-to-list("")
> version<("" "9.0")
> #f(compiled-function () #<bytecode 0x5c3b49>)()
> funcall(#f(compiled-function () #<bytecode 0x5c3b49>))
> (lambda nil (funcall '#f(compiled-function () #<bytecode 0x5c3b49>)))()
> eval-after-load-helper("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
> run-hook-with-args(eval-after-load-helper
> "/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
> do-after-load-evaluation("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
> require(org)
> byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\300\306!\210\307\310\311\312\313\314%\210\315\316\317\320\313\310\321\322&\7\210\315\323\324\325\313\310\321..."
> [require elfeed org dash s cl-lib xml custom-declare-group elfeed-org
> nil "Configure the Elfeed RSS reader with an Orgmode fi..." :group comm
> custom-declare-variable rmh-elfeed-org-tree-id "elfeed" "The tag or ID
> property on the trees containing the..." :type string rmh-elfeed-org-ignore-tag
> "ignore" "The tag on the feed trees that will be ignored."
> rmh-elfeed-org-auto-ignore-invalid-feeds "Tag feeds to ignore them when a feed
> could not loa..." bool rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org") "The
> files where we look to find trees with the `rm..." (repeat (file :tag "org-mode
> file"))] 8)
> require(elfeed-org)
> eval-buffer(#<buffer *load*> nil "/home/marinus/.emacs" nil t) ; Reading at
> buffer position 39
> load-with-code-conversion("/home/marinus/.emacs" "/home/marinus/.emacs" t t)
> load("~/.emacs" noerror nomessage)
> startup--load-user-init-file(#f(compiled-function () #<bytecode 0x5c3f71>)
> #f(compiled-function () #<bytecode 0x5c3f85>) t)
> command-line()
> normal-top-level()
>
> Everytime I try to open a org file I get the same error. I noticed that after I
> removed the elfeed-org requirement to see if that was the problem.
>
> Emacs commit is this: /gnu/store/lhw3zwhzra0w5l8a4jw8fvm58i75xyl8-emacs-27.1
>
> Guix System config is this:
>
> Generation 15 Dec 26 2020 15:25:17 (current)
> guix 4969b51
> repository URL: https://git.savannah.gnu.org/git/guix.git
> branch: master
> commit: 4969b51d175497bfcc354c91803e9d70542b7113
>
> My .emacs file has nothing besides this:
>
> ;;Elfeed config
>
> (require 'elfeed-org)
> (setq rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org"))

I also hit this issue yesterday :-/. To fix it, I found you could make
sure to have (require 'org) *before* loading other packages that
depended on org. Would that work for you? I'm using use-package, so the
particular fix for me was to add ":after org" on every package
declaration that needed to use org.

There's still an issue upstream I think, probably due to a mis-match
between the org that's shipped in emacs and the newer one in guix?

Hope this helps!
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl/oafkYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UH1EH/A0pdqSXfWmi+vrdaAXzZbLy
53Dvx3ilPmpQ0580nxp0+Wc+kIoIe/BP7EUesNaEsOmRD19sk5VIGJv8OeJ0FBzf
957WIxv1wEEShEmEIXpLGA96Xoi1Gq1wekV8lOZ0gkPOjYN1cfEZfAN2Tksi5nc+
hPoureun+iTQaXQ0E5oRlOyPkmsZdpM0YwUSRJtxdk3VaY/4ToneljmaIn0B3QjW
fjwNvIA95jAZKjCzAN6FWCaJwHPXwuEZGsqBFizMZQqD+amcmLZlJ5+aS7VEDJkL
N5W2gfPKgxaDkq1AgXBv41TZi3UzWv6gwWCF7B20t3bNE7+SRAI62zZ8adw1/O4=
=Gctu
-----END PGP SIGNATURE-----

P
P
Pierre Langlois wrote on 27 Dec 2020 14:07
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)
87pn2vbdnf.fsf@gmx.com
Pierre Langlois writes:

Toggle quote (71 lines)
> Hi!
>
> Marinus Savoritias writes:
>
>> I update Guix yesterday and org-mode doesn't load anymore.
>>
>> The debug trace is this:
>>
>> Debugger entered--Lisp error: (error "Invalid version syntax: ‘’ (must start
>> with a number)")
>> signal(error ("Invalid version syntax: ‘’ (must start with a number)"))
>> error("Invalid version syntax: `%s' (must start with a number)" "")
>> version-to-list("")
>> version<("" "9.0")
>> #f(compiled-function () #<bytecode 0x5c3b49>)()
>> funcall(#f(compiled-function () #<bytecode 0x5c3b49>))
>> (lambda nil (funcall '#f(compiled-function () #<bytecode 0x5c3b49>)))()
>> eval-after-load-helper("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>> run-hook-with-args(eval-after-load-helper
>> "/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>> do-after-load-evaluation("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>> require(org)
>> byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\300\306!\210\307\310\311\312\313\314%\210\315\316\317\320\313\310\321\322&\7\210\315\323\324\325\313\310\321..."
>> [require elfeed org dash s cl-lib xml custom-declare-group elfeed-org
>> nil "Configure the Elfeed RSS reader with an Orgmode fi..." :group comm
>> custom-declare-variable rmh-elfeed-org-tree-id "elfeed" "The tag or ID
>> property on the trees containing the..." :type string rmh-elfeed-org-ignore-tag
>> "ignore" "The tag on the feed trees that will be ignored."
>> rmh-elfeed-org-auto-ignore-invalid-feeds "Tag feeds to ignore them when a feed
>> could not loa..." bool rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org") "The
>> files where we look to find trees with the `rm..." (repeat (file :tag "org-mode
>> file"))] 8)
>> require(elfeed-org)
>> eval-buffer(#<buffer *load*> nil "/home/marinus/.emacs" nil t) ; Reading at
>> buffer position 39
>> load-with-code-conversion("/home/marinus/.emacs" "/home/marinus/.emacs" t t)
>> load("~/.emacs" noerror nomessage)
>> startup--load-user-init-file(#f(compiled-function () #<bytecode 0x5c3f71>)
>> #f(compiled-function () #<bytecode 0x5c3f85>) t)
>> command-line()
>> normal-top-level()
>>
>> Everytime I try to open a org file I get the same error. I noticed that after I
>> removed the elfeed-org requirement to see if that was the problem.
>>
>> Emacs commit is this: /gnu/store/lhw3zwhzra0w5l8a4jw8fvm58i75xyl8-emacs-27.1
>>
>> Guix System config is this:
>>
>> Generation 15 Dec 26 2020 15:25:17 (current)
>> guix 4969b51
>> repository URL: https://git.savannah.gnu.org/git/guix.git
>> branch: master
>> commit: 4969b51d175497bfcc354c91803e9d70542b7113
>>
>> My .emacs file has nothing besides this:
>>
>> ;;Elfeed config
>>
>> (require 'elfeed-org)
>> (setq rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org"))
>
> I also hit this issue yesterday :-/. To fix it, I found you could make
> sure to have (require 'org) *before* loading other packages that
> depended on org. Would that work for you? I'm using use-package, so the
> particular fix for me was to add ":after org" on every package
> declaration that needed to use org.
>
> There's still an issue upstream I think, probably due to a mis-match
> between the org that's shipped in emacs and the newer one in guix?

Actually, it started failing again just after I sent this message... It
seems reordering require didn't actually fix anything, sorry!

Looking into it a little bit more, it seems there was an issue with the
version reporting, if you try and evaluate (org-version), it returns an
empty string, then causing the original backtrace.

There seems to be an issue when building the package, I see the result
of (org-version) should be defined at build-time: https://code.orgmode.org/bzg/org-mode/src/master/mk/default.mk#L118

But we don't do it properly:

Toggle snippet (21 lines)
$ cat $(guix build emacs-org)/share/emacs/site-lisp/org-version.el
;;; org-version.el --- autogenerated file, do not edit
;;
;;; Code:
;;;###autoload
(defun org-release ()
"The release version of Org.
Inserted by installing Org mode or when a release is made."
(let ((org-release ""))
org-release))
;;;###autoload
(defun org-git-version ()
"The Git version of Org mode.
Inserted by installing Org or when a release is made."
(let ((org-git-version ""))
org-git-version))


(provide 'org-version)

I'll see if I can spot anything going wrong during the build process.

Thanks,
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl/ohyQYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UHcgH/07RCot/C7qDqVaWrifYf75y
44O5pX5uFdGl3CPen2eQlNDC41oz5eCGgf1RE6x68332kElpmCTLeSZ4EGwdDoJE
j/a/8QfoIageaAGlA+IHvqTmHY81XOzLgNzpVbeGynjKzxVLdbta8fj6Gg/dH1xd
5ajZ7kdkwi4Pz/mcXUa7ERyZXuWu8a93HrS87jJJhbxSEsJ0+hCHpxWnLkUXKGP3
tpQN9GXfPBxDIq/BjnK0CIORBK8BLCmej8po0/ZOA6hHmS0aE4TirOCcacHlrSRw
0KonEKvHA5RTpJnoQ6Bf/LMtYpK+F5eynnFnQVlFhG34NeBZKSRxMjrnW+dE9f8=
=kRxP
-----END PGP SIGNATURE-----

P
P
Pierre Langlois wrote on 28 Dec 2020 14:21
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)
87tus6cbhj.fsf@gmx.com
Pierre Langlois writes:

Toggle quote (109 lines)
> Pierre Langlois writes:
>
>> Hi!
>>
>> Marinus Savoritias writes:
>>
>>> I update Guix yesterday and org-mode doesn't load anymore.
>>>
>>> The debug trace is this:
>>>
>>> Debugger entered--Lisp error: (error "Invalid version syntax: ‘’ (must start
>>> with a number)")
>>> signal(error ("Invalid version syntax: ‘’ (must start with a number)"))
>>> error("Invalid version syntax: `%s' (must start with a number)" "")
>>> version-to-list("")
>>> version<("" "9.0")
>>> #f(compiled-function () #<bytecode 0x5c3b49>)()
>>> funcall(#f(compiled-function () #<bytecode 0x5c3b49>))
>>> (lambda nil (funcall '#f(compiled-function () #<bytecode 0x5c3b49>)))()
>>> eval-after-load-helper("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>>> run-hook-with-args(eval-after-load-helper
>>> "/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>>> do-after-load-evaluation("/home/marinus/.guix-profile/share/emacs/site-lisp/org.elc")
>>> require(org)
>>> byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\300\306!\210\307\310\311\312\313\314%\210\315\316\317\320\313\310\321\322&\7\210\315\323\324\325\313\310\321..."
>>> [require elfeed org dash s cl-lib xml custom-declare-group elfeed-org
>>> nil "Configure the Elfeed RSS reader with an Orgmode fi..." :group comm
>>> custom-declare-variable rmh-elfeed-org-tree-id "elfeed" "The tag or ID
>>> property on the trees containing the..." :type string rmh-elfeed-org-ignore-tag
>>> "ignore" "The tag on the feed trees that will be ignored."
>>> rmh-elfeed-org-auto-ignore-invalid-feeds "Tag feeds to ignore them when a feed
>>> could not loa..." bool rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org") "The
>>> files where we look to find trees with the `rm..." (repeat (file :tag "org-mode
>>> file"))] 8)
>>> require(elfeed-org)
>>> eval-buffer(#<buffer *load*> nil "/home/marinus/.emacs" nil t) ; Reading at
>>> buffer position 39
>>> load-with-code-conversion("/home/marinus/.emacs" "/home/marinus/.emacs" t t)
>>> load("~/.emacs" noerror nomessage)
>>> startup--load-user-init-file(#f(compiled-function () #<bytecode 0x5c3f71>)
>>> #f(compiled-function () #<bytecode 0x5c3f85>) t)
>>> command-line()
>>> normal-top-level()
>>>
>>> Everytime I try to open a org file I get the same error. I noticed that after I
>>> removed the elfeed-org requirement to see if that was the problem.
>>>
>>> Emacs commit is this: /gnu/store/lhw3zwhzra0w5l8a4jw8fvm58i75xyl8-emacs-27.1
>>>
>>> Guix System config is this:
>>>
>>> Generation 15 Dec 26 2020 15:25:17 (current)
>>> guix 4969b51
>>> repository URL: https://git.savannah.gnu.org/git/guix.git
>>> branch: master
>>> commit: 4969b51d175497bfcc354c91803e9d70542b7113
>>>
>>> My .emacs file has nothing besides this:
>>>
>>> ;;Elfeed config
>>>
>>> (require 'elfeed-org)
>>> (setq rmh-elfeed-org-files (list "~/.emacs.d/elfeed.org"))
>>
>> I also hit this issue yesterday :-/. To fix it, I found you could make
>> sure to have (require 'org) *before* loading other packages that
>> depended on org. Would that work for you? I'm using use-package, so the
>> particular fix for me was to add ":after org" on every package
>> declaration that needed to use org.
>>
>> There's still an issue upstream I think, probably due to a mis-match
>> between the org that's shipped in emacs and the newer one in guix?
>
> Actually, it started failing again just after I sent this message... It
> seems reordering require didn't actually fix anything, sorry!
>
> Looking into it a little bit more, it seems there was an issue with the
> version reporting, if you try and evaluate (org-version), it returns an
> empty string, then causing the original backtrace.
>
> There seems to be an issue when building the package, I see the result
> of (org-version) should be defined at build-time: https://code.orgmode.org/bzg/org-mode/src/master/mk/default.mk#L118
>
> But we don't do it properly:
>
> --8<---------------cut here---------------start------------->8---
> $ cat $(guix build emacs-org)/share/emacs/site-lisp/org-version.el
> ;;; org-version.el --- autogenerated file, do not edit
> ;;
> ;;; Code:
> ;;;###autoload
> (defun org-release ()
> "The release version of Org.
> Inserted by installing Org mode or when a release is made."
> (let ((org-release ""))
> org-release))
> ;;;###autoload
> (defun org-git-version ()
> "The Git version of Org mode.
> Inserted by installing Org or when a release is made."
> (let ((org-git-version ""))
> org-git-version))
>
>
> (provide 'org-version)
> --8<---------------cut here---------------end--------------->8---
>
> I'll see if I can spot anything going wrong during the build process.

So, as it turns out tarball on elpa contains this bug, I've just

In the meantime, we can either revert the update or just fix it
downstream temporarily. The following patch works for me for example:

Toggle snippet (18 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index eaa0fc8d2a..e65666a6ac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -10296,6 +10296,11 @@ passive voice.")
(arguments
`(#:phases
(modify-phases %standard-phases
+ (add-after 'unpack 'fix-org-version
+ (lambda _
+ (substitute* "org-version.el"
+ (("org-release \"\"") (string-append "org-release \"" ,version "\"")))
+ #t))
(add-after 'install 'install-documentation
(lambda* (#:key outputs #:allow-other-keys)
(let* ((share (string-append (assoc-ref outputs "out") "/share"))

I'm more tempted to add this little fix rather than revert the update,
given we'd also have to revert org-contrib.

WDYT?

Thanks,
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl/p29gYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UAYEIAIxy+Qvhb/5l+6wG6wdwWosB
nAXGdIWGDY5tZDJ13p8cYNnhSB5TNmxgO0/jelU7OkhVvOPElcPcjBJYZps80u2u
k6Gf1fixcd+X/1ZKhNJ2lxkfu4yrJQ4vQxf1FekpoAdNOZrDBYU+zy7X36U6Sm+E
sdej1QfWscjPK0FB6KW1v6q1xcR+iqwaUt0Rs4ZWQYT1c/b/jJy6Xb5xsNtSIVq0
rSkQhzLtDocIAlkiV96nkBd05nR/V6vD+fKlEnCHJqK9Ci+gVL/X8n7FNUEraS+X
NGniPTQW291YbynknlzaC5tL+y5DRg6gSUzvy0SxxCF4wC+rWoK5N5j2s8HM+MU=
=EqhP
-----END PGP SIGNATURE-----

N
N
Nicolas Goaziou wrote on 28 Dec 2020 16:04
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)(address . 45448@debbugs.gnu.org)
87a6tyc6ph.fsf@nicolasgoaziou.fr
Hello,

Pierre Langlois <pierre.langlois@gmx.com> writes:

Toggle quote (23 lines)
> In the meantime, we can either revert the update or just fix it
> downstream temporarily. The following patch works for me for example:
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index eaa0fc8d2a..e65666a6ac 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -10296,6 +10296,11 @@ passive voice.")
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'fix-org-version
> + (lambda _
> + (substitute* "org-version.el"
> + (("org-release \"\"") (string-append "org-release \"" ,version "\"")))
> + #t))
> (add-after 'install 'install-documentation
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((share (string-append (assoc-ref outputs "out") "/share"))
>
> I'm more tempted to add this little fix rather than revert the update,
> given we'd also have to revert org-contrib.

Indeed. LGTM. Thank you!

Regards,
--
Nicolas Goaziou
P
P
Pierre Langlois wrote on 28 Dec 2020 17:34
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
87zh1xyjnj.fsf@gmx.com
Nicolas Goaziou writes:

Toggle quote (29 lines)
> Hello,
>
> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> In the meantime, we can either revert the update or just fix it
>> downstream temporarily. The following patch works for me for example:
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index eaa0fc8d2a..e65666a6ac 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -10296,6 +10296,11 @@ passive voice.")
>> (arguments
>> `(#:phases
>> (modify-phases %standard-phases
>> + (add-after 'unpack 'fix-org-version
>> + (lambda _
>> + (substitute* "org-version.el"
>> + (("org-release \"\"") (string-append "org-release \"" ,version "\"")))
>> + #t))
>> (add-after 'install 'install-documentation
>> (lambda* (#:key outputs #:allow-other-keys)
>> (let* ((share (string-append (assoc-ref outputs "out") "/share"))
>>
>> I'm more tempted to add this little fix rather than revert the update,
>> given we'd also have to revert org-contrib.
>
> Indeed. LGTM. Thank you!

Great! I've just pushed with commit
cd11f6a2bd703f0859aec05c0873186b734d6d74, adding a comment to remove
this phase when the issue is resolved upstream.

Thanks!
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl/qCQAYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31U5FEIALKnnA7N2ctB2YsiStN3sj88
/NRbyVusrRHmlS5MIvh3vNmn6K6BrvzKvRDQ2qRguksc/qnbFH6T6sFu+Y4PuUYk
olQIzyPfUOyQLtu+u31JQTjGgNJBOfAY6/O/3ahs096wYdK2zHztQG5bhUnqLjst
R08SdDyr3ergFIAZqYHr6nIuUiMEjjgpkr8fODwBTTN0hceYMCyrYhisfMs+TF8D
Kz+KHv5fzpvYpcTS57uIA4Oc9Lox7p9K60c+wPGo5grjhmQDCGrOaNNWvXEwHjLg
giQFthdLbNOE7wSlaMpbSXdf43gdItLYK07LNmCDiLB9gKpplEDXNZGFRFvzUpU=
=WlcH
-----END PGP SIGNATURE-----

M
M
Michael Rohleder wrote on 15 Jan 2021 22:53
(address . 45448-done@debbugs.gnu.org)
87lfcthnoo.fsf@rohleder.de
Pierre Langlois <pierre.langlois@gmx.com> writes:
Toggle quote (4 lines)
> Great! I've just pushed with commit
> cd11f6a2bd703f0859aec05c0873186b734d6d74, adding a comment to remove
> this phase when the issue is resolved upstream.

I think, with this commit, this can be closed.
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmACDtcRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyUXSQf+LRcxwu1+p93biIOYTDZSn1N63o0d4BY6
PUZdmZRecZgNVcU9mdPUf4vP1lIT4tcSAfSRS6zWADh3WdOYto6wuy01OtupEQYg
V/gdkBsrG9vFQuOVBNaiNeqiEU/3blcvegotdsPb1Xc0wdZKBb90whtyMHoYNbT8
rxSJlZyenG2DEZILi0p1f4nOSJoOiVFf1fuBB3U/RocldwZ5ImRtthh75QmUkREb
XgspDnOifBiirsX+CYphm/kvtYqQXaAu3oYqjKCiVmcEJmTsIeRStw9C4jLohNHr
mC34q7/Q5Qr8ygLgU8Fm4WtKxr80+ekGmdbYzUJfTknImr8omo4PyQ==
=Fywp
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 45448@debbugs.gnu.org