Duplicate inputs with Crate importer

  • Open
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Nicolas Goaziou
Owner
unassigned
Submitted by
Nicolas Goaziou
Severity
normal
N
N
Nicolas Goaziou wrote on 5 Dec 2020 22:03
(address . bug-guix@gnu.org)
87ft4knexa.fsf@nicolasgoaziou.fr
Hello,

I noticed the Crate importer sometimes returns duplicate inputs. For
example

guix import crate bat

returns

...
(arguments
`(#:cargo-inputs
(("rust-ansi-colours" ,rust-ansi-colours-1)
("rust-ansi-term" ,rust-ansi-term-0.12)
("rust-atty" ,rust-atty-0.2)
("rust-clap" ,rust-clap-2)
("rust-clap" ,rust-clap-2)
...

Regards,
--
Nicolas Goaziou
E
E
Efraim Flashner wrote on 9 Dec 2020 09:38
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)(address . 45058@debbugs.gnu.org)
X9CM9fbv1iusfHiT@E5400
On Sat, Dec 05, 2020 at 10:03:45PM +0100, Nicolas Goaziou wrote:
Toggle quote (19 lines)
> Hello,
>
> I noticed the Crate importer sometimes returns duplicate inputs. For
> example
>
> guix import crate bat
>
> returns
>
> ...
> (arguments
> `(#:cargo-inputs
> (("rust-ansi-colours" ,rust-ansi-colours-1)
> ("rust-ansi-term" ,rust-ansi-term-0.12)
> ("rust-atty" ,rust-atty-0.2)
> ("rust-clap" ,rust-clap-2)
> ("rust-clap" ,rust-clap-2)
> ...

As noted here¹ rust-clap-2 is listed as both a dependency and a
build-dependency. For the sake of completeness, there are also packages
which require the same crate+version for cargo-dev-input and a looser
version requirement for cargo-input. It seems worthwhile to deduplicate
the cargo-inputs, since it's a combination of 'dependencies' and 'build
dependencies', but I'm not sure about removing duplicates when they
appear in both cargo-inputs and cargo-development-inputs.



Toggle quote (8 lines)
>
> Regards,
> --
> Nicolas Goaziou
>
>
>

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl/QjPIACgkQQarn3Mo9
g1FdVg/9Has9+9TihDcO8uXvrk8XCaJv0iWzJalfPBbqwGzkfQs0B6gIJIILvu7f
jcBL2NliWtlcc9lgWHpRKCq/GgkdtEKvVzK9Oook+JVerUf4+wsu0UvFXeGCmzhu
nktSAbasV4bWxGcKpeLsdRF6tlZpkaZHMdvDV9N/KKFXacGhwh4SxIlf6Kns6HIC
si2qsWpwZY6/lzmiHgIKlkcK0pa76JCUI0TsO0ambE6of5QOdPqRDF5T0sBU3Fx9
ssF928wOe9M7mgXAwjgacGKFWd7FSSrXeoZ6q8S/4tA4Etn00MkUVVTfPWr6JL8v
p51pvvvehDCcsyC3BiuLnOmKFFZ1gylWrgqJrTrToHwLzlTPCX57Nh1s++OClID0
UieECZHPBtvB+BQw2Add9vQqu6vn4+0+dz1YlLbyuVCSNWIIIB2DgeCuTKnJXd6a
yPr0zxWvOn4ABXvsOTwJeg5xkKXh++w0DdjxCD82bfgJOHwIdUI1xEYqCGs3vp0O
4mjxPxBGHFjEGUouGQlkHjP+zQWCMgvSSDCejkHPqLjy5sacOcc/gWWiokRoaKCZ
b4RZvTugUieQcub89PGCH8+BTJDqyDlld2NTOTFMjytz8wHeyKfIgsInSpzavgcr
u2ekEhUeaS2I00i8VV9HDAY/AZ7nSC34i7uqlikeP3wAYEdSeRg=
=fRn3
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 45058@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 45058
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch