[mumi] 44964 cannot be displayed

  • Done
  • quality assurance status badge
Details
3 participants
  • Arun Isaac
  • Felix Lechner
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Ricardo Wurmus
Severity
normal
R
R
Ricardo Wurmus wrote on 2 Dec 2020 21:26
(address . bug-guix@gnu.org)
87y2ig6jke.fsf@elephly.net
Display of issue 44964 fails because the email address is not properly
split.

Toggle snippet (24 lines)
GET /44964
In mumi/web/server.scm:
33:9 9 (handler _ _)
In mumi/web/controller.scm:
122:24 8 (_ _)
In mumi/web/view/html.scm:
358:2 7 (issue-page #<<bug-status> num: 44964 archived: #f bloâ¦> â¦)
In unknown file:
6 (filter #<procedure 7f19e5295440 at mumi/web/view/htmlâ¦> â¦)
In mumi/web/view/html.scm:
363:24 5 (_ _)
In mumi/messages.scm:
142:8 4 (internal-message? _)
In unknown file:
3 (_ #<procedure 7f174074bfe0 at ice-9/boot-9.scm:792:28â¦> â¦)
In mumi/messages.scm:
88:6 2 (sender _)
In unknown file:
1 (car "Jorge P. de Morais Neto <jorge+list@disroot.org>")
In ice-9/boot-9.scm:
1669:16 0 (raise-exception _ #:continuable? _)


--
Ricardo
R
R
Ricardo Wurmus wrote on 4 Dec 2020 06:59
(address . 45015@debbugs.gnu.org)(name . Arun Isaac)(address . arunisaac@systemreboot.net)
87pn3q6rhm.fsf@elephly.net
Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
problem, which I suspect might be a bug in guile-email.

For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
not split up into name and address parts but remains a single string.

--
Ricardo
A
A
Arun Isaac wrote on 4 Dec 2020 07:11
87czzqhzh0.fsf@systemreboot.net
Hi,

This is likely a bug in guile-email. It shouldn't have returned the
unparsed From address. It was likely triggered by "Jorge P. de Morais
Neto <jorge+list@disroot.org>" being an invalid address. The period
character is not allowed in the name and should have been quoted like
"\"Jorge P. de Morais Neto\" <jorge+list@disroot.org>". I will
investigate and come up with some fix within 24 hours.

Meanwhile, do CC me or guile-email@systemreboot.net on anything
guile-email related. That would help me take note sooner. I found this
bug report almost by chance.

Thanks,
Arun
-----BEGIN PGP SIGNATURE-----

iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl/J0ysbHGFydW5pc2Fh
Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuz9UAH/RTXR7B6SNnBLuqIyCaO
QziPupoKrD5Twom9ZqUlOnTP4gKXD+B/xrI7d7Wu3Tbz4g6Ab7AfwcSahq9R2YoU
xArk1cQvRGZcA2HbgsMi8tUKR5IQpT8QKKDwuVSAqMKYIBdq6f9Syb9m4Ad4gEjT
j1++mBdet6HNrkRmAZCuax5iHY9uAFaq/nPztTwKSGOx+G1gTiHG5kzv0NIhdJA5
O3jPn03PzbWVhTbgam+RsfTygDfVMjsf7qnfuX0Ke3mJOWNi4uLs1dGt9q/FA/9M
X7NHJbSLr9xd1A0qwUFKwI8YzRv7T0eKUkoQwHhBq2yc1e1x3xw9czrBxBNFZWYW
fUM=
=2y6T
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 4 Dec 2020 08:27
(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 45015@debbugs.gnu.org)
87mtyu6nft.fsf@elephly.net
Arun Isaac <arunisaac@systemreboot.net> writes:

Toggle quote (7 lines)
> This is likely a bug in guile-email. It shouldn't have returned the
> unparsed From address. It was likely triggered by "Jorge P. de Morais
> Neto <jorge+list@disroot.org>" being an invalid address. The period
> character is not allowed in the name and should have been quoted like
> "\"Jorge P. de Morais Neto\" <jorge+list@disroot.org>". I will
> investigate and come up with some fix within 24 hours.

Thank you!

Toggle quote (4 lines)
> Meanwhile, do CC me or guile-email@systemreboot.net on anything
> guile-email related. That would help me take note sooner. I found this
> bug report almost by chance.

You found it just in time. I only just put you on Cc after I became
convinced that this might be a parser failure.

--
Ricardo
A
A
Arun Isaac wrote on 4 Dec 2020 20:36
Re: [mumi] 44964 cannot be displayed
87360lnz1n.fsf@systemreboot.net
Toggle quote (3 lines)
> For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
> not split up into name and address parts but remains a single string.

I have fixed this bug in the latest guile-email master, and added
tests to prevent regression. See
and

I thought “Jorge P. de Morais Neto <jorge+list@disroot.org>” was an
invalid email address due to the period character, but apparently it is
supported by the obsolete addressing specification of RFC5322 (see
obsolete parts of the specification until now.

Toggle quote (3 lines)
> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
> problem, which I suspect might be a bug in guile-email.

guile-email should guarantee the parsed From header is an alist of the
appropriate form. So, I vote for reverting this commit, thus reducing
complexity on mumi's end. But, I understand that guile-email is not yet
doing a great job of providing these strong guarantees.

Cheers!
-----BEGIN PGP SIGNATURE-----

iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl/Kj9UbHGFydW5pc2Fh
Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzgY8IAK9kFeeaaYb3Q91efgLD
KNikD6Zo4/u3mui68gozn06D9yccPoG+Qp9nOVn9HSSI/Uln6tRrfhPpZR8lSRi2
f1yuKUez5Sr6vxOdhBL1F8SZ3WXm6EQFzbbEnR90QK8CaXXVFYmHukSPZ10/s/J1
xrl54EwINSdmFtZYyCEPclurA+Fdfpz3XN4MOZkzSLJYuu8J6ltlE38ydnv09XnH
2tHsBW4mTw0M7fI/0iuK6VfDrk9K0LcUahg8rB7DgbyU7oyfZm/mqifhdD4KTSLi
xxXR1vPgBjeNKDUh0DKF6CSQy488YfKcoa3NfiqS+DXyfawKSLn56vjD3kYk52cR
C+A=
=jQ48
-----END PGP SIGNATURE-----

A
A
Arun Isaac wrote on 6 Dec 2020 05:40
control message for bug #45015
(address . control@debbugs.gnu.org)
87zh2rmtrl.fsf@systemreboot.net
close 45015
quit
-----BEGIN PGP SIGNATURE-----

iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl/MYM4bHGFydW5pc2Fh
Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzDCQH/AshVrx+dLM16GyvGtYu
e2fJzDcgRQSnS4yjA671e2Vz78JHIg02CRMEILDEXuRjB2rJ80G/An31k0BoQpOF
b8ekR6eIi3phgXEAZVrwiV9VJ7Q/xwMeKWNV4yih4oDwVJC6lhW2sCm8gIsBiVDu
JoFLcKlZXJ7ZJBRts+U8G391vVCmnwV78S/vD3zHJTPy0GMiH7PvqLR3LLIpK8q1
JT3a/LixoS379DigLM31G9LQxfT0EVwYXYvG+1fKkeI9fLtbuntMKZU/pOj+FB+U
qZT2wKjUKugSxdHPoZXtMMyynL0Di4xIcZANqZDQ3S8TML7jIi5A3mdyadsi7TmH
Xtg=
=Hi3+
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 6 Dec 2020 12:30
Re: [mumi] 44964 cannot be displayed
(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 45015@debbugs.gnu.org)
87360j6ukf.fsf@elephly.net
Arun Isaac <arunisaac@systemreboot.net> writes:

Toggle quote (9 lines)
>> For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
>> not split up into name and address parts but remains a single string.
>
> I have fixed this bug in the latest guile-email master, and added
> tests to prevent regression. See
> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
> and
> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37

Thank you! You are always very fast and thorough; I appreciate this a lot!

Toggle quote (7 lines)
>> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
>> problem, which I suspect might be a bug in guile-email.
>
> guile-email should guarantee the parsed From header is an alist of the
> appropriate form. So, I vote for reverting this commit, thus reducing
> complexity on mumi's end.

I agree. I wasn’t sure how difficult it would be to fix it in
guile-email, so I added the workaround just in case it takes longer.
I’ll upgrade and revert that commit soon.

--
Ricardo
A
A
Arun Isaac wrote on 6 Dec 2020 12:50
(name . Ricardo Wurmus)(address . rekado@elephly.net)(address . 45015@debbugs.gnu.org)
87lfebm9uv.fsf@systemreboot.net
Toggle quote (9 lines)
>> I have fixed this bug in the latest guile-email master, and added
>> tests to prevent regression. See
>> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
>> and
>> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37
>
> Thank you! You are always very fast and thorough; I appreciate this a
> lot!

Thank you, I really appreciate the acknowledgement! :-)
-----BEGIN PGP SIGNATURE-----

iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl/MxZgbHGFydW5pc2Fh
Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzMpAH/0A2LZ+O2rluWo8zaCfq
W2U5ewrAy5PR9ZSGLRbmKP8pmjw8cW6FEsKC5cSEag8QRbQWGfosAb1SHZBSJLDP
+PhcfpdCXgRrKxxXXV7Mskk0XITPHd7CEJEL92EKQM1YHgftBtiNoZF2T5eZWeS8
xMP3aTvFas9pKubfGzpTGSGYz5e6QkYg4cPyI5hoWauZT2/O5YqZzK0l4DZ1ZwXN
TK1R1o7UASXSFeC4VadhsXAdvUVlKxgVnIL4lwqOaRPb4GzfcIn9RcZljlf2BxHZ
iY8rl/B+JDgiv2Xrb56cQNfVVkVagrFmt1mz3+ix/gJaRTlpRjyUHMzWCvWWKBJH
PpY=
=XW5H
-----END PGP SIGNATURE-----

F
F
Felix Lechner wrote on 23 Feb 14:23 +0100
(no subject)
(address . control@debbugs.gnu.org)
875xyf1fhb.fsf@lease-up.com
unarchive 68680
reassign 68680 mumi
archive 68680

unarchive 63802
reassign 63802 mumi
archive 63802

unarchive 63215
reassign 63215 mumi
archive 63215

unarchive 61645
reassign 61645 mumi
archive 61645

unarchive 60410
reassign 60410 mumi
archive 60410

unarchive 60292
reassign 60292 mumi
archive 60292

unarchive 60292
reassign 60292 mumi
archive 60292

unarchive 58573
reassign 58573 mumi
archive 58573

unarchive 54024
reassign 54024 mumi
archive 54024

unarchive 49115
reassign 49115 mumi
archive 49115

unarchive 48160
reassign 48160 mumi
archive 48160

unarchive 47739
reassign 47739 mumi
archive 47739

unarchive 47520
reassign 47520 mumi
archive 47520

unarchive 47121
reassign 47121 mumi
archive 47121

unarchive 45015
reassign 45015 mumi
archive 45015

unarchive 43661
reassign 43661 mumi
archive 43661

unarchiv 43166
reassign 43166 mumi
archive 43166

unarchive 41906
reassign 41906 mumi
archive 41906

unarchive 41098
reassign 41098 mumi
archive 41098

unarchive 39924
reassign 39924 mumi
archive 39924

unarchive 39924
reassign 39924 mumi
archive 39924

unarchive 39924
reassign 39924 mumi
archive 39924

thanks
?