[PATCH staging 0/6] Add Pitivi

Hello Guix,

the following patch series adds the video editor Pitivi [1]. As it

depends on GStreamer >= 1.17.90 (i.e. de facto 1.18), it has to be

applied to the staging branch. There are also some minor changes to

the packages around it, e.g. the now deprecated gst-transcoder and a

minor fix to ffmpeg-4.2 (for those who want to build pitivi without

waiting hours on Rust).

Regards, Leo.

[1] http://www.pitivi.org/

---

gnu/packages/gnome.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

Add gobject-introspection and glib:bin.

---

gnu/packages/gstreamer.scm | 2 ++

1 file changed, 2 insertions(+)

---

gnu/packages/gstreamer.scm | 22 ++++++++++++++++++++++

1 file changed, 22 insertions(+)

As of 1.18, gst-transcoder is part of gst-plugins-bad.

Redefine in terms of gst-plugins-bad and deprecate in favor of it.

---

gnu/packages/gstreamer.scm | 7 +++++++

gnu/packages/video.scm | 28 ----------------------------

2 files changed, 7 insertions(+), 28 deletions(-)

---

gnu/packages/video.scm | 67 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 67 insertions(+)

---

gnu/packages/video.scm | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

On Sun, Nov 22, 2020 at 09:34:23PM +0100, Leo Prikler wrote:

Thanks! It will be great to have this in Guix.

On Sun, Nov 22, 2020 at 09:36:21PM +0100, Leo Prikler wrote:

Can you add a brief comment to the commit message explaining why we do

this?

On Sun, Nov 22, 2020 at 09:36:22PM +0100, Leo Prikler wrote:

With the patch series applied on the current staging branch

(56e2da5ae851c), compilation of Guix fails like this:

------

$ guix environment --pure guix -- make -j4

[...]

gnu/packages/gstreamer.scm:907:0: error: (define-public gst-plugins/selection (lambda* (pkg #:key plugins configure-flags)) "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are\ngiven, also pass them to the build system instead of the ones used by PKG." (package/inherit pkg (arguments (substitute-keyword-arguments (package-arguments pkg) ((#:configure-flags flags (quasiquote (list (unquote-splicing (or configure-flags (quote ()))))) (quasiquote (append (list (unquote-splicing (map (lambda (plugin) (string-append "-D" plugin "=enabled")) plugins))) (unquote (or configure-flags flags))))) ((#:phases phases) (quasiquote (modify-phases (unquote phases) (add-after (quote unpack) (quote disable-auto-plugins) (lambda _ (substitute* "meson_options.txt" (("'auto'") "'disabled'")) #t)))))))))): source expression failed to match any pattern

make[2]: *** [Makefile:6247: make-go] Error 1

------

Can you reproduce it?

On Sun, Nov 22, 2020 at 09:36:23PM +0100, Leo Prikler wrote:

This is good but I think we can just remove gst-transcoder, right? I

don't see any packages using it in Guix.

On Sun, Nov 22, 2020 at 09:36:24PM +0100, Leo Prikler wrote:

Overall LGTM.

Do we do this to save space? Or to avoid the rest of the bad plugins?

Am Dienstag, den 15.12.2020, 02:25 -0500 schrieb Leo Famulari:

Both would be valid reasons to do this imo. Adding more bad plugins is

likely also not going to increase the number of features Pitivi offers.

On Sun, Nov 22, 2020 at 09:36:25PM +0100, Leo Prikler wrote:

Thanks, I pushed this patch as commit

54d832680652faa23711ec326462f9a62645080d, along with a similar commit

for FFmpeg 2.8.

Nothing is using this package at the moment... it should be removed

eventually.

Am Dienstag, den 15.12.2020, 02:21 -0500 schrieb Leo Famulari:

That may be the case, but I've opted to inform users about its

deprecation first. It was probably packaged in an earlier effort to

add pitivi, but who knows whether someone might be having it in their

profile for some personal project?

Some packages, such as Pitivi, might want to interact with GES through

GObject Introspection, so let's enable that.

Add gobject-introspection and glib:bin.

---

gnu/packages/gstreamer.scm | 2 ++

1 file changed, 2 insertions(+)

---

gnu/packages/gnome.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

---

gnu/packages/gstreamer.scm | 22 ++++++++++++++++++++++

1 file changed, 22 insertions(+)

As of 1.18, gst-transcoder is part of gst-plugins-bad.

Redefine in terms of gst-plugins-bad and deprecate in favor of it.

---

gnu/packages/gstreamer.scm | 7 +++++++

gnu/packages/video.scm | 28 ----------------------------

2 files changed, 7 insertions(+), 28 deletions(-)

---

gnu/packages/video.scm | 67 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 67 insertions(+)

Am Dienstag, den 15.12.2020, 02:16 -0500 schrieb Leo Famulari:

I've rerolled the patches, taking your input into account. Since

master has GStreamer 1.18.1 now, it is no longer a patch for staging,

but should be able to be applied on master directly.

Regards,

Leo

On Tue, Dec 15, 2020 at 10:03:06AM +0100, Leo Prikler wrote:

Thanks! The updated patches work for me and the Pitivi editor seems nice

— hopefully it's a useful balance of simplicity and utility.

I invite you to apply for commit access, following the steps in the

manual section Commit Access. I will be one of the three references for

you.

What do you think?

On Tue, Dec 15, 2020 at 09:45:44AM +0100, Leo Prikler wrote:

Okay, that makes sense. We should remember to complete the process and

remove the package eventually :)

On Tue, Dec 15, 2020 at 08:55:17AM +0100, Leo Prikler wrote:

This is a good idea for the "bad" plugins, because they are rarely used

in Guix, so there is less chance of unecessary duplication compared to

the other collections of GStreamer plugins.

Still, it increases complexity, and it sholud be "worth it" in some

sense. If gst-plugins/selection becomes popular, it may be that the

increase in package objects outweighs the disk space savings — the

package graph may grow so large that it slows Guix package operations

down too much. The disk space savings may be obviated in that case,

anyways.

If you choose to apply for commit access, as I suggested, you will be

able to use your judgement here :)

Am Dienstag, den 15.12.2020, 16:31 -0500 schrieb Leo Famulari:

There is sadly still a lot of duplication between a plugin "selection"

and its base package, so the option will have to be used sparingly.

The reason why I opted for writing a procedure, that redoes the whole

build rather than just copying some shared libraries, is because I

don't think the latter would be particularly safe to do. Perhaps I'm

wrong on that, however.

I think it's only "worth it" when importing not more than two or three

plugins from "bad" or "ugly". Even then the savings are only moderate,

as gstreamer will still build what it deems to be absolutely necessary.

To be completely honest, I also don't expect this to be around for too

long. I am more than happy to see this procedure vanish at some point

when we have parameters, though maybe that'd be a very Gentoo-y way of

using parameters and still suffer from the same problem.

Sounds like it slowly gets time to take this serious and apply for

commit access, then. I'll try to get that done soon-ish™.

Regards,

Leo

Hello,

Am Mittwoch, den 16.12.2020, 01:18 +0100 schrieb Leo Prikler:

Now that I do have commit access, is there anything still blocking

this? I don't want to push a controversial change too quickly ?.

Regards,

Leo

On Tue, Dec 29, 2020 at 07:28:40PM +0100, Leo Prikler wrote:

Go for it!

My take on the conversation is that it's worth it for gst-plugins-bad,

which is rarely used.

I'm looking forward to `guix install pitivi`

Am Dienstag, den 29.12.2020, 14:04 -0500 schrieb Leo Famulari:

Now pushed as c412900d3e8c59ad59c994fd65634f9aafae1800.