“guix import cran -a bioconductor FOO” downloads twice

  • Done
  • quality assurance status badge
Details
2 participants
  • Ricardo Wurmus
  • zimoun
Owner
unassigned
Submitted by
zimoun
Severity
normal
Merged with
Z
Z
zimoun wrote on 27 Oct 2020 14:55
“guix import cran -a bioconductor F OO” downloads twice
(address . bug-guix@gnu.org)
865z6v4vuw.fsf@gmail.com
Dear,

Toggle snippet (11 lines)
$ guix import cran -a bioconductor CATALYST

Starting download of /tmp/guix-file.OPtOW1
From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
…12.2.tar.gz 10.2MiB 567KiB/s 00:18 [##################] 100.0%

Starting download of /tmp/guix-file.V6sC1Z
From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
…12.2.tar.gz 10.2MiB 565KiB/s 00:19 [##################] 100.0%

I have not investigated more, if the issue is from the importer or from
the information provided by Bioconductor.


All the best,
simon
Z
Z
zimoun wrote on 25 Feb 2021 16:28
Re: bug#44256: “guix import cran -a bioconductor FOO” downloads twice
(address . 44256@debbugs.gnu.org)
87sg5kcgkl.fsf@gmail.com
Hi,

On Tue, 27 Oct 2020 at 14:55, zimoun <zimon.toutoune@gmail.com> wrote:

Toggle quote (13 lines)
> $ guix import cran -a bioconductor CATALYST
>
> Starting download of /tmp/guix-file.OPtOW1
>>From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
> …12.2.tar.gz 10.2MiB 567KiB/s 00:18 [##################] 100.0%
>
> Starting download of /tmp/guix-file.V6sC1Z
>>From https://bioconductor.org/packages/release/bioc/src/contrib/CATALYST_1.12.2.tar.gz...
> …12.2.tar.gz 10.2MiB 565KiB/s 00:19 [##################] 100.0%
>
> I have not investigated more, if the issue is from the importer or from
> the information provided by Bioconductor.

It comes from ’cran->guix-package’ in (guix import cran):

Toggle snippet (5 lines)
(let ((description (fetch-description repo package-name)))
(if description
(description->package repo description)

where ’fetch-description’ effectively downloads but then
’description->package’ downloads again:

Toggle snippet (6 lines)
(source (download source-url #:method (cond
(git? 'git)
(hg? 'hg)
(else #f))))

This second download is not necessary. The fix needs some care with the
different repositories.


Cheers,
simon
Z
Z
zimoun wrote on 2 Jul 2021 18:32
control message for bug #48792
(address . control@debbugs.gnu.org)
87h7hcn0by.fsf@gmail.com
merge 48792 44256
quit
R
R
Ricardo Wurmus wrote on 29 Nov 2024 19:35
“guix import cran -a bioconductor F OO” downloads twice
(address . 44256@debbugs.gnu.org)
87v7w5c2he.fsf@elephly.net
Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
branch). This will soon be rebased on top of the master branch and
merged.

--
Ricardo
S
S
Simon Tournier wrote on 2 Dec 2024 16:02
Re: bug#44256: “guix import cran -a bioconductor FOO” downloads twice
87plmann5x.fsf@gmail.com
Hi Ricardo,

On Fri, 29 Nov 2024 at 19:35, Ricardo Wurmus <rekado@elephly.net> wrote:
Toggle quote (4 lines)
> Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
> branch). This will soon be rebased on top of the master branch and
> merged.

Cool for the fix! Hum, I do not find this commit. Do I miss something?

Cheers,
simon
R
R
Ricardo Wurmus wrote on 2 Dec 2024 21:23
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 44256@debbugs.gnu.org)
87a5ddal6h.fsf@elephly.net
Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (9 lines)
> Hi Ricardo,
>
> On Fri, 29 Nov 2024 at 19:35, Ricardo Wurmus <rekado@elephly.net> wrote:
>> Fixed with commit 64d9c7ea3fec163d86dde933471594ef2fe8c356 (on r-team
>> branch). This will soon be rebased on top of the master branch and
>> merged.
>
> Cool for the fix! Hum, I do not find this commit. Do I miss something?

You didn't miss anything. The r-team branch keeps getting rebased as
other branches are merged into master, so the commit hash changes. I'll
try to remember to close this bug once the r-team branch has been
merged.

--
Ricardo
R
R
Ricardo Wurmus wrote on 4 Dec 2024 12:44
“guix import cran -a bioconductor F OO” downloads twice
(address . 44256-done@debbugs.gnu.org)
87h67j8yfg.fsf@elephly.net
The commit fixing it is f0a93b18b4488c3bb802197aba4a31b28508c902 on the
master branch.

Since this bug was reported, there is a new extraneous download which
does not originate from the importer itself, as discussed here:

It may be worth opening a new bug report about this.

--
Ricardo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 44256@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 44256
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch