lz4 CC=gcc - Why?

  • Done
  • quality assurance status badge
Details
2 participants
  • Danny Milosavljevic
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Danny Milosavljevic
Severity
normal

Debbugs page

Danny Milosavljevic wrote 4 years ago
(address . bug-guix@gnu.org)
20201012142139.757ad36e@scratchpost.org
* lz4 has "CC=gcc". Shouldn't that be (string-append "CC=" (cc-for-target)) ?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+ESmEACgkQ5xo1VCww
uqXVLAf9GYez53tACfwTtUujY34eiHy5FaHAFk5B8LmoOBc+uoOB/f4UG5bQvpL/
HubXO9wFbge4M/OohxFocjVNvU3XFwrWk6TfCO2IN0uQTpE+/W57sC1IPeSQLxFS
9Z+CkeyM5Z6cZetNf9GcKXJVJ8IUZJZcIn0aO8qeC9OWeY1Y3tQYv//8bf4j5kxw
/lfr8k7wMd/F4UQ9WWJdTysM4UD4uvOqc/eYAYcHn05SRqs8CvqEl8hrHj/n55wA
kDwW6AwlftD6sFORYMfF3eJQP8+nFd4zUjsehwiniDpVYnSKg3NdzwIlndDdS0lz
ayLymwvA7oIJQMpBGfFWOGU6El3+Sg==
=4Fxq
-----END PGP SIGNATURE-----


Tobias Geerinckx-Rice wrote 4 years ago
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 43950-done@debbugs.gnu.org)
87eem3invh.fsf@nckx
Danny,

Danny Milosavljevic 写道：
Toggle quote (2 lines)
> lz4 CC=gcc - Why?

For the same reason as the *hundreds* of other ‘CC=gcc’
occurrences in the tree: CC-FOR-TARGET is new. Out of all of
them, why are you so interested in LZ4 (I think this is your
second mail on it :-)?

I'm currently slogging through the "CC=gcc"s & removing as many as
possible; not fun work but can be done completely off-line.

LZ4 tweaked in 2b6ecdf41a09ab9ecae06d7c537583a2f0f28efc,

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX4RXog0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15aisA/1sVeSexc7HEGDttPGIgAOWVAi3jlPyyFsoQJgbR
2eY2AQD/jK+DmqV73m7B9LupQqZTOdBTwxPdVtB7yq1PawgSBw==
=wJee
-----END PGP SIGNATURE-----

Closed
Danny Milosavljevic wrote 4 years ago
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 43950-done@debbugs.gnu.org)
20201012155701.54fa6bae@scratchpost.org
Hi,

On Mon, 12 Oct 2020 15:18:26 +0200
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

Toggle quote (4 lines)
> For the same reason as the *hundreds* of other ‘CC=gcc’
> occurrences in the tree: CC-FOR-TARGET is new. Out of all of
> them, why are you so interested in LZ4

It's a dependency of genimage (via squashfs-tools). Breaking it breaks
guix system image generation.

It's a dependency of u-boot. Breaking it breaks booting on all ARM
machines.

So I rather didn't want to touch it without confirmation...

Toggle quote (2 lines)
> (I think this is your second mail on it :-)?

Ludo said to send extra mails for each--so that's what I am doing.

Toggle quote (2 lines)
> LZ4 tweaked in 2b6ecdf41a09ab9ecae06d7c537583a2f0f28efc,

Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+EYK0ACgkQ5xo1VCww
uqWhCAgAjmCe+kiClHO6BV1ik2Z2tZol8nnVW9btVYmugPsCSicMjzyJHj9XL6gp
GRxObAnDJRot2FASaTjTm5zilVywoQNYaSVKdvX9GzNlDNLcv4rmIW3a/mZpW/e+
i3EJuYh9rs2ybY1TJXz+LHqb0+Ozla08ExG+v5lLDXGi2aIQhej2Fcxy7TAEGwvl
UiVxfvH5yssOs81gT/qqyA8ZeSuqY0UVDhqgszqVZNLEk6GsX+oRmpxet29q22aP
PrfFXmDhLFUnFqlleYRY8VU4L5KbPXofSu47vw3MrRDHec9rUefAHIn7Vv+LV5UV
pGhxeUxNr23Ilehp1ymI8xVpFdvVNw==
=i4FI
-----END PGP SIGNATURE-----


Closed
Tobias Geerinckx-Rice wrote 4 years ago
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 43950-done@debbugs.gnu.org)
875z7fiao3.fsf@nckx
Hi Danny,

Danny Milosavljevic 写道：
Toggle quote (8 lines)
> It's a dependency of genimage (via squashfs-tools). Breaking it
> breaks
> guix system image generation.
>
> It's a dependency of u-boot. Breaking it breaks booting on all
> ARM
> machines.

Thanks. Yes, unfortunately it's a dependency of a lot, making it
a staging package.

I didn't rebuild all dependents before pushing but I did build
several packages including u-boot-pine64-lts (on x86_64) as a
smoke test. I also verified that lz4 with
--target=aarch64-linux-gnu actually builds for aarch64 now. I
think it's safe.

If anything were to break I'd say it must have been broken before,
but do let me know if it happens.

Toggle quote (3 lines)
> Ludo said to send extra mails for each--so that's what I am
> doing.

Each package using CC=gcc? There are currently hundreds; I don't
think that's what Ludo' meant. Do hope to have it down to tens
soon...

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX4SafA0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15ovUA/iCzkx4DFZFwRCaLBoZH9hd2wkeg75aDwCv5HYAX
wbnLAP9trgq7a3EYOD0VV4T9u+ltzwpPgGPqpFr88un8P97qCA==
=VsAM
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 43950@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 43950
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help