git-fetched packages' working copy is not writable

  • Done
  • quality assurance status badge
Details
3 participants
  • Danny Milosavljevic
  • Efraim Flashner
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Danny Milosavljevic
Severity
normal
D
D
Danny Milosavljevic wrote on 24 Aug 2020 11:13
(address . bug-guix@gnu.org)
20200824111359.4008ce30@scratchpost.org
Hi,

the working copy of a package build when the package was git-fetched is not
writable.

On the other hand, if it's url-fetched, it's perfectly writable.

Shall we fix this on core-updates ?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9DhNcACgkQ5xo1VCww
uqVjnQgAlViT4A8YjNv5uTgfo2WUtVxntyJslfOOPm6kP27lsQLRKOIwXB0bkkQg
Wd8kBKow9ConVYzDJOdnATMQmmSD8hbn/aumTvhEk83QQE8LkeUIglmDcToqiX6v
1isKqXdc6MjoRNi7xXosWFPaP3guaATWyT0nRD84vrQrDAui30CkOLTQHzTnVNFX
rQShNyhMAQdPoKbvaTZGHoRcFNzJo9SIO9HPl7afjW2oQoxPO1jAWjxTjX7c2eHO
c47ScURQhBWTj/GV4bLd6vYtJX2OXuZVwmCcS2+zM+mEQ2A+FPCKw4w4i39OaHMG
lkl1+V7UtQee67u021CtD07m7RwFJg==
=wI1k
-----END PGP SIGNATURE-----


E
E
Efraim Flashner wrote on 24 Aug 2020 11:22
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 43015@debbugs.gnu.org)
20200824092256.GH1392@E5400
On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
Toggle quote (9 lines)
> Hi,
>
> the working copy of a package build when the package was git-fetched is not
> writable.
>
> On the other hand, if it's url-fetched, it's perfectly writable.
>
> Shall we fix this on core-updates ?

(ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-writable
gnu/packages/code.scm: (add-after 'unpack 'make-files-writable
gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-writable
gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable
gnu/packages/ruby.scm: (add-after 'unpack 'make-files-writable

My only concern would be if there were files which weren't supposed to
be writable. We're building the package, not making changes to be
submitted upstream or anything, so I don't see that as being a reason to
hold back.

I'm in favor



--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9Dhu0ACgkQQarn3Mo9
g1HidRAAtzv1ZzynJi32LBGiOTmfl91eHtzgi9XluUK8CLYljE0ajtCENgqlCGx4
wX1xhfSIgJZuJRJ01oDODaL6AcU7jiHj03uMwasPyNRKMIbJeqJKsAzSHOVjXm5F
/OvYqKj9PChx1cgOpxuduodeFSlf+sfWNaoMwJ6iA/EeV6ZrNq+na/kuojfP2Wz6
E6kIVRqy7Lphhlaj1D9Z33oeaxNQBn4d41kQc0Bn796/MDcIkDifl7gUvqnkGTX/
gDdUTV8qWdVQwexQg+xL2cjftrxm40oNhnwuNZP+FuzwTiNWLK7Z0TzuHPBBC1bJ
v9xQ1tqDPwaLSQKFxgJG6XsCzg+FiXp6xddFmeAaBcE7vcvTWywOMBe9UvISAw3j
ByL1nUze3+W+tE/5sSxBREmEXiVyX9ZUJ87rsG7+aToPVSoFujCLHQtgfmhV97HN
Y+TbhoNet+inqXv7WBcZ+OqvhFmxpd0is/5Tt68oXlEyhnYUG9tGnHuChHCQTN4N
WXXFd+S/jt+/cAmpRn/Zzff3I53m4t0NmfozOHmMbKMMpFnO7lEvi/dmXrX9ye0m
k2WYtLLjaQWtf3ehpR57EipNEbf/3iY4KGjvGRI0+mM8hCqCQJGA+wrdRzfnvD1c
uE7fvFBcJ2rT2NpnfkqK1pmQNCQ9GlHu5J/15rT63J0Ob6uUhnE=
=K8+9
-----END PGP SIGNATURE-----


M
M
Maxim Cournoyer wrote on 4 Feb 2021 13:41
(name . Efraim Flashner)(address . efraim@flashner.co.il)
87k0rongyh.fsf@gmail.com
Hello,

Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (29 lines)
> On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote:
>> Hi,
>>
>> the working copy of a package build when the package was git-fetched is not
>> writable.
>>
>> On the other hand, if it's url-fetched, it's perfectly writable.
>>
>> Shall we fix this on core-updates ?
>
> (ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages
> gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/code.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/java.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable
> gnu/packages/ruby.scm: (add-after 'unpack 'make-files-writable
>
> My only concern would be if there were files which weren't supposed to
> be writable. We're building the package, not making changes to be
> submitted upstream or anything, so I don't see that as being a reason to
> hold back.
>
> I'm in favor

I've included the fix as part as the unpack phase, and pushed to
core-updates as commit 6129ebddbd.

Thanks for the report!

Closing.

Maxim
Closed
?