[PATCH] utils: Add version-major+minor+point.

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Jonathan Brielmaier
Owner
unassigned
Submitted by
Efraim Flashner
Severity
normal
E
E
Efraim Flashner wrote on 13 Aug 2020 13:48
(address . guix-patches@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
20200813114839.6814-1-efraim@flashner.co.il
* guix/utils.scm (version-major+minor+point): New procedure.
---
guix/utils.scm | 11 +++++++++++
1 file changed, 11 insertions(+)

Toggle diff (38 lines)
diff --git a/guix/utils.scm b/guix/utils.scm
index 436c5cd093..2f698b0bb0 100644
--- a/guix/utils.scm
+++ b/guix/utils.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2015 David Thompson <davet@gnu.org>
;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
;;; Copyright © 2018, 2020 Marius Bakke <marius@gnu.org>
+;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -82,6 +83,7 @@
version>?
version>=?
version-prefix
+ version-major+minor+point
version-major+minor
version-major
guile-version>?
@@ -564,6 +566,15 @@ or '= when they denote equal versions."
For example, (version-prefix \"2.1.47.4.23\" 3) returns \"2.1.47\""
(string-join (take (string-split version-string #\.) num-parts) "."))
+(define (version-major+minor+point version-string)
+ "Return \"major>.<minor>.<point>\", where major, minor and point are the
+major, minor and point version numbers from the version-string. For example,
+(version-major+minor+point \"6.4.5.2\") returns \"5.4.5\" or
+(version-major+minor+point \"1.19.2-2581-324ca14c3003\") returns \"1.19.2\"."
+ (let* ((3-dot (version-prefix version-string 3))
+ (index (string-index 3-dot #\-)))
+ (or (false-if-exception (substring 3-dot 0 index))
+ 3-dot)))
(define (version-major+minor version-string)
"Return \"<major>.<minor>\", where major and minor are the major and
--
2.28.0
J
J
Jonathan Brielmaier wrote on 13 Aug 2020 14:25
(address . guix-patches@gnu.org)
dae14355-69e2-3324-2f33-f932a4b306e5@web.de
On 13.08.20 13:48, Efraim Flashner wrote:
Toggle quote (1 lines)
> +(version-major+minor+point \"6.4.5.2\") returns \"5.4.5\" or
^ I guess that is
an typo and should be a 6
E
E
Efraim Flashner wrote on 13 Aug 2020 18:16
(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)(address . 42847@debbugs.gnu.org)
20200813161627.GG1228@E5400
On Thu, Aug 13, 2020 at 02:25:55PM +0200, Jonathan Brielmaier wrote:
Toggle quote (6 lines)
> On 13.08.20 13:48, Efraim Flashner wrote:
> > +(version-major+minor+point \"6.4.5.2\") returns \"5.4.5\" or
> ^ I guess that is
> an typo and should be a 6
>

Definitely a typo. I fixed it locally in my patch file.

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl81Z1sACgkQQarn3Mo9
g1H6qxAAvUPfqqoqeoYyPKjPBHbfTWduHFS94r1sIA7y8C7r9ko7E/8ZaSeNyHCf
QJF7UPX0f/+YFFeNSAFVYt+/wzQvujFtsN77GtZPbeuvMYWQi4oZxWTocOUHbHao
PSkFloI203LnAKcNhPFjblCPTrescYIDT1GvXJUVnUQ5hUKmeBngYpLS4cVR9Eg4
rAb38B2aY2bFGvs4lIMeg3Hq8fhsikzDfx6zxagD5AuOc2/Ru7VBkyxIzAbT5Yhm
qlw3Cou8nfZE1NDpsGJF1PyEMQ9XDF1QM54GQUXyz+ETm7mZL7N8Xbu1wNIqRe5V
Hj2wAF8bCaA2KaH6D4LMJYNfexmXIGEDyqdA+NKqXbgvFl3yVbHVBRBm1T2Ie4nR
FndVVPsAiLDUjuJFFfglj2p/iTa60iUTrW9Gjul1ZUANH4nEl+Cy1kl8YwnUVDKI
lpEV2ooXD65ZZQsGZARnvukL3rols46X+4yYW7bpHvatqtmWm2+evUACeqFYnaSj
epPmKEd2IiT0U79FPEugMg7nZGddLvsfhkKbSuL0CguJmRff8J8bvKZd/wk/kWU3
I0XyeRi9Jmqm6HBLKcbidToqDykphOty7PRzwfKpPwFuqMjKTsuy+oo3nEghAh1S
fYPsonZQifs87brbXy6b5a1GkqUtPY77HEwBbgV+A6BlwPQmFzE=
=t0Uw
-----END PGP SIGNATURE-----


E
E
Efraim Flashner wrote on 17 Aug 2020 06:58
Re: [PATCH] utils: Add version-major+minor+point.
(address . 42847-done@debbugs.gnu.org)
20200817045804.GD22637@E5400
Patch pushed


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl86DlwACgkQQarn3Mo9
g1HZXRAAu+fyaVz2dB13av/6khPjQIhg1m9cow44vIYfy5E+6g8a8wIUs9zv8LvS
ffVXIZrCtXXF/PO22I00KqA7JjfBbvTs8OLiNJ6S9lLdozmkezVOQ4Ct9qHNTFfL
Jzb3WtvcjrPUnoD0XIaebjyBeACVwQAzl1yJcDCez/N768GSokTe6wqlHJrhqj/P
Z6YHmfCFcchePBA31Ng+c869bDh8gGgSWqXVdpaFyuFAoi2jhvHTQZnleCzbH/pO
fZ4QtFN31UaZZu2t1Muk3FQASMiOoN2Jy/tPjLGLDNvdyu0jO/qHgjzMPqMzv1/9
CYJzhQQZWk8EbImw2OpzHLs3XDdAHXlhy82KLtjb09NL0M6TGme62J3Yn2a/i1LD
9AFREuo69zN5jz9xmi61B23yV8dlM4vJqGoEg78XPH8ZPAWR0v2eK5iRCY2rOdoh
O51PZ0Vl0FsNGMVeCao9vDXxCgbUD6oltTJzTon24sN245UPaUwENkVr2btu8tZs
8a9dRq+Q126QPwnhaIFMDz+9fi/nqJtltWVlObIhXLkWHgafClFPAsrocng+6WMk
RZOo+lusB+APHd2hO8Yn5VPCX0gn9dv49d/KXS9tkfFIyRy8VnAsLnM5vug9Pub1
yJfQRrxCqzZ4in8KhsyKrErXKdJvmxA0cY4TWKJ+K/8xoojKUCg=
=vpG1
-----END PGP SIGNATURE-----


Closed
?