[PATCH] bump Node to 14.6

Done

Details

3 participants

Formbi
Jelle Licht
Jakub Kądziołka

Owner: unassigned

Submitted by: Formbi

Severity: normal

Formbi wrote on 31 Jul 2020 19:11

Recipients:(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)

Message-ID:tN6dc0jlib3fz91hRViWOMPWBBaRSulxZN7pevQOHnoTLjBmpFdA2em-AUB5sqqbxhbtUNE2Q635-1JOyrbrZ39MZHWOgGCCMUvnwPeaqqs=@protonmail.com

Empty Message

From 0dc32f60b10c39f585d3535f3ff35e0e9812a6a0 Mon Sep 17 00:00:00 2001

---

gnu/packages/node.scm | 54 +++++++++++++++++++++++++++++++++++++++++++

1 file changed, 54 insertions(+)

Toggle diff (67 lines)diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index 1adb2cd07f..a7658e626a 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -199,6 +199,60 @@ devices.")
     (properties '((max-silent-time . 7200)     ;2h, needed on ARM
                   (timeout . 21600)))))        ;6h
 
+(define-public node-14.6
+  (package
+    (inherit node)
+    (version "14.6.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://nodejs.org/dist/v" version
+                                  "/node-v" version ".tar.xz"))
+              (sha256
+               (base32
+                "153a07ffrmvwbsc78wrc0xnwymmzrhva0kn6mgnfi3086v3h1wss"))
+              (modules '((guix build utils)))
+              (snippet
+               `(begin
+                  ;; Remove bundled software.
+                  (for-each delete-file-recursively
+                            '("deps/cares"
+                              "deps/icu-small"
+                              "deps/openssl"))
+                  (substitute* "Makefile"
+                    ;; Remove references to bundled software.
+                    (("deps/http_parser/http_parser.gyp") "")
+                    (("deps/uv/include/\\*.h") ""))
+                  #t))))
+    (arguments
+     (substitute-keyword-arguments (package-arguments node)
+       ((#:configure-flags configure-flags)
+        ''("--shared-cares"
+           ;; "--shared-http-parser"
+           ;; node can't find the pkg-config file for http-parser
+           "--shared-libuv"
+           ;; "--shared-nghttp2"
+           ;; for some reason only the bundled nghttp2 works
+           "--shared-openssl"
+           "--shared-zlib"
+           ;; "--without-snapshot"
+           ;; this option is no longer available
+           "--with-intl=system-icu"))
+       ;; Almost all the tests require NPM and the one that doesn't does
+       ;; something stupid and fails on 14.6
+       ((#:tests? _ #f) #f)
+       ;; The patch-files was preparing the tests, now it's not needed
+       ((#:phases phases)
+        `(modify-phases ,phases
+           (delete 'patch-files)))))
+    (inputs
+     `(("c-ares" ,c-ares)
+       ("http-parser" ,http-parser)
+       ("icu4c" ,icu4c-67)
+       ("libuv" ,libuv-1.38)
+       ("openssl" ,openssl)
+       ("zlib" ,zlib)
+       ("brotli" ,google-brotli)))))
+
 (define-public libnode
   (package
     (inherit node)
-- 
2.26.0

Jelle Licht wrote on 31 Jul 2020 23:26

Recipients:

Message-ID:87ime31ilf.fsf@jlicht.xyz

Hey Formbi,

Formbi via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (2 lines)

> Subject: [PATCH 2/2] bump node to 14.6

Sadly, recent node versions come bundled with generated code based on

the llhttp[1] project. These generated source files can be found in the

deps/llhttp/src directory of the 14.6 release, and the annoying thing is

that upstream uses typescript to generate these C files. See [2] for my

feeble attempt at having upstream take note of this issue to allow for

properly bootstrapping lltthp and subsequently recent versions of node.

There are some alternative typescript implementations that I

unsuccessfully have tried in the past in at least translating the

typescript used in llhttp to normal javascript, which we could then

interpret using our packaged version of node to build the C files that

would allow us to build newer versions of node. The ones I looked at in

some detail are:

- Sucrase [3] but it doesn't support all used typescript constructs

- swc [4] but it actually depends on the normal typescript compiler

I'm sorry I don't have better news to share either. Perhaps some

guile-guru can drop down from their higher spheres of existence and

create a hacky interpreter that translates typescript to

extremely-ugly-yet-correct javascript to help us escape this quagmire.

- Jelle

[1] https://github.com/nodejs/llhttp

[2] https://github.com/nodejs/llhttp/issues/14

[3] https://github.com/alangpierce/sucrase/issues/464

[4] https://github.com/swc-project/swc

Formbi wrote on 31 Jul 2020 23:33

Recipients:(name . Jelle Licht)(address . jlicht@fsfe.org)

Message-ID:TaiOK9GDidTtXiRXYoDN2CN6BnzbZsILKhZO7GDfjyrZFdYIpvv7nwYaxTX2sRhX27pJwV7WvEk0vLe4ac2We94cdbKAMsQKhcRCuI_cIlE=@protonmail.com

oh my bananas, that's bad news :(

Jelle Licht wrote on 31 Jul 2020 23:37

Recipients:

Message-ID:87ft971i3v.fsf@jlicht.xyz

Jelle Licht <jlicht@fsfe.org> writes:

Toggle quote (5 lines)> would allow us to build newer versions of node. The ones I looked at in
> some detail are:
>
> - Sucrase [3] but it doesn't support all used typescript constructs
> - swc [4] but it actually depends on the normal typescript compiler

[snip]

Toggle quote (1 lines)

> [4] https://github.com/swc-project/swc

It seems this is not actually the case, but swc still seems to depend on

having a rust nightly compiler available.

- Jelle

Formbi wrote on 31 Jul 2020 23:41

Recipients:(name . Jelle Licht)(address . jlicht@fsfe.org)(name . 42639@debbugs.gnu.org)(address . 42639@debbugs.gnu.org)

Message-ID:1w6Hk8z0yJiGKLNsVjy4eUMQv9GSSXxzwTyq3Hv3YUwxY0vW7psgQrUn8MEQPh6FA3ReZKmxzAq3U8fgReGn6J36_1mzpVYTX6hGABZDMvk=@protonmail.com

Toggle quote (2 lines)

> seems to depend on having a rust nightly compiler available.

we have Rust 1.45.1 in Guix, wouldn't it be sufficient?

Jakub Kądziołka wrote on 7 Aug 2020 00:01

Recipients:

Message-ID:20200806220124.rc32clbnwozgbnqs@gravity

On Fri, Jul 31, 2020 at 11:37:24PM +0200, Jelle Licht wrote:

Toggle quote (14 lines)> Jelle Licht <jlicht@fsfe.org> writes:
> 
> > would allow us to build newer versions of node. The ones I looked at in
> > some detail are:
> >
> > - Sucrase [3] but it doesn't support all used typescript constructs
> > - swc [4] but it actually depends on the normal typescript compiler
>  [snip]
> > [4] https://github.com/swc-project/swc
> It seems this is not actually the case, but swc still seems to depend on
> having a rust nightly compiler available.
> 
> - Jelle

It seems that a nightly compiler is only used for an optimization flag:
commenting out the -Z thinlto=no line in .cargo/config in swc's repo
made it pass `cargo check' just fine.

Regards,
Jakub Kądziołka

Jelle Licht wrote on 7 Aug 2020 00:53

Recipients:

Message-ID:87tuxfe67y.fsf@jlicht.xyz

Jakub Kądziołka <kuba@kadziolka.net> writes:

Toggle quote (10 lines)> On Fri, Jul 31, 2020 at 11:37:24PM +0200, Jelle Licht wrote:
>> It seems this is not actually the case, but swc still seems to depend on
>> having a rust nightly compiler available.
>> 
>> - Jelle
>
> It seems that a nightly compiler is only used for an optimization flag:
> commenting out the -Z thinlto=no line in .cargo/config in swc's repo
> made it pass `cargo check' just fine.

Indeed it does; does that fix this problem for us? At this stage, I end

up with a library that was built successfully, but no clue how to

continue from here. Either way, progress! ;)

- Jelle

Jakub Kądziołka wrote on 7 Aug 2020 15:58

Recipients:(name . Jelle Licht)(address . jlicht@fsfe.org)

Message-ID:20200807135839.pr2cnyqmnlandx3l@gravity

On Fri, Aug 07, 2020 at 12:53:53AM +0200, Jelle Licht wrote:

Toggle quote (4 lines)

> Indeed it does; does that fix this problem for us? At this stage, I end

> up with a library that was built successfully, but no clue how to

> continue from here. Either way, progress! ;)

Hmm, it seems that the main way to use swc is by a wrapper written in
TypeScript (node-swc/src), which is built with neon, also a tool written
in TypeScript. However, it seems that it shouldn't be too hard to invoke
swc with just Rust, with something along the lines of examples/usage.rs

Regards,
Jakub Kądziołka

Jelle Licht wrote 5 days ago

Re: bug#42639: [PATCH] bump Node to 14.6

Recipients:(address . 42639-done@debbugs.gnu.org)

Message-ID:878rd8p18s.fsf@fsfe.org

We now have node@18 on master, and worked around the bootstrapping issue

using a different solution (esbuild). Closing.

Closed

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 42639@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date